DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Raslan Darawsheh <rasland@mellanox.com>,
	Erez Ferber <erezf@mellanox.com>,
	Ali Alnubani <alialnu@mellanox.com>,
	Wisam Monther <wisamm@mellanox.com>,
	Olga Shern <olgas@mellanox.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: disable ConnectX-4 Lx Multi Packet Send by default
Date: Wed, 15 Aug 2018 17:11:34 +0000	[thread overview]
Message-ID: <21F5BB41-E163-4D6B-8DE3-4FE9EE67E822@mellanox.com> (raw)
In-Reply-To: <20180815121730.87525-1-shahafs@mellanox.com>


> On Aug 15, 2018, at 5:17 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
> 
> On ConnectX-4 Lx the Multi Packet Send (MPW) feature is considered
> un-secure, as on some cases were the application provides incorrect mbufs
> on the Tx burst the host or NIC can get stuck.
> 
> Hence, disabling the feature by default for this specific NIC.
> Users can still enable this feature and enjoy the performance gain
> (mostly for low number of cores) by using the txq_mpw_en devarg.
> 
> This patch will impact the out of the box performance of some application
> using ConnectX-4 Lx for the sack of security and robustness.
> 
> Since we need different defaults based on the underlying device the mpw
> field in the configuration struct was extended to contain also the
> MLX5_ARG_UNSET option.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---

Acked-by: Yongseok Koh <yskoh@mellanox.com>
 
Thanks

  reply	other threads:[~2018-08-15 17:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13  7:00 [dpdk-dev] [PATCH] " Shahaf Shuler
2018-08-14 16:32 ` Yongseok Koh
2018-08-15 12:17 ` [dpdk-dev] [PATCH v2] " Shahaf Shuler
2018-08-15 17:11   ` Yongseok Koh [this message]
2018-08-16 11:57     ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21F5BB41-E163-4D6B-8DE3-4FE9EE67E822@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=alialnu@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=erezf@mellanox.com \
    --cc=olgas@mellanox.com \
    --cc=rasland@mellanox.com \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=wisamm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).