From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20065.outbound.protection.outlook.com [40.107.2.65]) by dpdk.org (Postfix) with ESMTP id 005D0324B; Wed, 15 Aug 2018 19:11:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yiuuGKqI8o0q6NNWrSyezMJJKGDoTI4t1cLftI7/qRo=; b=rQEI1f0BhvKH1DrPSZrSBbLkryDvPpAnnDejkSDjcfG9hraM5YuwmZ3MHgtExqrA58qh8o6Pfiyj6NeJA2OmPBNZ0VNXRYKQDfuvMw2eeTyLUhAMEI3Q1qOZP6SJALSrTgkmOmPG8eiOab/gThi8zqPRr4Ir1n/h/Fjr8HXx+/4= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4009.eurprd05.prod.outlook.com (52.134.72.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.19; Wed, 15 Aug 2018 17:11:34 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::112:180c:634a:c61c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::112:180c:634a:c61c%2]) with mapi id 15.20.1017.022; Wed, 15 Aug 2018 17:11:34 +0000 From: Yongseok Koh To: Shahaf Shuler CC: "dev@dpdk.org" , Raslan Darawsheh , Erez Ferber , Ali Alnubani , Wisam Monther , Olga Shern , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: disable ConnectX-4 Lx Multi Packet Send by default Thread-Index: AQHUNJN+j7HBtFqfEkWmx94KR5js3KTBDOCA Date: Wed, 15 Aug 2018 17:11:34 +0000 Message-ID: <21F5BB41-E163-4D6B-8DE3-4FE9EE67E822@mellanox.com> References: <20180813070018.101262-1-shahafs@mellanox.com> <20180815121730.87525-1-shahafs@mellanox.com> In-Reply-To: <20180815121730.87525-1-shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4009; 6:dtxcbRepo+FWOf+zZfEfhOTeYByUb7kqHdbACrco1j1enPCqwuC9ORRuD4SeMGq3EcAD+/3SzqLDvENvdEafDj3SZ02IYFyDMPerG7BEDgSa+qFSOUViRRirIHxd2mr5UwhdcOF6ZAyGgJhJ/+IGU4mnuzwd7N7bhdu8HR3ajrOy73Rh8nfILgUjnVvuQwmqcFuQ8HnWjVCsqLM5hWeVjD2ISrCCYR16LWajhVeHvwSCpQde6kSdCdvgcQKc04CfqEySm+m2OfQPpY/lEvENxMusjXA/CsRhqPqRYoTs80QOQfYA5OzrVSamW7s4Z0q3iSD3Mew/5r6XATEv6/nbnjRKJXGFtjPKiOy2SBxbrTaBuKVpoW+KkmmWfb0a9HOiQdCBYaxBA43lOuY9F0p1VhmcjUsUO1bR1hoGvIwvHApuEgR8AaEMV1ltx0cA/xhlXb0bDcN84NXxKnkY+Zhulw==; 5:oozQbMVwpW0CYgCoy9oBGgJGYIC+mrwC6lJffP99xAUC3+esflZ0rAGnJ8a3pLC2quzGuCpqFMiMtz4ikbYjDoEyeOH/z9sU2AgC8OK/xe9g4dqN95tpkqfq2IK4rD9MBbzn2RJMUHEaiz9ugNwTf7L3zriBbM9VJRo+k73xiwQ=; 7:LqUsO9IK5S9emvXVmKRP54yv6iLzm8YuSFx8FPDP/4DYlZlV9N13g6x8J4VNYqO5sPTgH319GvU/ua3TemV3CzdjW/m5k/ykTaOJMFmK+5r0e0s8PzN1dksj5DSfFRAUp2/xbDen4JVESTB4kUfzhYFzqyDsLqbgAuKb3QL3AaLmNz9jcS59tiAu5wGK6bKnx8wJhlWjsoYGqK6rVE+xxOGLOwVkvt1YUn7TlJCWG2DjDKeJvcrqFuUtNNtKqify x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: bba42570-ca5d-4a9d-517d-08d602d22785 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4009; x-ms-traffictypediagnostic: DB3PR0502MB4009: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(192374486261705); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301033)(3002001)(93006095)(93001095)(10201501046)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB3PR0502MB4009; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4009; x-forefront-prvs: 07658B8EA3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(366004)(346002)(136003)(376002)(199004)(189003)(8936002)(53546011)(5660300001)(102836004)(229853002)(83716003)(36756003)(6512007)(2900100001)(86362001)(6636002)(105586002)(6862004)(33656002)(2616005)(6506007)(486006)(76176011)(476003)(6246003)(2906002)(106356001)(53936002)(450100002)(14444005)(256004)(4326008)(5250100002)(68736007)(66066001)(14454004)(6486002)(11346002)(446003)(7736002)(82746002)(99286004)(316002)(6436002)(25786009)(97736004)(305945005)(54906003)(81166006)(37006003)(6116002)(3846002)(478600001)(8676002)(81156014)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4009; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: GhyZY28qFrgBg6Hnpb98mFGOe5SNtCuhD/2LShImPlw9Fr/qdSM151ulj+PS/k0ICczeV4MbVLTVk020KNA6LdBc1sTTXBIrQ3VmlMJeOCyj7nBP4M5xw4elw7+PzvtakIhCHnxoYa8awO3PMgMDsfBfukTiNpyThSVp4f+vviG1xhwPLZrb37NmfzTO2ZnRsYpy+KTraYdnacF0/oonHv7rEHqExYzkrjkWbCuq1zzG52czsfcQO0blg1hivp9mKnDcKX2+tuGIset49LsRjoBWjg+Pa8M63vSDp7hyShGByiwrVueJePWn/xyoa0lETVr5AQe2BgQNm/+Ksobl//a8pIMv6txMa2c8+p3P0So= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <824F1D74C9A92641B9CC9EDED1C2C825@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: bba42570-ca5d-4a9d-517d-08d602d22785 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2018 17:11:34.7409 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4009 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: disable ConnectX-4 Lx Multi Packet Send by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 17:11:36 -0000 > On Aug 15, 2018, at 5:17 AM, Shahaf Shuler wrote: >=20 > On ConnectX-4 Lx the Multi Packet Send (MPW) feature is considered > un-secure, as on some cases were the application provides incorrect mbufs > on the Tx burst the host or NIC can get stuck. >=20 > Hence, disabling the feature by default for this specific NIC. > Users can still enable this feature and enjoy the performance gain > (mostly for low number of cores) by using the txq_mpw_en devarg. >=20 > This patch will impact the out of the box performance of some application > using ConnectX-4 Lx for the sack of security and robustness. >=20 > Since we need different defaults based on the underlying device the mpw > field in the configuration struct was extended to contain also the > MLX5_ARG_UNSET option. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Shahaf Shuler > --- Acked-by: Yongseok Koh =20 Thanks