From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 4F5551B4EC for ; Thu, 11 Oct 2018 12:53:59 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id C3B57940082; Thu, 11 Oct 2018 10:53:57 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 11 Oct 2018 11:53:47 +0100 To: Thomas Monjalon , CC: , , , References: <20180907230958.21402-1-thomas@monjalon.net> <20181007220933.4533-1-thomas@monjalon.net> <20181007220933.4533-2-thomas@monjalon.net> From: Andrew Rybchenko Message-ID: <21a07d94-44cc-9e99-1474-a13de77915ea@solarflare.com> Date: Thu, 11 Oct 2018 13:53:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181007220933.4533-2-thomas@monjalon.net> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24148.003 X-TM-AS-Result: No-12.447900-8.000000-10 X-TMASE-MatchedRID: L8tZF6zWW2oOwH4pD14DsPHkpkyUphL9uLwbhNl9B5X4JyR+b5tvoOln +pgUTqXBuIA/hwcjvFZuTK43U2r81q23CuWprcjSA9lly13c/gHUqhJbkmLVe/002DXYmoa1KhH e4lFqVUKkRgEg7nrRyuutPg6r34pTgiIO7Sf/7rE00dkxYNMRt4n4DdeD/uLNw7+XQ3Lk9nkahn O4XreYZsKUJu2Xw7QrBQjMb/mhrWkunZpUlUQfX506nVOMOuVpHAwy0XhreD35lA8aRaIEF6PFj JEFr+olA9Mriq0CDAgBi3kqJOK62XnN0DN7HnFm1xQ1o6pfCj2WuEkGogdKk/gcw2o55qG2/QHX mUORA0wQIDnN/+3peZz0KPeMQc1YT6ZpXUOw2LTKLkYrZAgdKnl1f6Jm/lIwftwZ3X11IV0= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--12.447900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24148.003 X-MDID: 1539255238-tDu9mOWrHI3r Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 1/3] drivers/bus: move driver assignment to end of probing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 10:53:59 -0000 On 10/8/18 1:09 AM, Thomas Monjalon wrote: > The PCI mapping requires to know the PCI driver to use, > even before the probing is done. That's why the PCI driver is > referenced early inside the PCI device structure. See > 1d20a073fa5e ("bus/pci: reference driver structure before mapping") > > However the rte_driver does not need to be referenced in rte_device > before the device probing is done. > By moving back this assignment at the end of the device probing, > it becomes possible to make clear the status of a rte_device. > > Signed-off-by: Thomas Monjalon > --- > diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c > index c7695d108..d63e68045 100644 > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > @@ -160,14 +160,12 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, > * driver flags for adjusting configuration. > */ > dev->driver = dr; > - dev->device.driver = &dr->driver; It breaks net/sfc and I guess other drivers which use rte_eth_dma_zone_reserve() from probe. The function makes zone name using dev->device->driver->name. Andrew.