From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 163EDA0471 for ; Thu, 20 Jun 2019 20:24:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4638B1D434; Thu, 20 Jun 2019 20:24:51 +0200 (CEST) Received: from mx0.arrikto.com (mx0.arrikto.com [212.71.252.59]) by dpdk.org (Postfix) with ESMTP id 21E0E1D42B for ; Thu, 20 Jun 2019 20:24:49 +0200 (CEST) Received: from troi.prod.arr (mail.arr [10.99.0.5]) by mx0.arrikto.com (Postfix) with ESMTP id DCBE6182004; Thu, 20 Jun 2019 21:24:48 +0300 (EEST) Received: from [10.89.50.133] (unknown [10.89.50.133]) by troi.prod.arr (Postfix) with ESMTPSA id 74FFB2B2; Thu, 20 Jun 2019 21:24:48 +0300 (EEST) To: Bruce Richardson Cc: Aaron Conole , dev@dpdk.org, Maxime Coquelin , Tiwei Bie , Zhihong Wang , Stefan Hajnoczi , Wei Wang , Stojaczyk Dariusz , Vangelis Koukis References: <1560957293-17294-1-git-send-email-ndragazis@arrikto.com> <1560957293-17294-2-git-send-email-ndragazis@arrikto.com> <20190620103001.GD728@bricha3-MOBL.ger.corp.intel.com> From: Nikos Dragazis Message-ID: <21c88d80-1e1e-1880-a72e-2562ae53a640@arrikto.com> Date: Thu, 20 Jun 2019 21:24:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190620103001.GD728@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 01/28] vhost: introduce vhost transport operations structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20/6/19 1:30 μ.μ., Bruce Richardson wrote: > On Wed, Jun 19, 2019 at 04:14:09PM -0400, Aaron Conole wrote: >> Nikos Dragazis writes: >> >>> This is the first of a series of patches, whose purpose is to add >>> support for the virtio-vhost-user transport. This is a vhost-user >>> transport implementation that is different from the default AF_UNIX >>> transport. It uses the virtio-vhost-user PCI device in order to tunnel >>> vhost-user protocol messages over virtio. This lets guests act as vhost >>> device backends for other guests. >>> >>> File descriptor passing is specific to the AF_UNIX vhost-user protocol >>> transport. In order to add support for additional transports, it is >>> necessary to extract transport-specific code from the main vhost-user >>> code. >>> >>> This patch introduces struct vhost_transport_ops and associates each >>> device with a transport. Core vhost-user code calls into >>> vhost_transport_ops to perform transport-specific operations. >>> >>> Notifying callfd is a transport-specific operation, so it belongs to >>> trans_af_unix.c. >>> >>> Several more patches follow this one to complete the task of moving >>> AF_UNIX transport code out of core vhost-user code. >>> >>> Signed-off-by: Nikos Dragazis >>> Signed-off-by: Stefan Hajnoczi >>> --- >> You'll need to also accommodate the meson build - probably with >> something like: >> >> diff --git a/lib/librte_vhost/meson.build b/lib/librte_vhost/meson.build >> index 3090bbe08..81b70683b 100644 >> --- a/lib/librte_vhost/meson.build >> +++ b/lib/librte_vhost/meson.build >> @@ -14,6 +14,6 @@ allow_experimental_apis = true >> cflags += '-fno-strict-aliasing' >> sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vdpa.c', >> 'vhost.c', 'vhost_user.c', >> - 'virtio_net.c', 'vhost_crypto.c') >> + 'virtio_net.c', 'vhost_crypto.c', 'trans_af_unix.c') >> headers = files('rte_vhost.h', 'rte_vdpa.h', 'rte_vhost_crypto.h') >> deps += ['ethdev', 'cryptodev', 'hash', 'pci'] >> >> > Yep, except I think we should try and keep the files in alphabetical order, > with only a couple of entries per line [so place trans_af_unix.c on a new > line with vdpa.c]. Ack