From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix port init failure in mergeable mode
Date: Fri, 5 Nov 2021 10:00:18 +0100 [thread overview]
Message-ID: <21eaba70-dbc4-6cb6-ad17-b4499fa55b23@redhat.com> (raw)
In-Reply-To: <DM6PR11MB3499E2050FED31528232732C9C8E9@DM6PR11MB3499.namprd11.prod.outlook.com>
On 11/5/21 08:32, Xia, Chenbo wrote:
> Hi Maxime,
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Chenbo Xia
>> Sent: Thursday, November 4, 2021 1:11 PM
>> To: dev@dpdk.org
>> Cc: maxime.coquelin@redhat.com
>> Subject: [dpdk-dev] [PATCH] examples/vhost: fix port init failure in mergeable
>> mode
>>
>> When the example starts in mergeable mode with an i40e port,
>> it fails to launch because the examples use default mtu MAX_MTU
>> to configure ethdev. The root cause is some devices have Ethernet
>> frame overhead and then MAX_MTU will be larger than device's max
>> mtu, so the ethdev configure will fail.
>>
>> This patch checks the device's max mtu before setting the ethdev
>> configuration. If the device has a max mtu, use that value to
>> configure.
>>
>> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length")
>>
>> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
>> Reported-by: Xingguang He <xingguang.he@intel.com>
>> ---
>
> I see a unit test failure on this patch, but I think this patch should not cause
> issues in unit test, could you help me confirm it?
I can confirm, mcslock_autotest is not related to your change, and it
seems other patches are facing the same issue, eg:
https://lab.dpdk.org/results/dashboard/patchsets/19997/
Maxime
> Thanks,
> Chenbo
>
next prev parent reply other threads:[~2021-11-05 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 5:11 Chenbo Xia
2021-11-05 7:32 ` Xia, Chenbo
2021-11-05 9:00 ` Maxime Coquelin [this message]
2021-11-16 9:14 ` Maxime Coquelin
2021-11-16 10:25 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21eaba70-dbc4-6cb6-ad17-b4499fa55b23@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).