From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D663A0C61; Fri, 5 Nov 2021 10:00:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68C9F40DDA; Fri, 5 Nov 2021 10:00:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id CD61240689 for ; Fri, 5 Nov 2021 10:00:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636102842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dv69gOPVUHNdFGU48D2kcxt30NfMpd4lbJSFBAemhx4=; b=Uc2/07dbv3iT/iyGpkj5yOdIB+zyzp6F3XAv7K2t2Se9nM/8oWq/tJcRpq9Lm2SOGNxT5+ /deSeUKuSfPv9bZyvGE+bQjfqEVeo9kkazhFvQK64ipRtWrLVQf+UysEQkRn2TkLNpvd5B hMUKh62uprNUadgCHVi0hVK/dtOB0lc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-3fIIqfgFME-kUoEbIHm99Q-1; Fri, 05 Nov 2021 05:00:21 -0400 X-MC-Unique: 3fIIqfgFME-kUoEbIHm99Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 94F838066EB; Fri, 5 Nov 2021 09:00:20 +0000 (UTC) Received: from [10.39.208.16] (unknown [10.39.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA4E25D9D3; Fri, 5 Nov 2021 09:00:19 +0000 (UTC) Message-ID: <21eaba70-dbc4-6cb6-ad17-b4499fa55b23@redhat.com> Date: Fri, 5 Nov 2021 10:00:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: "Xia, Chenbo" Cc: "dev@dpdk.org" References: <20211104051102.7155-1-chenbo.xia@intel.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix port init failure in mergeable mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/5/21 08:32, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: dev On Behalf Of Chenbo Xia >> Sent: Thursday, November 4, 2021 1:11 PM >> To: dev@dpdk.org >> Cc: maxime.coquelin@redhat.com >> Subject: [dpdk-dev] [PATCH] examples/vhost: fix port init failure in mergeable >> mode >> >> When the example starts in mergeable mode with an i40e port, >> it fails to launch because the examples use default mtu MAX_MTU >> to configure ethdev. The root cause is some devices have Ethernet >> frame overhead and then MAX_MTU will be larger than device's max >> mtu, so the ethdev configure will fail. >> >> This patch checks the device's max mtu before setting the ethdev >> configuration. If the device has a max mtu, use that value to >> configure. >> >> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") >> >> Signed-off-by: Chenbo Xia >> Reported-by: Xingguang He >> --- > > I see a unit test failure on this patch, but I think this patch should not cause > issues in unit test, could you help me confirm it? I can confirm, mcslock_autotest is not related to your change, and it seems other patches are facing the same issue, eg: https://lab.dpdk.org/results/dashboard/patchsets/19997/ Maxime > Thanks, > Chenbo >