From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0040.outbound.protection.outlook.com [104.47.36.40]) by dpdk.org (Postfix) with ESMTP id 9FCB8902 for ; Tue, 11 Oct 2016 15:52:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gPdaIIwuKl23rK8vx/421LMnO65MzsYTARyatHJ7W5o=; b=KAX1Yj5qdtlSMyWIikPGpIBnsIBx+VIzH95ZMOBHBiFPl0nw744XtJQh5HmOwl/GPuOuOpv+ACJlLFQlkyI8rsmdZhmBg4ryHN2uQ43qayEsTE28DXq8TwgURcyt40J1yAltq8rDhNMHuN1023zwvtrZ/JYK0ZUYp1Kh23oDtXk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Kamil.Rytarowski@cavium.com; Received: from localhost.localdomain (31.172.191.173) by DM5PR07MB3065.namprd07.prod.outlook.com (10.172.88.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Tue, 11 Oct 2016 13:52:53 +0000 To: Ferruh Yigit , References: <1472230448-17490-1-git-send-email-krytarowski@caviumnetworks.com> <1475237154-25388-1-git-send-email-krytarowski@caviumnetworks.com> <1475237154-25388-15-git-send-email-krytarowski@caviumnetworks.com> <90a90355-4f83-1def-081b-070924dd60d0@intel.com> <9d573206-79c8-b82f-e47f-f8b300112123@caviumnetworks.com> <95a9ad76-5d2c-d174-7069-e116733ff4af@intel.com> CC: , , , , , From: Kamil Rytarowski Message-ID: <21f60d2a-b662-450f-8a6e-42cb0cbc5d09@caviumnetworks.com> Date: Tue, 11 Oct 2016 15:52:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <95a9ad76-5d2c-d174-7069-e116733ff4af@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [31.172.191.173] X-ClientProxiedBy: VI1PR0101CA0017.eurprd01.prod.exchangelabs.com (10.166.38.27) To DM5PR07MB3065.namprd07.prod.outlook.com (10.172.88.139) X-MS-Office365-Filtering-Correlation-Id: ead4aed4-3a98-4057-f72e-08d3f1dde6df X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3065; 2:BGcXk5V2qsoVuTiUGLh25eNIgty1Kfom1Y3mdDcS11HEJQn8qUoWvtXK568HMeZqvgRu33tm2432mMdolhrBZ4vCoZPZ3V1VwII5pwVoqbYOZ/TBGXlDAiExFGtK2PefnxTy6SQy1cDoz5e5w+83tCDDk0O7x060tuNuNG75G7+42nYCd7Zzovf5xuZUMZYGDze81kfqhygNruIGJOu10A==; 3:U+qY/PckvcWHYs0Awqxg93YALz/s4biXNB6kOIv2OZUbI5qdRRfNx5voBLLevYnzzbQJb431YKDgVm8oF0QaElGGVP/WQtkCY++BrT7OxvamjMIrQ2FRvj6ZPiUxhAHeFIKWPZFLtSeMkkt4H09FPQ==; 25:5B//7vmGOrvUdXPxvrtVIwKgsdpmNgMptyuHcItojnn939lcFgmtOe81Cva9ES51JzKRQCsx2Y5SlWT1auRg69w34sZw9HWKjKZuZrZ5ZqqhIVtBempu4F8usQ5VqmN9ZJRfC/vdBWD5MJyOmFfnA3ypSv6w5EQgsVKfL/O+icsu4NO5Z2/TMlwwr3sDGZH/BKqxbklSQYbMqD2aNoHnm9mWHGVaxeEHlfHOC3TtgTht6r5KjA6c37kCTFi7vFG3vBlV0hKvsdrxhjBnE7Sldg4rOhClsVMYiozJHLisrZWom/ghCP1T2gsbZm5plEt4t52j34LydB1SlX2Jcqyf84IhpP/PAONCvb9I+Vq0yHIIdi3IKmOQkK228+bGrjRWHTUK3VFIAQknQ3tfOCo6Xam31xXstYoNJJf47GCvJ8CJrEGyRloZAIka4JZBtn9I X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR07MB3065; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3065; 31:xLADWxAObR1glrBkFQRnLiD7v37MOgnbHLGFgEJayA0mDUP4mC77RxKGOc9ha5a3VLm/brCE+DC8PeqBZP5Cd7BRayyk/29C80z4Umn8Hxt65J70f27/rwXObKg8/lh0cmjq+ubcM6M+S8IOaGNouQiz1DfF0hlRjIQCn9LRzD3ksG3wzk21jyC8u7Hjt2NXXEUDxctWuI+w3qC1yN4mhfYpDIHBf1HQ7q8qIT+rB43UvpByIAK4lzeear9FYkIA; 20:l1MfvCCs9Gt7SwLionTRRKCTwNF9vg3Vm9zsEeB1gGONRbole4k+YylvW+8oYCNDikaGNzrkmhYv4/uWo2k5swNtVpcfnRuf7kwsO/founkACnTF6jeep+/lfn3KB7XUc/VR3EYEIpxwKvtwW287b2XWwPXIj3h5PceTgDlyA4PoXY2fLJRhT47jW/tTx3BNgHpkcR8j0mqTFvf0yLJaC2rH4rxZVBgXU6hbvgGaUgJjkv9eMwdk/j0wF5wd8fax0S91KtQObrohKG57+ziehUpBZbJgljhy+SXDkm8Ydja4uPxu9oRbvcd/fNHqFLF/dUhmiIwJL4EeYkYitROzUNb1v2ewP8wUvWjUAkbRXpF+rOJLt18fWMheBBOu0G41llxSxxyn3Fw69FQsgCc1XFNP4cTUz8hayUAsCX6ohIw/V/MX2+EeKX/ueVdMaHqXUF3woio2yI6I/zpTO0tL7D4xu4YAMSdPeFLdlqsAEZihwSySfF6yqiBWI/aU6l2mSIZg1ytKpsd6AhA71Ery7Y5x1J/y+du7rt26gVoOemqM3qLlsb0BPdoersi9+4fiM3bRbEi6FglDWwDo0WY5+9Yxiyjn1FJPuFmpXGF1nSw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:DM5PR07MB3065; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3065; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3065; 4:KQmzslosqRww1ijuuqyFLemx0s7TmZu83j2HZW7l4sMNYpn8PKFbvjSPqh3Sy4x1Oobmrq/RCCie32aN6HMZtKFXKVXS/AGff2+DyKl47o/3GpHs5QhB5UqOJCmwiuiO3g+KZFOc6cwHNFYmTwh7gFuSj9m/leqXTdHpv8rbug+9xHiorAhywynucvnVpjwz1UJTFy9pIjHqG7mxJYbCvSzU7prMDicnlodtv1E1Lpi9J8/+wUvFC5SiyuCEkYIawUJG+MJB9JuMpBDl7vHnvJkVsZFCbeGwBuLzMakxzrUmFOzKStLSOcNdF+m2FCVJ3V6eMsOWcG3GhDCAr4y7nr6YxkL4966Hr0F/g2tbLjxaWx6gR7am3/UZIYzM2MozL1GzBgfcBINXxqHaAvgajA== X-Forefront-PRVS: 00922518D8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(377454003)(189002)(24454002)(199003)(65826007)(4326007)(305945005)(4001350100001)(77096005)(7736002)(64126003)(83506001)(101416001)(19580405001)(97736004)(19580395003)(2906002)(106356001)(23746002)(31696002)(36756003)(230700001)(7846002)(6666003)(105586002)(5001770100001)(31686004)(6116002)(47776003)(65806001)(65956001)(66066001)(42186005)(33646002)(5660300001)(189998001)(81156014)(3846002)(54356999)(50466002)(586003)(42882006)(50986999)(68736007)(76176999)(8676002)(93886004)(92566002)(2950100002)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3065; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR07MB3065; 23:9iQWaf85PEYjiRLxKWrQEPA/ilX7pX2Sz+0zt?= =?Windows-1252?Q?4C8K5jtzy5Q1Pna4RqIN6TDBrlHuQFwra9kXEMCo9jCEV8/gx4xv2wgs?= =?Windows-1252?Q?RcDnDpW/p5Voi+SQhkNCPMC9QW/D7rfl+tSQLOUWBkQFomA+7UziwQ5F?= =?Windows-1252?Q?TG9+IzKG89bFyjrMQL/yvJ1wqDg+f1lE6erMzWL3CauYpbJRC3RTIcYX?= =?Windows-1252?Q?x62SHAOqDYvOlGNZYibZZjY+T3OdtrvK5eoTd639Vj0NOhKSEDhi4os+?= =?Windows-1252?Q?/Ev57KCVVffi+2lkapB+U4WCFATLG41a3MfPQaGWrIQSQYdQohf3qHwk?= =?Windows-1252?Q?/DcOcX7rA/U7TnWLgtLJ9m5MJ1efylLdKPlz/OlUttOTiNkEaMLlzJDN?= =?Windows-1252?Q?ste8UaBU/ramdFoZbFrSW1R36ELprlCXuYaYHkYVpd32N9KGNyGMj+rV?= =?Windows-1252?Q?wWLBmysGitISm40MGi5+RyzMa+nKGnao/CaeB/xfbpHLWPGjma5633PA?= =?Windows-1252?Q?PafeIO4ZbX12ShdcSk0aHg5twrXzVNXExEgca6pvd8xgZ+erwHVSMslN?= =?Windows-1252?Q?777xKNf6yLAyv3tzo26sA+lSNECJMxhVSaHfTeh9yj5NX1lODrBpr26d?= =?Windows-1252?Q?EhHLJyCn0ZQS9g1VY1wgTUnQx5Kwc4h3TLZEt9a1UswMqX2csCMb2mq9?= =?Windows-1252?Q?opmScpeLsfyI9zBcXwPlX2rIsVwdXbsJS/nz3xJ+2MfgCjK306X6wwfQ?= =?Windows-1252?Q?evg5AwQn0MeqrVvfO4lcb4ljUnJ3p0duFHk2tJ1ARl3c08Iqiuk2r18T?= =?Windows-1252?Q?yBApNouT6F3OdThx0ZNGRSvXt9GVk3aAAYpdvZq9KoZ2r5uIHseBONwT?= =?Windows-1252?Q?6ZPR86bHwKWIkKH30g+ji3OBZrv4S3FffyIZIv+/gCTdUDEJl0MbgHyb?= =?Windows-1252?Q?xeFqVbLElsiZbG4RBv4aA76ma0WMUy8QhwYNV6h1CUzUmwjwMREGCJbI?= =?Windows-1252?Q?sRf2siSb08Kr1IgZ9oFeROz7+Pn402VWIAWrWb349fE2EEt47zKUOJS/?= =?Windows-1252?Q?wlinm+v85Yhv79W1W9ewvPL0W4m/65zkBVOkvkzasGq0Vg78aZj8P4jy?= =?Windows-1252?Q?u+EaMlSMeYInLwYt/SyEX6ox8WGSca5DXsyMwMWnnKsjHtvqnEfvMuCF?= =?Windows-1252?Q?UyVvqzV4bbWbCpilubz+Hhvv5SOBMnutswR3n3Qgl5uHtzEl/pp3Ocow?= =?Windows-1252?Q?7/G8uRALXWf6Z1p4yDfdds9X3kCRc2y00ARgCoo2Pdv92KsCq7Gb6xdZ?= =?Windows-1252?Q?asrvSjQaMBUtAWCy8q8AuKCyzK1G/P5ZhQhU0NMbAE02MNi/QWTvh+Do?= =?Windows-1252?Q?4gfhT7J9u4CBx54EwtyDJDdp1qHAgI3aR97wPXhLNDLuM9BuzhYRGFK+?= =?Windows-1252?Q?NZxQbq192+xn9btXyi/?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3065; 6:tJhMW8hcXrLNMTyZmnHx8D6hxW3q5wb657borfn6150WLCAC/8Pj9Jhp2b8cLY9SkCDGpm/38YVTZenC0n61VOP+TCsMBwaVT0hrvoW/TpZox8j/w/RofcEcz95B+iMVhkmPfYZ7+XEFZnb8Pk/aPBWkp8UaJWDwHiwJIRUgDtwQcQCM4v+vNHoPfDvPkP7GYLqF9rhGTcqkJazmWWCd80rUAwEpXXGhCYDlx+HO+3+oZE+EfOok43GxfmKvqWTypY7alsxG4CuMoQfBVVW0TorowUqmOjw9T9pUydzInvb23GzGMjoi0aP4JAitl2VZ; 5:P7HPCHYPgNynkJt8fKYnJBX2lGFKEnsziO4u86y6ggoa8KzLy4Eqd8Dv6Lp6K9OORplX2Q6EO821atNU3dxzVbQrcIZ+6ZflQZFUBcyCL4N6Qso5PS/eiRzZHf8a81/jAQR73BT2+q+CIIorTafpvePeNgl4a2LFeNIi0/kAUXo=; 24:Y1h68nl7kUNA/h8Sh3vbwRFmoWvSeJ5AqZmC4iVNTyolbINClyu8c5XEhjyYkh0Gk2+JWtNXJLz3QNb0oqDepyA1gVO0To9B2mEJpUY+aqM=; 7:8YUClshn0sZgR4EJxlmNfZGLkjIOrFPGLJPaDS38OdpWz/bN1rCpQaMYV8DY0lWdIiuWGVnhgcgkEqdwPyOL08PRAW1ty7aJAvDPEpiOcNJIwK+T9icxyaVtitfcb+Qh5t5Ez+h9plws/krVP4v5LCz+5HMjhGnLhtqdq6xezfogXTrto1k5f4CzyJqSCApIkcn2QGBsh8rZM/dWYj9W43SAT51aSUHh1DEjmF1BahYj5XLtdqjGSDy3/PUFgjCZnHizx6KOeSVXQYQGxZSDCbE1fJgEHB3cto2iyr54utBjc245m8Ld1O7kMZax2wQW+6ABBE2upLa9jYP8B0ZDYyARuMjvvmH6EbJY2FR5IdU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2016 13:52:53.7312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3065 Subject: Re: [dpdk-dev] [PATCH v2 14/15] ethdev: Support VFs on the different PCI domains X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 13:52:57 -0000 W dniu 10.10.2016 o 15:27, Ferruh Yigit pisze: > On 10/10/2016 2:01 PM, Kamil Rytarowski wrote: >> >> W dniu 10.10.2016 o 12:19, Ferruh Yigit pisze: >>> Hi Kamil, >>> >>> On 9/30/2016 1:05 PM, Kamil Rytarowski wrote: >>>> It's possible to have the same numbers for bus, device id and function, >>>> therefore we need to differentiate on domain. >>>> >>>> This enables DPDK with multiple VFs on ThunderX 2-socket hardware. >>>> >>>> Signed-off-by: Maciej Czekaj >>>> Signed-off-by: Kamil Rytarowski >>>> Signed-off-by: Zyta Szpak >>>> Signed-off-by: Slawomir Rosek >>>> Signed-off-by: Radoslaw Biernacki >>>> Signed-off-by: Jerin Jacob >>>> --- >>>> lib/librte_ether/rte_ethdev.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >>>> index 382c959..01d5fb0 100644 >>>> --- a/lib/librte_ether/rte_ethdev.c >>>> +++ b/lib/librte_ether/rte_ethdev.c >>>> @@ -225,7 +225,7 @@ rte_eth_dev_create_unique_device_name(char *name, size_t size, >>>> { >>>> int ret; >>>> >>>> - ret = snprintf(name, size, "%d:%d.%d", >>>> + ret = snprintf(name, size, "%d:%d:%d.%d", pci_dev->addr.domain, >>>> pci_dev->addr.bus, pci_dev->addr.devid, >>>> pci_dev->addr.function); >>>> if (ret < 0) >>>> >>> Is it possible to separate this patch from patchset, this is a ethdev >>> patch and it seems not directly related to the rest of the patchset? >>> >>> Thanks, >>> ferruh >> This patch is directly related with secondary queue set support on >> ThunderX, but it can be skipped in this chain of patches and applied as >> a standalone diff. >> >> Is disabling this one on patch work sufficient? Of course unless there >> are no more comments to produce v3 of the original patch chain "Add >> support for secondary queue set in nicvf thunderx driver". > I think it is sufficient, at least I don't have any more comment for > rest of the patchset and it looks good to me. > >> Should I resubmit it as a new standalone patch? > Can you please resubmit just this one patch, so it can be properly reviewed. > > Thanks, > ferruh > Hi, I've performed the needed actions. This patch should be disabled in the patch-chain and has been resent as a new one.