From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 4B5651B53 for ; Mon, 28 Aug 2017 12:30:50 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 28 Aug 2017 03:30:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,441,1498546800"; d="scan'208";a="123209648" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 28 Aug 2017 03:30:48 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , Raslan Darawsheh Cc: thomas@monjalon.net, jingjing.wu@intel.com, dev@dpdk.org, salehals@mellanox.com References: <1503499024-12480-1-git-send-email-rasland@mellanox.com> <20170828095523.GE8124@bidouze.vm.6wind.com> From: Ferruh Yigit Message-ID: <2200a72f-92bb-c4e6-db9d-b00961fc328b@intel.com> Date: Mon, 28 Aug 2017 11:30:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170828095523.GE8124@bidouze.vm.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2017 10:30:50 -0000 On 8/28/2017 10:55 AM, Gaëtan Rivet wrote: > Hi Raslan, > > Redoing the review with the remarks from Thomas in mind. > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: >> Added hotplug in testpmd, to be able to test hotplug function >> in the PMD's. >> >> Signed-off-by: Raslan Darawsheh >> --- >> app/test-pmd/cmdline.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ >> app/test-pmd/testpmd.c | 18 ++++++++++++++++++ >> app/test-pmd/testpmd.h | 1 + >> 3 files changed, 63 insertions(+) >> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> index cd8c358..b32a368 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -716,6 +716,9 @@ static void cmd_help_long_parsed(void *parsed_result, >> "port config (port_id|all) l2-tunnel E-tag" >> " (enable|disable)\n" >> " Enable/disable the E-tag support.\n\n" >> + >> + " device remove (device)\n" > > I think (device) might be hard to understand for a user. > Maybe (device name)? I am suspicious on adding new root level command to testpmd, it is getting bigger, each command looks OK on its own context, but as a whole app getting more confusing [1]. Since dealing with device is kind of new, it can be OK to create new command tree, but there are already hotplug commands per port: "port attach #PCI|#VDEV_NAME" "port detach #P" perhaps it can be good to keep "attach", "detach" keywords for device to be consistent? "device attach #name" "device detach #name" Also a show equivalent can be added to work in device level: "show device info" [1] http://dpdk.org/ml/archives/dev/2017-August/072764.html