From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9EC941BAE; Thu, 2 Feb 2023 13:03:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2968406A2; Thu, 2 Feb 2023 13:03:53 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 6CCC240689 for ; Thu, 2 Feb 2023 13:03:52 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id F39CA5C01D7; Thu, 2 Feb 2023 07:03:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 02 Feb 2023 07:03:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675339431; x= 1675425831; bh=wi88Efm7AcQLzqMKUm4XvSPOsE8Sn3pGBkHQxO7/m/M=; b=R T7xEPd82r9Cm7ltV5JPq1LWkyu+xYTx36aUUA4G1bJXUOmRllLNYdUY0qxox8uIr x71kC5DzI7pBqKIsnuG4axslvFTXUUv73dS+ZypNq7iEvY0NlyNpP41A8u0cmJVq EFQ5+GUhlbOmb67wEJoBq1MfxTtUFnHp3OPwalp0s4ab2UaCtUvNapsW/EjUFDVW IkmDry4oBcBCc4rSNBEhtPNERWWvu0eIeTNy+H1grqxthTbeqng3Am1fq+qcPL+9 p0ITFoqm/x8djg3HQxihfQpbwiPi7bTS4bI0EjZC/nhSmOtlEWCvlZ8jJgZ4cAW+ yLr0+9x1IFeMeV/PSVcHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675339431; x= 1675425831; bh=wi88Efm7AcQLzqMKUm4XvSPOsE8Sn3pGBkHQxO7/m/M=; b=j 2R6/ys7u/5a4cNXnP0HUf5xzzBq7/Jp9U0TdR/+dbT/MocyJe6wrVwudaPbYHO6f ikPgjS2q6a1ZG48gNAEGHH2MShN7Emc0kRMh3GgPVtl2lugR5dO+rZxAcqZF7MTc UNu+0SHjxuW+eyXUHuLKY+8WCSQSwh6tRMIXjlYs5decBQbVH/Jz8nPlJ1+4RaJz C++BtCE5Tz4/xuHn6yah1a8QWvCXSefkluKRKxQWIvBecZaF+f+jrpo+CpNeBGGE vRarfiQAmR+UpC97ZgWc4ycBehvECCrPZPzk0Kihd/WYRRerfOQIm/CdXAqgxko6 bwAAZ4CQdkvE69yOa4OaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Feb 2023 07:03:50 -0500 (EST) From: Thomas Monjalon To: Ivan Malov Cc: Ferruh Yigit , Jerin Jacob , Andrew Rybchenko , Ori Kam , Nithin Kumar Dabilpuram , Aman Singh , Yuying Zhang , "dev@dpdk.org" , Hanumanth Reddy Pothula , Slava Ovsiienko , Jerin Jacob Kollanukkaran , "david.marchand@redhat.com" Subject: Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation Date: Thu, 02 Feb 2023 13:03:49 +0100 Message-ID: <2202391.PYKUYFuaPT@thomas> In-Reply-To: <49cbeb83-1c51-258c-5d1f-35e9cc597674@arknetworks.am> References: <20221220200250.2413443-1-hpothula@marvell.com> <5058570.GXAFRqVoOG@thomas> <49cbeb83-1c51-258c-5d1f-35e9cc597674@arknetworks.am> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/02/2023 12:55, Ivan Malov: > On Thu, 2 Feb 2023, Thomas Monjalon wrote: >=20 > > OK we are progressing on this topic :) >=20 > Indeed we are. >=20 > > > > 02/02/2023 11:48, Ivan Malov: > >> I apologise, there was a typo in the previous mail: "PMD does > >> not need this API". Should read as "TESTPMD does not need it". > > > > testpmd needs all ethdev API, > > because its purpose is to test the whole all ethdev API. >=20 > Touch=E9. >=20 > > > > Maybe the use of this function is misplaced in testpmd. > > It should be a specific command. >=20 > So.. indeed. A specific command which, as I said, is > invoked explicitly by the person operating testpmd. >=20 > > By the way, what is the driver default if negotiation is not done? >=20 > The answer is in the question. It's the driver's default. > If the driver believes it shall NOT deliver metadata for > the sake of improved performance, default =3D all disabled. > If this delivery is a don't care to performance, then > the driver might want to enable everything by default. >=20 > This decision is made by a PMD maintainer, I take it. I think it is better to have the same default for all drivers. What others think?