From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57637A10DA for ; Fri, 2 Aug 2019 23:51:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E65D1C2F7; Fri, 2 Aug 2019 23:51:49 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 1A4401C2EE for ; Fri, 2 Aug 2019 23:51:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B048521903; Fri, 2 Aug 2019 17:51:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 02 Aug 2019 17:51:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=aJrnlQPKwMDHylNpESr8OFVwWoLXG5/S18y9q34Ei8A=; b=TB480qO/AZZI g9okn5QD5aC64onLrfXrQHmhaPyjTnbhR8GsmEwnbIsR9HvZCgObkz8Q50AXnaUl pJmzVYlFlONfLVTBFVZpcaOfkwsAjWVpaCEP7sqOBO/dEHtFJy4GrDgdREiJfn9s DxUTfbMKFhpGzOArSnpBUJHb+X1kwH0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=aJrnlQPKwMDHylNpESr8OFVwWoLXG5/S18y9q34Ei 8A=; b=fN5/gHgwYPiTrrerxcw3o+LRCrm85NWWCeyqy/cQjUGZisztpAj+hpEOe RYdNe8WJevR3nWLbIVs9E7070v1yjGzkprLbr7M2WV+Q2ff1prgzB8Mu11LfcNPv EoX3brsTvAgwjCqt0TczmZaKDI6IgHLbehaIT9Pr+Ya6kGam/4gicix2Yqh4eF0v pKbngTn0nNCI7M5MgEO7ACNN1agIkrn5LH8KpXVtrFHLnJZ34uux5k6eZIh385TC HZsYj8WKn+B2hWrT8sMu78/BU63qKTkqrZioLtp1nZjeRQQEC0Zg/jSPpqZMd7Wf KUairvTPq04KMC2BzEu5thAIP0kbg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddttddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehrvgguhhgrthdrtghomhdpthhrrghvihhsqdgtihdrtghomhenucfkphep jeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomh grshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 29CFC8005A; Fri, 2 Aug 2019 17:51:46 -0400 (EDT) From: Thomas Monjalon To: Aaron Conole Cc: dev@dpdk.org, Michael Santana , David Marchand , Bruce Richardson , Ferruh Yigit , Luca Boccassi Date: Fri, 02 Aug 2019 23:51:45 +0200 Message-ID: <2202617.ZRiLQY9PMS@xps> In-Reply-To: <20190802212552.8879-2-aconole@redhat.com> References: <20190731145030.19956-1-aconole@redhat.com> <20190802212552.8879-1-aconole@redhat.com> <20190802212552.8879-2-aconole@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] tests: Fix unit tests for shared builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/08/2019 23:25, Aaron Conole: > From: Michael Santana > > Currently many unit tests fail when running tests under shared builds. > This happens because of missing driver dependencies. This is fixed by > explicitly linking in missing drivers for the test application. > > before and after (clang): > https://travis-ci.com/Maickii/dpdk-2/jobs/212329160#L623 > https://travis-ci.com/Maickii/dpdk-2/jobs/212335912#L620 > > Suggested-by: Bruce Richardson > Suggested-by: David Marchand > Signed-off-by: Michael Santana > Signed-off-by: Aaron Conole > Acked-by: Bruce Richardson > Reviewed-by: David Marchand > --- > app/test/meson.build | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/app/test/meson.build b/app/test/meson.build > index e8a898eb6..8afd21dff 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > +# The following linkages are an exception to allow running the > +# unit tests without requiring that the developer install the > +# DPDK libraries. Explicit linkage in applications should not > +# be used. > +if dpdk_conf.has('RTE_LIBRTE_RING_MEMPOOL') > + test_deps += 'mempool_ring' > +endif > +if dpdk_conf.has('RTE_LIBRTE_STACK_MEMPOOL') > + test_deps += 'mempool_stack' > +endif > +if dpdk_conf.has('RTE_LIBRTE_SKELETON_EVENTDEV_PMD') > + test_deps += 'pmd_skeleton_event' > +endif > if dpdk_conf.has('RTE_LIBRTE_PDUMP') > test_deps += 'pdump' > endif I did some changes in comments and line spacing, so it looks like below. Sorry for doing this change myself, I want to allow you running this CI as soon as possible. # The following linkages are an exception to allow running the # unit tests without requiring that the developer install the # DPDK libraries. Explicit linkage of drivers (plugin libraries) # in applications should not be used. if dpdk_conf.has('RTE_LIBRTE_RING_MEMPOOL') test_deps += 'mempool_ring' endif if dpdk_conf.has('RTE_LIBRTE_STACK_MEMPOOL') test_deps += 'mempool_stack' endif if dpdk_conf.has('RTE_LIBRTE_SKELETON_EVENTDEV_PMD') test_deps += 'pmd_skeleton_event' endif # The following linkages of drivers are required because # they are used via a driver-specific API. if dpdk_conf.has('RTE_LIBRTE_BOND_PMD') test_deps += 'pmd_bond' endif if dpdk_conf.has('RTE_LIBRTE_RING_PMD') test_deps += 'pmd_ring' endif if dpdk_conf.has('RTE_LIBRTE_POWER') test_deps += 'power' endif if dpdk_conf.has('RTE_LIBRTE_KNI') test_deps += 'kni' endif if dpdk_conf.has('RTE_LIBRTE_PDUMP') test_deps += 'pdump' endif