From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f175.google.com (mail-we0-f175.google.com
 [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id D0DCE47D2
 for <dev@dpdk.org>; Mon, 30 Jun 2014 10:56:43 +0200 (CEST)
Received: by mail-we0-f175.google.com with SMTP id k48so7800273wev.34
 for <dev@dpdk.org>; Mon, 30 Jun 2014 01:57:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=BJ8iTwu+1D7G65VIP9rNcJlWNKRjGwuKwlThEHpm8lg=;
 b=a8oXntzGfYKvysRAqJW1vNVDO21WC653xiTVPhxzETieBhQPyHUCt8DVaIGEQzfple
 C0aQiX5SgraF9D1dhb9XzOoGB1+RiDgycjr/O9wE/Z9rYgO5RJ4hR2fwaRQIMeRp8t3h
 FM8si1DzLKrhy4mQq+WtuaFxlhRkyakFl/o1W0Ucagu3hJjb463pX8gExWm+7IBIJ73R
 Z2fWRJWi2dF905ZUmdDsls/8BeE4AJTESV0mEJ4dz4a1Dz27JeMt5yY/QAvdmY/wQ/Co
 EP3U48yOzVX7YynB9xF3X2rZaVuTQUWtKtuTPpy1e76ywNNjcbZZ5eXCZWNa0Qu4QTxw
 xbow==
X-Gm-Message-State: ALoCoQk73F69elYQeatMcNBCaCLLziWWm9HvjJ4pGySZ5fvYOqL0l3Ke/WOmBqaFyImEUOyUwIpJ
X-Received: by 10.194.76.212 with SMTP id m20mr43000929wjw.30.1404118623792;
 Mon, 30 Jun 2014 01:57:03 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id gi8sm29066164wib.8.2014.06.30.01.57.02
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 30 Jun 2014 01:57:02 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Declan Doherty <declan.doherty@intel.com>
Date: Mon, 30 Jun 2014 10:56:56 +0200
Message-ID: <2202962.L5WHbECMz2@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <1404064161-26370-5-git-send-email-declan.doherty@intel.com>
References: <1403864324-12022-1-git-send-email-declan.doherty@intel.com>
 <1404064161-26370-5-git-send-email-declan.doherty@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v11 4/5] bond: unit tests
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jun 2014 08:56:43 -0000

Hi Declan,

2014-06-29 18:49, Declan Doherty:
> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y)
> +SRCS-$(CONFIG_RTE_APP_TEST) += virtual_pmd.c
> +SRCS-$(CONFIG_RTE_APP_TEST) += packet_burst_generator.c
> +SRCS-$(CONFIG_RTE_APP_TEST) += test_link_bonding.c
> +endif
>  ifeq ($(CONFIG_RTE_APP_TEST),y)
>  SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) += test_pmd_ring.c

I think there is a cleaner way to fix build without bonding.
See my patch proposal below:

 SRCS-$(CONFIG_RTE_APP_TEST) += virtual_pmd.c
 SRCS-$(CONFIG_RTE_APP_TEST) += packet_burst_generator.c
-SRCS-$(CONFIG_RTE_APP_TEST) += test_link_bonding.c
 ifeq ($(CONFIG_RTE_APP_TEST),y)
 SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding.c
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) += test_pmd_ring.c

-- 
Thomas