From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 90DF31BD89 for ; Mon, 14 May 2018 01:49:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 34C4E25DA7; Sun, 13 May 2018 19:49:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 13 May 2018 19:49:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=UeDwrKdhYPgZp8XUz7H3zO0H78 s76pCBcEm/Z+FaqfQ=; b=ExWPAOkqsE3u8ju0bItPJ0D4z9hvi6RjUMOUhloCsQ PIeeQKb2WUso4jYc42GYd8PcJqMlZVqPPaBUvVMMZa6LCc6d393lG4YE1MJSYQqD nbFMlh2RJgwIMwCNNZlIqBqn3HOObuL7txroFFWv7v9m9r/NuqdJ/YxOU71bbF5t s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=UeDwrK dhYPgZp8XUz7H3zO0H78s76pCBcEm/Z+FaqfQ=; b=XNftFpxuBMYuN9ztDjdi1y TqZ22CREFzD7k1hRXWc7OFKAwdiX3C9CqcYLB4sSgXkpsy58cS2WSb3Q9RhaMX6J r6TrnCpJFu3iEW8vxweCP0Cfik73CQimeeMdSPfOeRm1+OqsqfOxFE+gAsVFsJ4a KXGPxvCOQ5fkb5YrkMdedM7AXEd58NbR8zNGlDpP51eLhQT83+O5kLZ2ZkVuCwR/ ozGEw1o70VZXwwVq4dw7tTk8ZdPqoKGdVs1JUjZW05UNybFh5zvHXNf4uNXrjTCf NN31RkODDSW/LsZoFIgR5GLtgkfy0rIDQ4KbBqPeb72rrNID5/CMtbqONZjQJfPA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 97510E4393; Sun, 13 May 2018 19:49:03 -0400 (EDT) From: Thomas Monjalon To: Andy Green Cc: dev@dpdk.org, Stephen Hemminger Date: Mon, 14 May 2018 01:49:02 +0200 Message-ID: <2204566.stPqTexsKo@xps> In-Reply-To: References: <152609021699.121661.5295227351721865436.stgit@localhost.localdomain> <58706255.BWJRb5PVTu@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 02/24] lib/librte_ethdev: change eth-dev-ops API to return int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2018 23:49:04 -0000 14/05/2018 01:10, Andy Green: > > On 05/13/2018 10:58 PM, Thomas Monjalon wrote: > > 12/05/2018 03:58, Andy Green: > >> Signed-off-by: Andy Green > > [...] > >> --- a/lib/librte_ethdev/rte_ethdev_core.h > >> +++ b/lib/librte_ethdev/rte_ethdev_core.h > >> -typedef uint32_t (*eth_rx_queue_count_t)(struct rte_eth_dev *dev, > >> - uint16_t rx_queue_id); > >> +typedef int (*eth_rx_queue_count_t)(struct rte_eth_dev *dev, > >> + uint16_t rx_queue_id); > >> /**< @internal Get number of used descriptors on a receive queue. */ > > > > What is the reason of this change? > > I thought I wasn't making enough patches, so I randomly started changing > stuff. > > Just kidding. Again, the original version of this patch just fixed the > compiler warning, but Stephen Hemminger > suggested going one level deeper and having this api return an int, so > it has a way to signal errors. It sounded reasonable to me so I did it. OK. You know it's difficult to read the history of this series because you don't use --in-reply-to to keep all revisions in the same thread. At least, please provide some explanations in the message area. Thanks