From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 14C6F1B53 for ; Thu, 28 Dec 2017 22:56:48 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A2F9621B12; Thu, 28 Dec 2017 16:56:48 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 28 Dec 2017 16:56:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=y44G2Xwmwj/pTIMBpdCAgnxryV SpxK0zhRtYt0EATi4=; b=FdKGczj3oZ4rNid8huFU4KheIw+dU7TiOZuMQZ8JxN uOLmMLiDYBMiIs//1mUUMLbSg+5aMLWSfiaLza4yfCP9uP8jajumym22pvueE9ya HR4h8GPN2yf6LvMCYqjI1ttDkxRW9jDicCBGKx6cIZhjLo1d4iAdgNezY6prd7bv o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=y44G2X wmwj/pTIMBpdCAgnxryVSpxK0zhRtYt0EATi4=; b=F37lNEyRLTb7HNWcsh8RgU lUVAkgGArarRV6bvuoC4yN8oJnTytpj7/e76jupBtuTiv+odGS/KmnvBHQIMzO3e 3dgFv0NpN+egS/fRHG+IxEFscJHBrlFcLFD7Cxl47AwtTYIdiY+GZ2XdfAR/X/mH Y369Ytl+fkqDfFyFIghSeMZyP2GQuM57eGhrRfHMszOfzqZwFQIUQpDNX7z2GaMV /cvuF3kZdENgPx2MUYO/91NKWMz49wDf/TySqzz1mhnBrHCH+EEPsZrKxWpZyc4w Zd+mkrnHhi8mF4L0m+A1KHea6f8eFgiRTG8BOI3zK3/QjKcNKo9Ew6bFI9OyiJ3A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1FFC87E13B; Thu, 28 Dec 2017 16:56:48 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org, Ferruh Yigit Cc: bernard.iremonger@intel.com Date: Thu, 28 Dec 2017 22:56:35 +0100 Message-ID: <2205083.4lcr8qjecY@xps> In-Reply-To: <1953628.EychQmWvfA@xps> References: <20171128220951.15317-1-thomas@monjalon.net> <53c8669c-79b9-2f6d-4008-7679aa2cf377@intel.com> <1953628.EychQmWvfA@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: remove useless parameter in callback process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2017 21:56:49 -0000 28/12/2017 22:54, Thomas Monjalon: > 22/12/2017 04:08, Ferruh Yigit: > > On 11/28/2017 2:09 PM, Thomas Monjalon wrote: > > > The pointer to the user parameter of the callback registration is > > > automatically pass to the callback function. > > > There is no point to allow changing this user parameter by a caller. > > > That's why this parameter is always set to NULL by PMDs and set only > > > in ethdev layer before calling the callback function. > > > > It can be helpful to mention a little from history: > > > > user cb_arg overwrite introduced by [1], to enable driver pass a pointer to user > > callback function and carry some information back from app to driver. > > > > Later to prevent usage of cb_arg as both input and output, an explicit output > > (ret_param) added [2] to _rte_eth_dev_callback_process() but previous cb_arg > > overwriting kept without any user. > > > > [1]: c1ceaf3ad056 ("ethdev: add an argument to internal callback function") > > > > [2]: d6af1a13d7a1 ("ethdev: add return values to callback process API") > > > > > > > > The NULL parameter in the internal callback processing function > > > is now removed. It makes clear that the callback parameter is user > > > managed and opaque from a DPDK point of view. > > > > > > Signed-off-by: Thomas Monjalon > > > > Reviewed-by: Ferruh Yigit > > Applied Sorry, not applied (should be applied on next-net). I will send a v2 with a more detailed explanation.