From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 02C5D38EB for ; Mon, 30 Jan 2017 17:34:08 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id b65so39901724wmf.0 for ; Mon, 30 Jan 2017 08:34:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=F+wOWSl5F61NS0rRsHAfTo4iKuN3Xufb+W2/dTvIfm8=; b=Jw5VEPc7g9Iv1WaINykjsCui979Pmb7D27rRkJDr0OV/mhzd7bQtWFZg92wjD1cnU7 e40CVr6TSKTxEH4l+RVshhfmydDFGdR11phbkfrk6VCBBYVT5oI0XXB8cBd7mTf3DIYX WcHX72BoFMPBBOcyUQdvsaAy33zfwed3tPxczFi4n49Ukn+50L+mKAO3WpbYYSyLCNr3 FVy22usZhYJACP8OJiGG4T0UgVoFb0qSQhFYOHiAnyHaYDxUB2+oTsSYnDcCWVbe+ChY u+cHbMq63w2UX8PFgp/G7cE8Xyjz92lwLxln2GKxnDG7fB8xi3DEsi89vpWfH7hiH3of pObA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=F+wOWSl5F61NS0rRsHAfTo4iKuN3Xufb+W2/dTvIfm8=; b=N0DAM2SWNjimwzxRUHnIR+5yxuFy2QWvhCzsTTRQ+Ta8dYbvFzCnmff1PT5EFkFzbw PthlKNgkf8pVKdkbJ1JjOHavmP6M3zGmHDFj8t/0Hbb65XXUxrRK5CtJ3Rw22zV1KFio ie2ysORzB0PQi8p+nrOkikhxqgsShaJ1yhws0cW1RS+PvUHHrQ5TlcHhweezDiFJxlB7 3Zdh63UXnrb0DEj2ZnicJdORWIepC2bpQd4utmLcbBFfx91cpA26SxHyglAznCXOJvQ1 WvIyzbgkejj9VFXHRcrdsxivlqgiBBE05m3Re2dQwJpsOvs9zLJdTyrInm4gAz9DNhun 5CBQ== X-Gm-Message-State: AIkVDXIWWYHcfFHGd2Qfaq1bMjPdEj6CN8u3tuuJZStjvrDUsIItYGFkPUZK65UhnnkdPDeD X-Received: by 10.223.139.93 with SMTP id v29mr10853440wra.70.1485794048428; Mon, 30 Jan 2017 08:34:08 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id c202sm19406363wmd.10.2017.01.30.08.34.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 08:34:07 -0800 (PST) From: Thomas Monjalon To: Yoni Gilad Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com Date: Mon, 30 Jan 2017 17:34:06 +0100 Message-ID: <2205422.pXPzrLqdEW@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1484068461-22978-1-git-send-email-yonig@radcom.com> References: <1483979853-16386-1-git-send-email-yonig@radcom.com> <1484068461-22978-1-git-send-email-yonig@radcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] tools: fix active interface detection in dpdk-devbind.py X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 16:34:09 -0000 2017-01-10 17:14, Yoni Gilad: > When adding crypto devices, the "Active" and "Ssh_if" attributes of > existing network devices were reset. This causes the following issues: > > - Network interfaces aren't marked as "*Active*" in the --status output. > - Active network interfaces can be unbound without the --force option, > causing loss of network connection. > > The reset was caused by the call to devices[d].update in > get_crypto_details. > > This patch prevents the update on non-crypto devices. > > Fixes: cb4a1d14bf3e ("tools: bind crypto devices") > > CC: stable@dpdk.org > > Signed-off-by: Yoni Gilad > Acked-by: Pablo de Lara Applied, thanks