DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Mattias Rönnblom" <hofors@lysator.liu.se>
Cc: "David Marchand" <david.marchand@redhat.com>,
	"Tyler Retzlaff" <roretzla@linux.microsoft.com>,
	"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
	dev@dpdk.org, "Heng Wang" <heng.wang@ericsson.com>,
	"Stephen Hemminger" <stephen@networkplumber.org>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"Jack Bond-Preston" <jack.bond-preston@foss.arm.com>
Subject: Re: [PATCH v3 0/5] Improve EAL bit operations API
Date: Mon, 09 Sep 2024 14:24:33 +0200	[thread overview]
Message-ID: <2206883.Icojqenx9y@thomas> (raw)
In-Reply-To: <6f228b70-8b85-4a91-965d-2b99658c668e@lysator.liu.se>

09/09/2024 14:04, Mattias Rönnblom:
> What one should do is to have extern "C" linkage only on functions which 
> the include file in question (e.g., rte_foo.h) itself declares.
> 
> --
> /* rte_bar.h */
> #include <rte_foo.h>
> 
> #ifdef __cplusplus
> extern "C" {
> #endif
> 
> void
> rte_foo_do(void);
> 
> /../
> --
> 
> There are 259 header files in the DPDK repo in need of fixing.
> 
> Should the fix be 259 patches, or something smaller? One large patch, or 
> a patch per library, or something else. Please advise, over.

Moving includes in the whole tree can be done in a single patch,
there is nothing specific per library in such a mechanical move.




  reply	other threads:[~2024-09-09 12:24 UTC|newest]

Thread overview: 160+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-02 13:53 [RFC 0/7] " Mattias Rönnblom
2024-03-02 13:53 ` [RFC 1/7] eal: extend bit manipulation functions Mattias Rönnblom
2024-03-02 17:05   ` Stephen Hemminger
2024-03-03  6:26     ` Mattias Rönnblom
2024-03-04 16:34       ` Tyler Retzlaff
2024-03-05 18:01         ` Mattias Rönnblom
2024-03-05 18:06           ` Tyler Retzlaff
2024-04-25  8:58   ` [RFC v2 0/6] Improve EAL bit operations API Mattias Rönnblom
2024-04-25  8:58     ` [RFC v2 1/6] eal: extend bit manipulation functionality Mattias Rönnblom
2024-04-29  9:51       ` [RFC v3 0/6] Improve EAL bit operations API Mattias Rönnblom
2024-04-29  9:51         ` [RFC v3 1/6] eal: extend bit manipulation functionality Mattias Rönnblom
2024-04-29 11:12           ` Morten Brørup
2024-04-30  9:55           ` [RFC v4 0/6] Improve EAL bit operations API Mattias Rönnblom
2024-04-30  9:55             ` [RFC v4 1/6] eal: extend bit manipulation functionality Mattias Rönnblom
2024-04-30 12:08               ` [RFC v5 0/6] Improve EAL bit operations API Mattias Rönnblom
2024-04-30 12:08                 ` [RFC v5 1/6] eal: extend bit manipulation functionality Mattias Rönnblom
2024-05-02  5:57                   ` [RFC v6 0/6] Improve EAL bit operations API Mattias Rönnblom
2024-05-02  5:57                     ` [RFC v6 1/6] eal: extend bit manipulation functionality Mattias Rönnblom
2024-05-05  8:37                       ` [RFC v7 0/6] Improve EAL bit operations API Mattias Rönnblom
2024-05-05  8:37                         ` [RFC v7 1/6] eal: extend bit manipulation functionality Mattias Rönnblom
2024-08-09  9:04                           ` [PATCH 0/5] Improve EAL bit operations API Mattias Rönnblom
2024-08-09  9:04                             ` [PATCH 1/5] eal: extend bit manipulation functionality Mattias Rönnblom
2024-08-09  9:58                               ` [PATCH v2 0/5] Improve EAL bit operations API Mattias Rönnblom
2024-08-09  9:58                                 ` [PATCH v2 1/5] eal: extend bit manipulation functionality Mattias Rönnblom
2024-08-12 11:16                                   ` Jack Bond-Preston
2024-08-12 11:58                                     ` Mattias Rönnblom
2024-08-12 12:49                                   ` [PATCH v3 0/5] Improve EAL bit operations API Mattias Rönnblom
2024-08-12 12:49                                     ` [PATCH v3 1/5] eal: extend bit manipulation functionality Mattias Rönnblom
2024-08-12 13:24                                       ` Jack Bond-Preston
2024-09-09 14:57                                       ` [PATCH v4 0/6] Improve EAL bit operations API Mattias Rönnblom
2024-09-09 14:57                                         ` [PATCH v4 1/6] dpdk: do not force C linkage on include file dependencies Mattias Rönnblom
2024-09-09 16:43                                           ` Morten Brørup
2024-09-10  0:50                                           ` fengchengwen
2024-09-10  5:10                                             ` Mattias Rönnblom
2024-09-10  6:20                                           ` [PATCH v5 0/6] Improve EAL bit operations API Mattias Rönnblom
2024-09-10  6:20                                             ` [PATCH v5 1/6] dpdk: do not force C linkage on include file dependencies Mattias Rönnblom
2024-09-10  8:31                                               ` [PATCH v6 0/6] Improve EAL bit operations API Mattias Rönnblom
2024-09-10  8:31                                                 ` [PATCH v6 1/6] dpdk: do not force C linkage on include file dependencies Mattias Rönnblom
2024-09-16 12:05                                                   ` David Marchand
2024-09-17  9:30                                                     ` Mattias Rönnblom
2024-09-18 11:15                                                       ` David Marchand
2024-09-18 12:09                                                         ` Mattias Rönnblom
2024-09-18 12:46                                                           ` Bruce Richardson
2024-09-16 12:13                                                   ` David Marchand
2024-09-10  8:31                                                 ` [PATCH v6 2/6] eal: extend bit manipulation functionality Mattias Rönnblom
2024-09-10  8:31                                                 ` [PATCH v6 3/6] eal: add unit tests for bit operations Mattias Rönnblom
2024-09-10  8:31                                                 ` [PATCH v6 4/6] eal: add atomic " Mattias Rönnblom
2024-09-10  8:31                                                 ` [PATCH v6 5/6] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-09-10  8:31                                                 ` [PATCH v6 6/6] eal: extend bitops to handle volatile pointers Mattias Rönnblom
2024-09-10  6:20                                             ` [PATCH v5 2/6] eal: extend bit manipulation functionality Mattias Rönnblom
2024-09-10  6:20                                             ` [PATCH v5 3/6] eal: add unit tests for bit operations Mattias Rönnblom
2024-09-10  6:20                                             ` [PATCH v5 4/6] eal: add atomic " Mattias Rönnblom
2024-09-10  6:20                                             ` [PATCH v5 5/6] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-09-10  6:20                                             ` [PATCH v5 6/6] eal: extend bitops to handle volatile pointers Mattias Rönnblom
2024-09-09 14:57                                         ` [PATCH v4 2/6] eal: extend bit manipulation functionality Mattias Rönnblom
2024-09-09 14:57                                         ` [PATCH v4 3/6] eal: add unit tests for bit operations Mattias Rönnblom
2024-09-09 14:57                                         ` [PATCH v4 4/6] eal: add atomic " Mattias Rönnblom
2024-09-09 14:57                                         ` [PATCH v4 5/6] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-09-09 14:57                                         ` [PATCH v4 6/6] eal: extend bitops to handle volatile pointers Mattias Rönnblom
2024-08-12 12:49                                     ` [PATCH v3 2/5] eal: add unit tests for bit operations Mattias Rönnblom
2024-08-12 13:25                                       ` Jack Bond-Preston
2024-08-12 12:49                                     ` [PATCH v3 3/5] eal: add atomic " Mattias Rönnblom
2024-08-12 13:25                                       ` Jack Bond-Preston
2024-08-12 12:49                                     ` [PATCH v3 4/5] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-08-12 13:26                                       ` Jack Bond-Preston
2024-08-12 12:49                                     ` [PATCH v3 5/5] eal: extend bitops to handle volatile pointers Mattias Rönnblom
2024-08-12 13:26                                       ` Jack Bond-Preston
2024-08-20 17:05                                     ` [PATCH v3 0/5] Improve EAL bit operations API Mattias Rönnblom
2024-09-05  8:10                                       ` David Marchand
2024-09-09 12:04                                         ` Mattias Rönnblom
2024-09-09 12:24                                           ` Thomas Monjalon [this message]
2024-09-09 12:25                                           ` David Marchand
2024-09-09 13:09                                             ` Mattias Rönnblom
2024-08-09  9:58                                 ` [PATCH v2 2/5] eal: add unit tests for bit operations Mattias Rönnblom
2024-08-09  9:58                                 ` [PATCH v2 3/5] eal: add atomic " Mattias Rönnblom
2024-08-12 11:19                                   ` Jack Bond-Preston
2024-08-12 12:00                                     ` Mattias Rönnblom
2024-08-09  9:58                                 ` [PATCH v2 4/5] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-08-09  9:58                                 ` [PATCH v2 5/5] eal: extend bitops to handle volatile pointers Mattias Rönnblom
2024-08-09 11:48                                   ` Morten Brørup
2024-08-12 11:22                                   ` Jack Bond-Preston
2024-08-12 12:28                                     ` Mattias Rönnblom
2024-08-09  9:04                             ` [PATCH 2/5] eal: add unit tests for bit operations Mattias Rönnblom
2024-08-09 15:03                               ` Stephen Hemminger
2024-08-09 15:37                                 ` Mattias Rönnblom
2024-08-09 16:31                                   ` Stephen Hemminger
2024-08-09 16:57                                     ` Mattias Rönnblom
2024-08-09  9:04                             ` [PATCH 3/5] eal: add atomic " Mattias Rönnblom
2024-08-09  9:04                             ` [PATCH 4/5] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-08-09  9:04                             ` [PATCH 5/5] eal: extend bitops to handle volatile pointers Mattias Rönnblom
2024-05-05  8:37                         ` [RFC v7 2/6] eal: add unit tests for bit operations Mattias Rönnblom
2024-05-05  8:37                         ` [RFC v7 3/6] eal: add exactly-once bit access functions Mattias Rönnblom
2024-05-07 19:17                           ` Morten Brørup
2024-05-08  6:47                             ` Mattias Rönnblom
2024-05-08  7:33                               ` Morten Brørup
2024-05-08  8:00                                 ` Mattias Rönnblom
2024-05-08  8:11                                   ` Morten Brørup
2024-05-08  9:27                                     ` Mattias Rönnblom
2024-05-08 10:08                                       ` Morten Brørup
2024-05-08 15:15                                 ` Stephen Hemminger
2024-05-08 16:16                                   ` Morten Brørup
2024-05-05  8:37                         ` [RFC v7 4/6] eal: add unit tests for " Mattias Rönnblom
2024-05-05  8:37                         ` [RFC v7 5/6] eal: add atomic bit operations Mattias Rönnblom
2024-05-05  8:37                         ` [RFC v7 6/6] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-05-02  5:57                     ` [RFC v6 2/6] eal: add unit tests for bit operations Mattias Rönnblom
2024-05-02  5:57                     ` [RFC v6 3/6] eal: add exactly-once bit access functions Mattias Rönnblom
2024-05-02  5:57                     ` [RFC v6 4/6] eal: add unit tests for " Mattias Rönnblom
2024-05-02  5:57                     ` [RFC v6 5/6] eal: add atomic bit operations Mattias Rönnblom
2024-05-03  6:41                       ` Mattias Rönnblom
2024-05-03 23:30                         ` Tyler Retzlaff
2024-05-04 15:36                           ` Mattias Rönnblom
2024-05-02  5:57                     ` [RFC v6 6/6] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-04-30 12:08                 ` [RFC v5 2/6] eal: add unit tests for bit operations Mattias Rönnblom
2024-04-30 12:08                 ` [RFC v5 3/6] eal: add exactly-once bit access functions Mattias Rönnblom
2024-04-30 12:08                 ` [RFC v5 4/6] eal: add unit tests for " Mattias Rönnblom
2024-04-30 12:08                 ` [RFC v5 5/6] eal: add atomic bit operations Mattias Rönnblom
2024-04-30 12:08                 ` [RFC v5 6/6] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-04-30  9:55             ` [RFC v4 2/6] eal: add unit tests for bit operations Mattias Rönnblom
2024-04-30  9:55             ` [RFC v4 3/6] eal: add exactly-once bit access functions Mattias Rönnblom
2024-04-30  9:55             ` [RFC v4 4/6] eal: add unit tests for " Mattias Rönnblom
2024-04-30 10:37               ` Morten Brørup
2024-04-30 11:58                 ` Mattias Rönnblom
2024-04-30  9:55             ` [RFC v4 5/6] eal: add atomic bit operations Mattias Rönnblom
2024-04-30  9:55             ` [RFC v4 6/6] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-04-29  9:51         ` [RFC v3 2/6] eal: add unit tests for bit operations Mattias Rönnblom
2024-04-29  9:51         ` [RFC v3 3/6] eal: add exactly-once bit access functions Mattias Rönnblom
2024-04-29  9:51         ` [RFC v3 4/6] eal: add unit tests for " Mattias Rönnblom
2024-04-29  9:51         ` [RFC v3 5/6] eal: add atomic bit operations Mattias Rönnblom
2024-04-29  9:51         ` [RFC v3 6/6] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-04-25  8:58     ` [RFC v2 2/6] eal: add unit tests for bit operations Mattias Rönnblom
2024-04-25  8:58     ` [RFC v2 3/6] eal: add exactly-once bit access functions Mattias Rönnblom
2024-04-25  8:58     ` [RFC v2 4/6] eal: add unit tests for " Mattias Rönnblom
2024-04-25  8:58     ` [RFC v2 5/6] eal: add atomic bit operations Mattias Rönnblom
2024-04-25 10:25       ` Morten Brørup
2024-04-25 14:36         ` Mattias Rönnblom
2024-04-25 16:18           ` Morten Brørup
2024-04-26  9:39             ` Mattias Rönnblom
2024-04-26 12:00               ` Morten Brørup
2024-04-28 15:37                 ` Mattias Rönnblom
2024-04-29  7:24                   ` Morten Brørup
2024-04-30 16:52               ` Tyler Retzlaff
2024-04-25  8:58     ` [RFC v2 6/6] eal: add unit tests for atomic bit access functions Mattias Rönnblom
2024-04-25 18:05     ` [RFC v2 0/6] Improve EAL bit operations API Tyler Retzlaff
2024-04-26 11:17       ` Mattias Rönnblom
2024-04-26 21:35     ` Patrick Robb
2024-03-02 13:53 ` [RFC 2/7] eal: add generic bit manipulation macros Mattias Rönnblom
2024-03-04  8:16   ` Heng Wang
2024-03-04 15:41     ` Mattias Rönnblom
2024-03-04 16:42   ` Tyler Retzlaff
2024-03-05 18:08     ` Mattias Rönnblom
2024-03-05 18:22       ` Tyler Retzlaff
2024-03-05 20:02         ` Mattias Rönnblom
2024-03-05 20:53           ` Tyler Retzlaff
2024-03-02 13:53 ` [RFC 3/7] eal: add bit manipulation functions which read or write once Mattias Rönnblom
2024-03-02 13:53 ` [RFC 4/7] eal: add generic once-type bit operations macros Mattias Rönnblom
2024-03-02 13:53 ` [RFC 5/7] eal: add atomic bit operations Mattias Rönnblom
2024-03-02 13:53 ` [RFC 6/7] eal: add generic " Mattias Rönnblom
2024-03-02 13:53 ` [RFC 7/7] eal: deprecate relaxed family of " Mattias Rönnblom
2024-03-02 17:07   ` Stephen Hemminger
2024-03-03  6:30     ` Mattias Rönnblom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2206883.Icojqenx9y@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=heng.wang@ericsson.com \
    --cc=hofors@lysator.liu.se \
    --cc=jack.bond-preston@foss.arm.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=mb@smartsharesystems.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).