From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E14944594A; Mon, 9 Sep 2024 14:24:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 926CF402BB; Mon, 9 Sep 2024 14:24:39 +0200 (CEST) Received: from fout6-smtp.messagingengine.com (fout6-smtp.messagingengine.com [103.168.172.149]) by mails.dpdk.org (Postfix) with ESMTP id AF5AD40299 for ; Mon, 9 Sep 2024 14:24:37 +0200 (CEST) Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id 3B25A138026F; Mon, 9 Sep 2024 08:24:37 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Mon, 09 Sep 2024 08:24:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1725884677; x=1725971077; bh=9D5phpNJaWFN7lSOBLhAx83cW0+vaRjn4iTK6mIlMks=; b= zuUu4WCdCjGdjE5jlDiPHRKjFcAUGmtUt9SXHekKVnzjj74tqMK7xWwGrmSz51km WhIszqPYP87fmUDbnVhGuXkEsindciBUxIKfv0ZMTF0PcEkzQrgPxm8qe1BkFqlb G3dA1LQsdpnLq1ONCsslqtEdsf8Ig9IgiY7cVNmC7vdv435yo0XvsDc44gK00tNP tOZjVgjsIHsuRAHiKp+PQGDMW265f0UvbAYHaHm0+K/nJJqLzJW8XHdfv/9Y6xgN PQ7UIDovbsxd6yIBNtGoKIcH5Ltsgr7Yaj/hgZJrCt36LBmFLHyyKUz6jin8L0kf lqv/zck6w/mfKb9+ymjFdA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725884677; x= 1725971077; bh=9D5phpNJaWFN7lSOBLhAx83cW0+vaRjn4iTK6mIlMks=; b=d j7EmU2YdI0qfguSKEccgr0sxTBqU2ILCFjtsduQ/s9gulZp9eG8ELzbPnSqKGJsA vvy52YqVEZ8vpbBvhm9wyhtgmDYW2CwZzv3h8RfdgmTEmpHCTGh6LQLTwGMJUBYU wDCABbEa5MduHdeY+cHGMg3Zh+1wPoTT1x4bR9P5x+eWKdBPPyo7PPutLWBN9nW3 lc9pkzjHWAPtRLr3HSlhDzZXno2aSgIfHmT8OXfHlpmLKFPnWXOv1uNRZg2Dk9Rb Hw1kDOeqsbMvAs0ERvAehQTcOcPRUQsnmkqLITWHF3rUaysUCiIC36XioTKGhj2p lhCSkxP8n8JHmthUrISYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeijedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedt heevtdekiedvueeuvdeiuddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeelpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehhohhfoh hrsheslhihshgrthhorhdrlhhiuhdrshgvpdhrtghpthhtohepuggrvhhiugdrmhgrrhgt hhgrnhgusehrvgguhhgrthdrtghomhdprhgtphhtthhopehrohhrvghtiihlrgeslhhinh hugidrmhhitghrohhsohhfthdrtghomhdprhgtphhtthhopehmrghtthhirghsrdhrohhn nhgslhhomhesvghrihgtshhsohhnrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrd horhhgpdhrtghpthhtohephhgvnhhgrdifrghnghesvghrihgtshhsohhnrdgtohhmpdhr tghpthhtohepshhtvghphhgvnhesnhgvthifohhrkhhplhhumhgsvghrrdhorhhgpdhrtg hpthhtohepmhgssehsmhgrrhhtshhhrghrvghshihsthgvmhhsrdgtohhmpdhrtghpthht ohepjhgrtghkrdgsohhnugdqphhrvghsthhonhesfhhoshhsrdgrrhhmrdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 Sep 2024 08:24:35 -0400 (EDT) From: Thomas Monjalon To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: David Marchand , Tyler Retzlaff , Mattias =?UTF-8?B?UsO2bm5ibG9t?= , dev@dpdk.org, Heng Wang , Stephen Hemminger , Morten =?UTF-8?B?QnLDuHJ1cA==?= , Jack Bond-Preston Subject: Re: [PATCH v3 0/5] Improve EAL bit operations API Date: Mon, 09 Sep 2024 14:24:33 +0200 Message-ID: <2206883.Icojqenx9y@thomas> In-Reply-To: <6f228b70-8b85-4a91-965d-2b99658c668e@lysator.liu.se> References: <20240809095829.589396-2-mattias.ronnblom@ericsson.com> <6f228b70-8b85-4a91-965d-2b99658c668e@lysator.liu.se> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/09/2024 14:04, Mattias R=C3=B6nnblom: > What one should do is to have extern "C" linkage only on functions which= =20 > the include file in question (e.g., rte_foo.h) itself declares. >=20 > -- > /* rte_bar.h */ > #include >=20 > #ifdef __cplusplus > extern "C" { > #endif >=20 > void > rte_foo_do(void); >=20 > /../ > -- >=20 > There are 259 header files in the DPDK repo in need of fixing. >=20 > Should the fix be 259 patches, or something smaller? One large patch, or= =20 > a patch per library, or something else. Please advise, over. Moving includes in the whole tree can be done in a single patch, there is nothing specific per library in such a mechanical move.