From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 969B21B6D5 for ; Fri, 13 Oct 2017 15:40:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 227C4208B2; Fri, 13 Oct 2017 09:40:04 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 13 Oct 2017 09:40:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=aeDov4HJgBYEbSSKE5Jj9iYxrG 0MYLORFG1iqeMEtsc=; b=fB+ZzYmi5LFFjTqkLtMO/RtXtg5kQ3UoGrLPSip3L/ yLI6EKW+v+XjCTzdM34587P7JQUoHfFYZ/9fdNtJuNkDuAZuzi06yKmpKw9HfaN7 2Q971SOdkkrydKGwA/bkZjTaK0gonvI296ejQMrtRepTIu/pojCorVkbF0WfDYHM 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=aeDov4 HJgBYEbSSKE5Jj9iYxrG0MYLORFG1iqeMEtsc=; b=eQNfVbY0mpx46mEK1xbsPE 0MP5JOi4TFZpeWwFf2LjlMTVUac+IAUgmBFvDMlg6TyGLY5K/aeBfhyxOlVgsRIq rwuxTrlzHlrG9eaAomaVnUFua0qEp49sWjhU/S9YZJb6vRxYHkwjpvrpHy431VJr SEOeyDUtBPl6OJar+w3VskTa/lsNUjv27DoTqRA8aHgDNPY91gtQvaeMRRuNcnM/ h0Q7ysTKiYkBXDpBdF6JU330d4liZdhZ6G3iuyBWP3INXJiL0pyUAji8zVsHcHFu nByEf/yRYhV5mhF2iI0YHo/Q4pykwazkDfkfOptFtugBqzMxgUBhQZBbbgzZxVFw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 96FBA7E3DF; Fri, 13 Oct 2017 09:40:03 -0400 (EDT) From: Thomas Monjalon To: Santosh Shukla Cc: dev@dpdk.org, Maxime Coquelin , jerin.jacob@caviumnetworks.com Date: Fri, 13 Oct 2017 15:40:02 +0200 Message-ID: <2207048.supWhzNK8P@xps> In-Reply-To: <5bc3a00c-2027-7b83-db34-719bdae051be@redhat.com> References: <20171013115501.1345-1-santosh.shukla@caviumnetworks.com> <5bc3a00c-2027-7b83-db34-719bdae051be@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: call plugin init before device parse X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 13:40:04 -0000 13/10/2017 14:35, Maxime Coquelin: > > On 10/13/2017 01:55 PM, Santosh Shukla wrote: > > Default eal_init code calls > > 0. eal_plugins_init > > 1. eal_option_device_parse > > 2. rte_bus_scan > > > > IOVA commit:cf408c224 missed on calling eal_plugins_init before > > eal_option_device_parse, rte_bus_scan and that introduced below > > regression for shared mode: > > > > with CONFIG_RTE_BUILD_SHARED_LIB=y: > > > > 'net_vhost0,iface=/tmp/vhost-user2' -d ./install/lib/librte_pmd_vhost.so > > -- --portmask=1 --disable-hw-vlan -i --rxq=1 --txq=1 --nb-cores=1 > > --eth-peer=0,52:54:00:11:22:12 > > EAL: Detected 4 lcore(s) > > ERROR: failed to parse device "net_vhost0" > > EAL: Unable to parse device 'net_vhost0,iface=/tmp/vhost-user2' > > PANIC in main(): > > Cannot init EAL > > > > Fixes: cf408c224 ("eal: auto detect IOVA mode") > > > > Reported-by: Maxime Coquelin > > Signed-off-by: Santosh Shukla > > --- > > lib/librte_eal/bsdapp/eal/eal.c | 10 +++++++--- > > lib/librte_eal/linuxapp/eal/eal.c | 10 +++++++--- > > 2 files changed, 14 insertions(+), 6 deletions(-) > > Tested-by: Maxime Coquelin Applied, thanks