From: Thomas Monjalon <thomas@monjalon.net>
To: Wenjing Qiao <wenjing.qiao@intel.com>, qi.z.zhang@intel.com
Cc: jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org,
david.marchand@redhat.com
Subject: Re: [PATCH] net/cpfl: refactor flow parser
Date: Sun, 12 Nov 2023 18:39:18 +0100 [thread overview]
Message-ID: <22077230.EfDdHjke4D@thomas> (raw)
In-Reply-To: <20231107083456.1259255-1-wenjing.qiao@intel.com>
07/11/2023 09:34, wenjing.qiao@intel.com:
> From: Wenjing Qiao <wenjing.qiao@intel.com>
>
> Use strncpy instead of memcpy for string copy and rename macro.
I really wonder why memcpy was used for string copy.
As you fix it, why not using strlcpy, as recommended by checkpatch?
Qi, why do you keep ignoring warnings reported in patchwork?
next prev parent reply other threads:[~2023-11-12 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 8:34 wenjing.qiao
2023-11-08 9:16 ` Zhang, Qi Z
2023-11-12 17:39 ` Thomas Monjalon [this message]
2023-11-13 3:58 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22077230.EfDdHjke4D@thomas \
--to=thomas@monjalon.net \
--cc=beilei.xing@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wenjing.qiao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).