From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A06E943310; Sun, 12 Nov 2023 18:39:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03ADD4025C; Sun, 12 Nov 2023 18:39:28 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id E7E464021E for ; Sun, 12 Nov 2023 18:39:26 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id B12173200488; Sun, 12 Nov 2023 12:39:22 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 12 Nov 2023 12:39:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699810762; x=1699897162; bh=MTHr65AsctAD0mLay/ScY+kk/6FwYjZQOuH eZjUEQF8=; b=dJolvXshJrIq/UWeRbvQCuxz12vY1ND1ICVY0u6DyqHJ7E4i5cM 8ntwwRyeLVGaVdl4RMd/1oS/lWREW+rEx71kY/PbQbZI9m5ejcTc2tdbu4cN6U+4 ZHf1KLL2+ZLj6sP/k/z/wS/wDxy76+CVFhDrKalQUf/UIeeE5AZpcADFWxCu5fV+ A0rm7JaIWO93cGiAfO30WWIl55K67Hlb6084+mhBT1+IlLOhpZHyAtsDjYjnZOoe KePMtLAXmh7LVSO5JKuo9MVqU4Gm4WYCHUZOZDQF5nma7eKUqWxgITfwIkGgfpOt UeM0vwfyP/DoVWSsF0GkkhX3W9TZ88Oosbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699810762; x=1699897162; bh=MTHr65AsctAD0mLay/ScY+kk/6FwYjZQOuH eZjUEQF8=; b=eiFLrjcuwjru6x2TZt5Xb+tilHBTQpyE8yhLdMamXG6cXU42feG TiWhvpqiSGGc0+ULgtvEM1QroLvrYSIpejiWYhXmhlrONBSF6Gw3k9nE/auc5eBW 8Nw7cIcsQRiO1mKcwrxS47HWiZsoCltCSe9hDKNcES/wN3IHyoeTylhEhD21/zfZ Eui3/YBGvDgwWQLCJFzmx3HcV9XDa0ADyCYhubkTEZGsNaikimL2LI9USMCJxv8r AlWo/oIFFvdWeEhMXjthOi4Zc134NE/OWPrJWhs9IoBLro06u5YEKXp+e5TJTpVf RaoqtHjM8bG5mcUr3FRKjf4zUtuGjawHDOQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvkedguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Nov 2023 12:39:20 -0500 (EST) From: Thomas Monjalon To: Wenjing Qiao , qi.z.zhang@intel.com Cc: jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH] net/cpfl: refactor flow parser Date: Sun, 12 Nov 2023 18:39:18 +0100 Message-ID: <22077230.EfDdHjke4D@thomas> In-Reply-To: <20231107083456.1259255-1-wenjing.qiao@intel.com> References: <20231107083456.1259255-1-wenjing.qiao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/11/2023 09:34, wenjing.qiao@intel.com: > From: Wenjing Qiao > > Use strncpy instead of memcpy for string copy and rename macro. I really wonder why memcpy was used for string copy. As you fix it, why not using strlcpy, as recommended by checkpatch? Qi, why do you keep ignoring warnings reported in patchwork?