From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 097825B2E for ; Thu, 2 May 2019 22:27:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 987DB25A55; Thu, 2 May 2019 16:27:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 02 May 2019 16:27:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=MwSwQl181u7AFE8DPQ+3Yb/aEHNNW9ZrUmh8cMtpfcY=; b=LVsg5b4MV5rf PzrAzx1X5pqjxFSTYFwgVNNznJl+hnq8PW2ztRVFBWisWRCrYvAYsZ26VrlK89YK pAWfBUXeto7b6dnOnXpo/I4MiStKcY/NeKsvwH2KBRHpKHeW0vDd1jfEuAYtQvqb rBwWUTxtB4qX7TxivkIcG5xW+ipHhco= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=MwSwQl181u7AFE8DPQ+3Yb/aEHNNW9ZrUmh8cMtpf cY=; b=itZ6xN+8+UwS3HjwwJVSt5wEqGQe1+O+WJIWyx3NdJzAwJmW4n96q8WUE PEr+Y2u2EPwNao2ZNbk/XF3oWbJNo3vKbJ9dvAkYlslzYl025Bl82LMrr/FPKoff Gwz6kZ1hVefdcFaBLvETPAkkDdglTSCHMV8KyFjX4S7qtw2S71UuveQ9hoBtokML KJ10Fy0DxOPrgvLZy56eZ5UNlggPC1Wz0N+tYUXrdGGYk4Tr5f3bL56lHQl8kbdR yhjg8yLFgd8DoVE2Hbs39CYosCtVXGZ85+u/n/yQSiFyaLTTC2t7UglHN9qWVHYF hI/811Rq/mAHlul9sc1yKNtuJD6Vg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieelgdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ECFA0E424F; Thu, 2 May 2019 16:27:45 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Andrew Rybchenko , WenjieX A Li Date: Thu, 02 May 2019 22:27:42 +0200 Message-ID: <2207858.tCSXyMIbcb@xps> In-Reply-To: References: <20190424220309.84270-1-ferruh.yigit@intel.com> <7401294.VrTtjXMbYf@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2019 20:27:48 -0000 02/05/2019 20:31, Ferruh Yigit: > On 4/29/2019 10:52 AM, Thomas Monjalon wrote: > > 25/04/2019 17:27, Ferruh Yigit: > >> On 4/25/2019 2:29 PM, Thomas Monjalon wrote: > >>> 25/04/2019 13:47, Ferruh Yigit: > >>>> On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > >>>>> 25/04/2019 00:03, Ferruh Yigit: > >>>>>> This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > >>>>>> > >>>>>> Not all PMDs support the fixed link speed set, and link speed can be set > >>>>>> even with auto negotiation enabled. Reverting the patch to not break > >>>>>> existing usage. > >>>>> > >>>>> Which PMDs do not support this flag? > >>>>> Why not fixing the PMDs? > >>>>> > >>>> > >>>> At least ixgbe and i40e is not supporting setting a fixed speed. > >>>> But I am not sure if this is something to fix, the command in testpmd is to set > >>>> the link speed, what is the problem with setting the link speed without > >>>> disabling the auto-negotiation? > >>> > >>> It means it will negotiate with only one speed proposed. > >> > >> Yes. > >> > >>> The real issue is to not support the fixed flag. > >> > >> I don't know if this is a real issue but > >> even it is, is it an issue in the scope of this testpmd command? > >> > >> right now we are first updating the command to set fixed speed flag, and > >> requesting PMDs to fix for it, I am suggesting not to update the command at all. > > > > I understand. But this change shows a broken behaviour. > > This is the intent of testpmd to show what works or not in PMDs. > > How hard is it to fix the PMDs in your opinion? > > > > As far as I can see the the fixed link speed set is not supported in the PMD. > > It may be easy to add perhaps, I don't know, but is it really a "broken > behavior" to not have this support? > What defines that setting speed has to be "fixed speed", if this demand is not > there, should testpmd enforce it? I think a PMD should support both: fixed or not. > In mail thread we have talked that this testpmd command can get an extra > argument to define the speed fixed or not, this can be used to test fixed speed > by who wants to test/use fixed speed. > > I am for reverting this for the release, and adding a new version next release > with fixed speed argument, otherwise testpmd won't be used to set the speed for > some PMDs. OK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 63855A0AC5 for ; Thu, 2 May 2019 22:27:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E88CA5F1F; Thu, 2 May 2019 22:27:48 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 097825B2E for ; Thu, 2 May 2019 22:27:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 987DB25A55; Thu, 2 May 2019 16:27:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 02 May 2019 16:27:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=MwSwQl181u7AFE8DPQ+3Yb/aEHNNW9ZrUmh8cMtpfcY=; b=LVsg5b4MV5rf PzrAzx1X5pqjxFSTYFwgVNNznJl+hnq8PW2ztRVFBWisWRCrYvAYsZ26VrlK89YK pAWfBUXeto7b6dnOnXpo/I4MiStKcY/NeKsvwH2KBRHpKHeW0vDd1jfEuAYtQvqb rBwWUTxtB4qX7TxivkIcG5xW+ipHhco= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=MwSwQl181u7AFE8DPQ+3Yb/aEHNNW9ZrUmh8cMtpf cY=; b=itZ6xN+8+UwS3HjwwJVSt5wEqGQe1+O+WJIWyx3NdJzAwJmW4n96q8WUE PEr+Y2u2EPwNao2ZNbk/XF3oWbJNo3vKbJ9dvAkYlslzYl025Bl82LMrr/FPKoff Gwz6kZ1hVefdcFaBLvETPAkkDdglTSCHMV8KyFjX4S7qtw2S71UuveQ9hoBtokML KJ10Fy0DxOPrgvLZy56eZ5UNlggPC1Wz0N+tYUXrdGGYk4Tr5f3bL56lHQl8kbdR yhjg8yLFgd8DoVE2Hbs39CYosCtVXGZ85+u/n/yQSiFyaLTTC2t7UglHN9qWVHYF hI/811Rq/mAHlul9sc1yKNtuJD6Vg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieelgdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ECFA0E424F; Thu, 2 May 2019 16:27:45 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Andrew Rybchenko , WenjieX A Li Date: Thu, 02 May 2019 22:27:42 +0200 Message-ID: <2207858.tCSXyMIbcb@xps> In-Reply-To: References: <20190424220309.84270-1-ferruh.yigit@intel.com> <7401294.VrTtjXMbYf@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502202742.cmKtPPYZkllsKkRln-ScrwEqGzl6OukcM-7O6E54pNg@z> 02/05/2019 20:31, Ferruh Yigit: > On 4/29/2019 10:52 AM, Thomas Monjalon wrote: > > 25/04/2019 17:27, Ferruh Yigit: > >> On 4/25/2019 2:29 PM, Thomas Monjalon wrote: > >>> 25/04/2019 13:47, Ferruh Yigit: > >>>> On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > >>>>> 25/04/2019 00:03, Ferruh Yigit: > >>>>>> This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > >>>>>> > >>>>>> Not all PMDs support the fixed link speed set, and link speed can be set > >>>>>> even with auto negotiation enabled. Reverting the patch to not break > >>>>>> existing usage. > >>>>> > >>>>> Which PMDs do not support this flag? > >>>>> Why not fixing the PMDs? > >>>>> > >>>> > >>>> At least ixgbe and i40e is not supporting setting a fixed speed. > >>>> But I am not sure if this is something to fix, the command in testpmd is to set > >>>> the link speed, what is the problem with setting the link speed without > >>>> disabling the auto-negotiation? > >>> > >>> It means it will negotiate with only one speed proposed. > >> > >> Yes. > >> > >>> The real issue is to not support the fixed flag. > >> > >> I don't know if this is a real issue but > >> even it is, is it an issue in the scope of this testpmd command? > >> > >> right now we are first updating the command to set fixed speed flag, and > >> requesting PMDs to fix for it, I am suggesting not to update the command at all. > > > > I understand. But this change shows a broken behaviour. > > This is the intent of testpmd to show what works or not in PMDs. > > How hard is it to fix the PMDs in your opinion? > > > > As far as I can see the the fixed link speed set is not supported in the PMD. > > It may be easy to add perhaps, I don't know, but is it really a "broken > behavior" to not have this support? > What defines that setting speed has to be "fixed speed", if this demand is not > there, should testpmd enforce it? I think a PMD should support both: fixed or not. > In mail thread we have talked that this testpmd command can get an extra > argument to define the speed fixed or not, this can be used to test fixed speed > by who wants to test/use fixed speed. > > I am for reverting this for the release, and adding a new version next release > with fixed speed argument, otherwise testpmd won't be used to set the speed for > some PMDs. OK