From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CCE4A0597; Tue, 21 Apr 2020 13:46:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E11CB1D409; Tue, 21 Apr 2020 13:46:47 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id C80491D17A for ; Tue, 21 Apr 2020 13:46:46 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 634C55C01DC; Tue, 21 Apr 2020 07:46:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 21 Apr 2020 07:46:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= RmJYiFrvBKx8oA8wLAe1hz42r9rhg9LuRv4WATw5IlU=; b=qi7HS26PWuJE1yEP ghPouv+doITJFKtrWaJqrcM8vEoaLW5IR65hKS+ZrKPtQRm5mcsmYgWhHsV4Bdn6 p8Pt0AxcmPDPM3ovfo114VYoyWbbkVIs57rW5pmOPYvd93zEnD8CDZpFSdTZH3/y q21QQziP9T9yu+DHVIGqQMNJsj6ly09xKEKzl8TUmvsrqOGBr5rH7RcqqXy6WrBn q2s4FRZDqrfsZWIdmUZFAf0Ty9vFy9quLjiTjCHvjYevCgRjPmZUmAwZDm6MR2T4 4bsYvgs3/U024L29UqvPg5kNr/nV6zIShyvqIzYHVdKWPLqbz4zuBvi3b0PAi2i8 mGfboQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=RmJYiFrvBKx8oA8wLAe1hz42r9rhg9LuRv4WATw5I lU=; b=nvlXdMJ7MswdAGz2CtaX6sS3QWkdBL9vW7OGMCoVZmVdaN+nTWl6LPJhv e4VxlSEHJ/gasIibSili2pMgfc+cI7+cUq6tQYW5iTYzcCNdnfdTXALhvbcjtK1P QFerTu0ZZ6P1MiQ3IgnNQZUG73zQM4SYII2PVD/cYbsJ+PM9ozKkz7sWylFmgZ2T X7Z78wVzAnhotPUUH92UG4TJEKiV/7Ju86PzAJih8SQR7hkqv6jmy6pFYw3fNBtK 5YHt+NfEUImLWLsefzZz4D1lYyzOVphgJZsIo8dgGD71oXEqAB0TtiTmbZnNQH/h MpLuj6RgfcGW0b9roW9wkNkn50lzg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeehgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepudenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6A27C3065C5C; Tue, 21 Apr 2020 07:46:44 -0400 (EDT) From: Thomas Monjalon To: Ray Kinsella , Neil Horman Cc: dev@dpdk.org, david.marchand@redhat.com Date: Tue, 21 Apr 2020 13:46:43 +0200 Message-ID: <2208997.NG923GbCHz@thomas> In-Reply-To: <20200421111230.GA763162@hmswarspite.think-freely.org> References: <20200416145414.262296-1-nhorman@tuxdriver.com> <20200421111230.GA763162@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv3] Remove validate-abi.sh from tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/04/2020 13:12, Neil Horman: > On Fri, Apr 17, 2020 at 04:42:38PM +0100, Ray Kinsella wrote: > > On 17/04/2020 13:10, Thomas Monjalon wrote: > > > 17/04/2020 13:47, Ray Kinsella: > > >> On 17/04/2020 11:20, Thomas Monjalon wrote: > > >>> 17/04/2020 12:11, Ray Kinsella: > > >>>> check-abi.sh appears to be backward step in terms of usability. > > >>> > > >>> No, check-abi.sh benefits from a nice integration in build scripts. > > >>> See below. > > >>> > > >>>> With validate-abi.sh I do can do a "validate-abi.sh HEAD~1 HEAD". > > >>>> And it will do the build, install, dump and comparison for me. > > >>>> And it picked up my 20.0.2 - > 21.0 changes no problem. > > >>>> > > >>>> With check-abi on the other hand, I need to the build and install myself. > > >>>> check-abi requires dump files, but I see no reference in the documentation to how these are created. > > >>>> It silently fails when it doesn't find any ... > > >>>> > > >>>> Do I run abi-dumper on the so's myself, or how does it work? > > >>> > > >>> check-abi.sh is integrated in test-build.sh and test-meson-builds.sh. > > >>> Probably we should document usage in these scripts. > > >> > > >> Looks like I need to set DPDK_ABI_REF_VERSION=master, not obvious. > > >> Any tips or tricks would be welcome. > > > > > > export DPDK_ABI_REF_VERSION=v20.02 > > > or > > > export DPDK_ABI_REF_VERSION=v19.11 > > > > > > Depends on which compatibility you want to test... > > > > > > > Few things ... > > > > 1. test-meson-build.sh keep barfing complaining about reference paths. > > ValueError: dst_dir must be absolute, got reference/v19.11/build-gcc-static/usr/local/share/dpdk/examples/bbdev_app > > > > Under the hood, ninja install is failing complaining that it needs an absolute path. > > I fixed this in test_meson_build.sh and will send a patch in a minute. > > Though it's strange no-one else has seen it? > > > > 2. test-meson-build.sh compares the abi for the static builds, which doesn't make any sense. > > > > 3. test-meson-build.sh will only take a branch in DPDK_ABI_REF_VERSION that exists locally. > > In order to get it to compare HEAD against HEAD~1, which you would imagine is a pretty common case. > > I had a create a branch for HEAD~1, in validate-abi this a pretty simple `validate-abi HEAD~1 HEAD` > > > I think this code in test-meson-build.sh should probably be fixed: > > if [ ! -d $abirefdir/src ]; then > git clone --local --no-hardlinks \ > --single-branch \ > -b $DPDK_ABI_REF_VERSION \ > $srcdir $abirefdir/src > fi > > Like you noted, using -b allows us to checkout a tag/branch in the cloned > repository but requires that it exist locally. We should probably prefix the > checkout with a git fetch --tags I don't understand your concern. A reference is an older version, so it should be in the git tree.