From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 848D7F72 for ; Thu, 4 Feb 2016 09:44:49 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id r129so200584555wmr.0 for ; Thu, 04 Feb 2016 00:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=LfDNNTIQ+yb7jEDaqUBkdMBEvnQFQfMxUxWXvKUfzL0=; b=RwdkgQdEsGdezLOledqSpLYZk6BjT4MqzRaavPURzgmeIrLDZwwvir9H9rvm8nIR84 kZ+uizOx/whI1bHqWmMpUX4tsQnDzlyyuSXVV9WapsXSPW4It5Af8PNxS+Hr2DfC+lAZ Kvae4OFsXK3gWrmBRiU71gm8Bp7geg8rSMmDzSZjimX681l4kDkkc6jqAM3Gn+xIGTsW LNf/QyuEM/fbLuN69Sesx1Joe/ADn84CD8ueLAha6kZOCHaRSVWzPfd5L/ha739+/w1H 8TuvGslykm/7z7a+QGA8aszrgrTeB/kO3h0gQ304a7JfYobjYthWMTg463nKcYB5ciwJ YORg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=LfDNNTIQ+yb7jEDaqUBkdMBEvnQFQfMxUxWXvKUfzL0=; b=Uojbum5g0n4SnVg8Fwpm0wUEiMoOxRVj4TCjfoOyzb8k7/Ko1ZXO7c9W2zcpZUY7Pr 8OI51waCB6EmzTSCep7L+eSjXekssldfAKyNsm1MjNniKwlNJLOT2ZC1sg0vF19QrgDn U1bUOL2Inpjl90sWADfT224Ixb/JoosIk6Ad576ytZxDQ18nFZC4VkEEkKtICz0teyg9 BaP81VqP7BQAHYsupK0c6/xfkSCDzsiDa1dSh2TlWusxGgEQsYhVVG/D/C3Dw48lxDUO u6qWTyhTqYmGZns1sMasdCARRx4ZtTQUV/HtiO9d2r9roJ7DvpS9DSEowRnrTAq7YdKX 6ARA== X-Gm-Message-State: AG10YOQKZCGNYhNVuh9RFNn1Y1SxbXigE62m6vFfaQYOj9ednz3viE+t3QJEbjYGkrtBAi4k X-Received: by 10.194.133.10 with SMTP id oy10mr6476272wjb.93.1454575489401; Thu, 04 Feb 2016 00:44:49 -0800 (PST) Received: from xps13.localnet (136.21.90.92.rev.sfr.net. [92.90.21.136]) by smtp.gmail.com with ESMTPSA id v78sm3370812wmv.23.2016.02.04.00.44.48 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 04 Feb 2016 00:44:48 -0800 (PST) From: Thomas Monjalon To: "Zhang, Helin" Date: Thu, 04 Feb 2016 09:43:35 +0100 Message-ID: <2209475.O8bk1od0vQ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1450848779-8183-1-git-send-email-helin.zhang@intel.com> <20160203163112.GA2528@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue of port initialization failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 08:44:49 -0000 2016-02-04 00:50, Zhang, Helin: > From: Richardson, Bruce > > can you please add an appropriately "fixes" line to the patch, since the subject > > explicitly calls it out as a bug-fix. Also, the words "the issue" in the subject can > > be removed as they don't add value. It would also be worthwhile referencing > > the adminq in the subject too, since that is the failure being reported. How > > about: > > > > "i40e: fix adminq failure on port init" > > Oh, sorry, I forgot this patch. > Firmware finally fixed it in FVL5, and we need to use new AQ commands for reading/writing some registers. > So I will drop this patch. Thanks! In such case, please mark it as "Rejected" in patchwork and self reply on the mailing list to advertise it is dropped. Thanks