From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40FD84596E; Thu, 12 Sep 2024 15:54:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1BDE427B7; Thu, 12 Sep 2024 15:54:33 +0200 (CEST) Received: from fout4-smtp.messagingengine.com (fout4-smtp.messagingengine.com [103.168.172.147]) by mails.dpdk.org (Postfix) with ESMTP id 87D9E42709 for ; Thu, 12 Sep 2024 15:54:32 +0200 (CEST) Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.phl.internal (Postfix) with ESMTP id 126DF1380524; Thu, 12 Sep 2024 09:54:32 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Thu, 12 Sep 2024 09:54:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1726149272; x=1726235672; bh=sKsONF6A+wmVhRwN4t48EDP1OHkHg+5qs9St5QNmCjk=; b= CqNbm2V5FZSoZY0o/HrrijY97LwAr8sBOimO5rcv4Z3MH7xHHt20xxvEM64wvdjH eUq+2y+HBTq3QdHifVdvgAwqvPUc4nNYXyMNPTRyjC4cVb6qmxB6ZFJW6fHukBWs 3K/GPfbdP+fy8pI3WpGaMkncjvsZJr05AL8VrbuAPD75sxKPKmdlJd4KOM29lGxY HjERlnrB9a2zCvM4JfJxIMV6zA0j3Cv+lQjcxKz4qBKdQTQK4ORMD6eYp7fb/aHN vgkwQ36ZOKovh2zoD4be7LCIptIIiHRmAsRtkPPS0SD1CJkW1q5ppjuYh8SNx71r +OAsH60NJELspSVie1RUHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726149272; x= 1726235672; bh=sKsONF6A+wmVhRwN4t48EDP1OHkHg+5qs9St5QNmCjk=; b=M jqJwAUFn1cmuVWmpkt3sUNh+FuW9/oX9oZcpdILx/SbIYxk7CTUICzQTodecDjQZ cVwWqOdDRAwHvwvrr0RAKeZS3932pdCM7C/LtYWfeHHSQxSieN37evSXemr9664G aacsEse74hY04a75S+ErHkUoqg46ImaVGMjF+j5KRFG5z5fM8ezSoJccrHVLmkhv uAAMtr5vPSBfvyRkZ2DsoQRZv+52lV2JvFBgG6gzLBg0HvEnvjxnwBHHbRxbB29G zCpJYwaXHlqDpLDmdXhU1f5xg+ScUOcDkbpMznl4r+xdUXXh9HumY0wqKo+dGdK9 PPXNPo7TURIZp1fM/oOhA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejfedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegurghvih gurdhmrghrtghhrghnugesrhgvughhrghtrdgtohhmpdhrtghpthhtohepuggvvhesughp ughkrdhorhhgpdhrtghpthhtoheprghmohesshgvmhhihhgrlhhfrdgtohhmpdhrtghpth htoheprghrnhhonhesqhifihhlthdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Sep 2024 09:54:30 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Andrzej Ostruszka , Arnon Warshavsky Subject: Re: [PATCH v2 01/14] devtools: fix forbidden token check with multiple files Date: Thu, 12 Sep 2024 15:54:29 +0200 Message-ID: <2210427.Icojqenx9y@thomas> In-Reply-To: <20240912082643.1532679-2-david.marchand@redhat.com> References: <20240907145433.1479091-1-david.marchand@redhat.com> <20240912082643.1532679-1-david.marchand@redhat.com> <20240912082643.1532679-2-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/09/2024 10:26, David Marchand: > --- a/devtools/check-forbidden-tokens.awk > +++ b/devtools/check-forbidden-tokens.awk > @@ -32,14 +32,11 @@ BEGIN { > for (i in deny_expr) { > forbidden_added = "^\\+.*" deny_expr[i]; > forbidden_removed="^-.*" deny_expr[i]; > - current = expressions[deny_expr[i]] > if ($0 ~ forbidden_added) { > - count = count + 1; > - expressions[deny_expr[i]] = current + 1 > + count = count + 1 > } > if ($0 ~ forbidden_removed) { > - count = count - 1; > - expressions[deny_expr[i]] = current - 1 > + count = count - 1 > } > } > } > @@ -55,6 +52,7 @@ BEGIN { While at it, you could insert a missing space in "previous filehad new additions" few lines above. > if (count > 0) { > exit; > } > + count = 0 I'm not an awk expert, but it looks simple enough. Thank you Acked-by: Thomas Monjalon