From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2251F559C for ; Wed, 19 Apr 2017 14:26:49 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A2A0A20E52; Wed, 19 Apr 2017 08:26:48 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 19 Apr 2017 08:26:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=xbaU6OX9GgHUgfo G/pQfu06r0X/2sej2R63yHuERPgw=; b=bOvy5mUgc+g1Xn3/+/qh2soahppMZrY myleQV6B3BQ9Yn8hOGJmEWD0nyp9L/A8pb9nwF7Y3YHrjnZkEYe5LkMeEXirlheH dWJFbYnLbFRWBWvKocwkXeWNPwlBW/nW5Kt4XJUTSy/7chYXa4PY+apjrZQwqG9W D6IEDo6Q5V3Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=xbaU6OX9GgHUgfoG/pQfu06r0X/2sej2R63yHuERPgw=; b=OMkhgtq1 Vs3ia7KfWEz2HkxY3vtTB4ifsSEXm8+949eXTsD7PgnnNu8mQwjFtjWwqOX/4sUb 6NiJQ3v27xJbeP9ShvXbTGS4eM8ZqKQboZnxMcih06di9i4LuhRjhZhVezHbVWFG MuiKqZYnIECPZ7F/3OhcYdUvjRYILKeQTitgf4us5uan5etnguTL/jt8cEBHqx2S USC/BpLudCBj0WEuBgSEQYYNK0MefIgpUDpelyAs9DBAKPuWvkUAD9KHvJNjROhx AZQnGt76GesXPLlWli8S60igfNFXh8BerjPRuqh3DHnH04TPEtqXe2wfPYLqD9jX ADlpYsmhrBz1zQ== X-ME-Sender: X-Sasl-enc: FL1+4Az3qjfU5QtV9VYOmFE+1CsXhK1Az2kfkRtDhNLq 1492604808 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 526DE24373; Wed, 19 Apr 2017 08:26:48 -0400 (EDT) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org, Olivier MATZ , "bruce.richardson@intel.com" , "john.miller@atomicrules.com" Date: Wed, 19 Apr 2017 14:26:47 +0200 Message-ID: <2210656.H7V8bvkmcr@xps> In-Reply-To: References: <1492074127-24339-1-git-send-email-shreyansh.jain@nxp.com> <20170418140408.69df3672@glumotte.dev.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: link ring mempool by default for app build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2017 12:26:49 -0000 18/04/2017 14:25, Shreyansh Jain: > Hi Olivier, > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > > On Thu, 13 Apr 2017 14:32:07 +0530, Shreyansh Jain > > wrote: > > > Signed-off-by: Shreyansh Jain > > > > Fixes: 9a8e9b57f544 ("mempool: move ring handler as a driver") > > > > Acked-by: Olivier Matz > > > > > --- > > > > > > Context: > > > From the discussion in [1], it was observed that application should > > > have a default pool already linked even in case of shared builds. > > > Ring is especially important because packet mbuf creation API refer to > > > ring_mp_mc as default handler. > > > > > > Documentation for this is pending. > > > > > > [1] http://dpdk.org/ml/archives/dev/2017-April/063819.html > > > > Maybe this comment could go in the patch. > > I can send another version of the patch with some part of the above > documentation within the patch commit. Moved the mempool ring line below the mempool line, Added the explanations, and Applied, thanks