From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id A0EC84C8C for ; Sat, 24 Mar 2018 02:02:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E48C620D96; Fri, 23 Mar 2018 21:02:40 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 23 Mar 2018 21:02:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=gfVHkDtbCFbJPbyIuhslgSaQs/ uf2SnSt1vnKKUE33o=; b=CLMlvgFkN9d3cgbm+6FMVUsuK+9ngakWk8kxB9Unxn Bgm7j+OWeNXuDlpoaOETKoHKv30CP7vWaH9qSFdt5s+hCxXAx65HIivX6Ki516wz pVZUWGoxIMwudPB5qZvXFSDhVQ0PKow6u71HrbUydIcQDUmpCGXh2aHN9ppvAnNI Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=gfVHkD tbCFbJPbyIuhslgSaQs/uf2SnSt1vnKKUE33o=; b=Jdm4jfCBoHwXDs3Ooh5NI6 gBwbHKexuSalW8DyMtQLDkzam/6u/HNY8K0o9BsyNCl1Vf+5IToh4vM+01ly+sKe Ci7sYsOVp9a8BEa0jysaKE1bhCzkKfFwYcse8xetzZ12eC6rO3KXRiztFsy2mIuq Mu0kx0iTKhjce52Q0N/jNxjRFS14Qq8wONbw7Qn+D468Zv+jrQASTDuKhqKoIKzi OUMsLjG3KVnrfOsckTAKu+vrh5M8BzQDRTH9D6R5ux8dR8zgx0bnclsNoJTaSxDe n2CV44VlXk6+TxJ5PkOFKiAwzNqQSx7RSTCBjFy4ko7v/kF5kiVBeiOurkjgEP8Q == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 04EB7240CE; Fri, 23 Mar 2018 21:02:39 -0400 (EDT) From: Thomas Monjalon To: "Trahe, Fiona" Cc: "dev@dpdk.org" , "ahmed.mansour@nxp.com" , "Shally.Verma@cavium.com" , "De Lara Guarch, Pablo" , "fiona.trahe@gmail.com" Date: Sat, 24 Mar 2018 02:02:14 +0100 Message-ID: <2211509.83yEhUb72U@xps> In-Reply-To: <348A99DA5F5B7549AA880327E580B43589360349@IRSMSX101.ger.corp.intel.com> References: <1517595924-25963-1-git-send-email-fiona.trahe@intel.com> <1997769.o2qW9LT7Ur@xps> <348A99DA5F5B7549AA880327E580B43589360349@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Mar 2018 01:02:42 -0000 23/03/2018 19:08, Trahe, Fiona: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 02/02/2018 19:25, Fiona Trahe: > > > lib/librte_compressdev/rte_comp.h | 503 ++++++++++++ > > > > Why rte_comp.h instead of the more consistent rte_compress.h? > [Fiona] I did originally... but ran into difficulty with horribly names like > RTE_COMPRESS_COMPRESS > RTE_COMPRESS_DECOMPRESS > rte_compress_compress_xform > rte_compress_decompress_xform > So compress is both the module prefix and the name of one of the actions. > I could have used compressdev - but names were very long. > So decided to opt for using > _compressdev_ in names to do with the device and > _comp_ in names to do with the compression service > > Also I could have used compdev instead of compressdev, > but I felt compress should be in the lib name I understand your concerns. I don't like "comp" very much because it sounds like "comparison". However, I don't have a better idea. Sometimes naming is more difficult than coding :)