[dpdk-dev] DPDK Release Status Meeting 14/05/2020

[dpdk-dev] DPDK Release Status Meeting 14/05/2020

[Ferruh Yigit]

Minutes 14 May 2020
-------------------

Agenda:
* Release Dates
* -rc2 status
* Subtrees
* Opens

Participants:
* Arm
* Debian/Microsoft
* Intel
* Mellanox
* Red Hat


Release Dates
-------------

* v20.05 dates:
  * -rc2  is released on Tuesday, 12 May
    * https://mails.dpdk.org/archives/dev/2020-May/167394.html
  * -rc3			Friday 18 May 2020
  * -rc4			Thursday 21 May 2020
  * Release pushed to		*Monday 25 May 2020*

* v20.08 proposal dates, please comment:
  * Proposal/V1:		Tuesday, 16 June 2020
  * Integration/Merge/RC1:	Tuesday, 14 July 2020
  * Release:			Friday, 7 August 2020

  * Please send roadmap for the release


-rc2 status
-----------

* Intel sent a -rc2 test report, majority of testing completed, no critical
  issue
  * https://mails.dpdk.org/archives/dev/2020-May/167715.html


Subtrees
--------

* main
  * Looking patchsets adding __rte_internal to common folder
    * This is good to prevent false positives in ABI and document intention
  * ABI fix for matured API not merged, discussion going on in the mail list
    * OvS is using it but not critical for OvS
    * Blocking some test cases
  * There are couple of coverity fixes
  * Some documentation
    * Good time for deprecation notices
  * Thomas is looking compilation patches and Makefile deprecation
  * gcc10
    * Akhil's fix for crypto looks good, can replace temporary solution
    * Gavin has patch for mbuf, but this stage can be late/risky for complex fix
      * At this stage we can go with disabling warning as temporary solution
    * Ferruh is getting a warning on hash too, will share it
  * We should consider python2 deprecation
    * A deprecation notice already merged
      * https://patches.dpdk.org/patch/65828/

* next-net
  * Some patches merged and sub-trees pulled for -rc3
  * HW rings allocation patch is in backlog, ethdev patch is internal and can go
    in -rc3 but there a few things to clarify, not sure if it will make -rc3

* next-crypto
  * No update

* next-eventdev
  * No update

* next-virtio
  * 4 fixes in the queue, pull request can be ready today
  * Mellanox vdpa patchset postponed, it introduces new APIs
  * More reviews would help
  * Maxime will have less time next month,  will sync with Xiaolong

* next-net-intel
  * 10 fixes in backlog
  * fm10k patchset postponed to next release

* next-net-mlx
  * 10-15 fixes are expected


Opens
-----

* Bugzilla is not discussed for a while
  * After issues assigned, there is not much to do for management
  * It can be good to get list of critical issues offline

* Patchwork hit 70K patches, Hemant/Nipun is the winner :)
  * https://mails.dpdk.org/archives/dev/2020-May/167125.html



DPDK Release Status Meetings
============================

The DPDK Release Status Meeting is intended for DPDK Committers to discuss
the status of the master tree and sub-trees, and for project managers to
track progress or milestone dates.

The meeting occurs on Thursdays at 8:30 UTC. If you wish to attend just
send an email to "John McNamara <john.mcnamara@intel.com>" for the invite.

Re: [dpdk-dev] DPDK Release Status Meeting 14/05/2020

[Ferruh Yigit]

On 5/14/2020 12:13 PM, Ferruh Yigit wrote:
> Minutes 14 May 2020
> -------------------

<...>

>   * gcc10
>     * Akhil's fix for crypto looks good, can replace temporary solution
>     * Gavin has patch for mbuf, but this stage can be late/risky for complex fix
>       * At this stage we can go with disabling warning as temporary solution
>     * Ferruh is getting a warning on hash too, will share it

Hi David,

Following is what I am getting [1] with compiler version:
gcc (GCC) 10.1.1 20200511


[1]
.../dpdk/lib/librte_hash/rte_cuckoo_hash.c: In function
‘__rte_hash_add_key_with_hash’:
.../dpdk/lib/librte_hash/rte_cuckoo_hash.c:1104:29:
    error: ‘ext_bkt_id’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
 1104 |  (h->buckets_ext[ext_bkt_id - 1]).sig_current[0] = short_sig;
      |                  ~~~~~~~~~~~^~~

Re: [dpdk-dev] DPDK Release Status Meeting 14/05/2020

[David Marchand]

On Thu, May 14, 2020 at 1:18 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 5/14/2020 12:13 PM, Ferruh Yigit wrote:
> > Minutes 14 May 2020
> > -------------------
>
> <...>
>
> >   * gcc10
> >     * Akhil's fix for crypto looks good, can replace temporary solution
> >     * Gavin has patch for mbuf, but this stage can be late/risky for complex fix
> >       * At this stage we can go with disabling warning as temporary solution
> >     * Ferruh is getting a warning on hash too, will share it
>
> Hi David,
>
> Following is what I am getting [1] with compiler version:
> gcc (GCC) 10.1.1 20200511

Ah.
I just saw that my fedora (rawhide) did not have this version yet...
upgraded and I reproduce the issue.
gcc version 10.1.1 20200507 (Red Hat 10.1.1-1) (GCC)

Kevin confirmed that fc32 switched to 10.1.1 version too.


Thanks.

-- 
David Marchand

Re: [dpdk-dev] DPDK Release Status Meeting 14/05/2020

[Kevin Traynor]

On 14/05/2020 12:17, Ferruh Yigit wrote:
> On 5/14/2020 12:13 PM, Ferruh Yigit wrote:
>> Minutes 14 May 2020
>> -------------------
> 
> <...>
> 
>>   * gcc10
>>     * Akhil's fix for crypto looks good, can replace temporary solution
>>     * Gavin has patch for mbuf, but this stage can be late/risky for complex fix
>>       * At this stage we can go with disabling warning as temporary solution
>>     * Ferruh is getting a warning on hash too, will share it
> 
> Hi David,
> 
> Following is what I am getting [1] with compiler version:
> gcc (GCC) 10.1.1 20200511
> 
> 
> [1]
> .../dpdk/lib/librte_hash/rte_cuckoo_hash.c: In function
> ‘__rte_hash_add_key_with_hash’:
> .../dpdk/lib/librte_hash/rte_cuckoo_hash.c:1104:29:
>     error: ‘ext_bkt_id’ may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
>  1104 |  (h->buckets_ext[ext_bkt_id - 1]).sig_current[0] = short_sig;
>       |                  ~~~~~~~~~~~^~~
> 

The return value of rte_ring_sc_dequeue_elem() is checked, but gcc
seems to find some possibility of ext_bkt_id not being initialized.

It was introduced with commit [1], but I guess the tools wouldn't have
found it at time of commit.

zero is an invalid value for ext_bkt_id, so we can just initialize to
that and check it is overwritten. Sent patch
https://patchwork.dpdk.org/patch/70333/

[1]
commit fbfe568103b046a3c6c69c9ecd6c914b391c6b82
Author: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Date:   Sat Jan 18 13:32:46 2020 -0600

    hash: use 32-bit elements rings to save memory

Re: [dpdk-dev] DPDK Release Status Meeting 14/05/2020

[Ferruh Yigit]

On 5/14/2020 12:13 PM, Ferruh Yigit wrote:
> Minutes 14 May 2020
> -------------------
> 
> Agenda:
> * Release Dates
> * -rc2 status
> * Subtrees
> * Opens
> 
> Participants:
> * Arm
> * Debian/Microsoft
> * Intel
> * Mellanox
> * Red Hat
> 
> 
> Release Dates
> -------------
> 
> * v20.05 dates:
>   * -rc2  is released on Tuesday, 12 May
>     * https://mails.dpdk.org/archives/dev/2020-May/167394.html
>   * -rc3			Friday 18 May 2020
>   * -rc4			Thursday 21 May 2020
>   * Release pushed to		*Monday 25 May 2020*

-rc3 is on Monday not Friday, corrected version is like:

* v20.05 dates:
  * -rc2  is released on Tuesday, 12 May
    * https://mails.dpdk.org/archives/dev/2020-May/167394.html
  * -rc3			Monday 18 May 2020
  * -rc4			Thursday 21 May 2020
  * Release pushed to		*Monday 25 May 2020*

Re: [dpdk-dev] DPDK Release Status Meeting 14/05/2020

[Thomas Monjalon]

Hi,

Please let's discuss the dates for the next release cycle.

> * v20.08 proposal dates, please comment:
>   * Proposal/V1:		Tuesday, 16 June 2020
>   * Integration/Merge/RC1:	Tuesday, 14 July 2020
>   * Release:			Friday, 7 August 2020

I prefer a target at the very beginning of the month,
it is an insurance against disaster,
and it may allow a quiet August month for the maintainers.

Another issue is the delay between -rc1 and final release.
The above proposal has only 24 days -rc phase.
Based on records, we need 30 days for a proper -rc phase.

Taking above requirements into consideration,
I propose having a proposal deadline earlier by 8 days:

- Proposal deadline: Monday, 8 June 2020
- Integration deadline: Tuesday, 30 June 2020
- 20.08-rc1: Friday, 3 July 2020
- 20.08-rc2: Friday, 17 July 2020
- 20.08-rc3: Friday, 24 July 2020
- 20.08-rc4: Friday, 31 July 2020
- Release: Monday, 3 August 2020

Re: [dpdk-dev] DPDK Release Status Meeting 14/05/2020

[Ajit Khaparde]

On Fri, May 15, 2020 at 9:14 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> Hi,
>
> Please let's discuss the dates for the next release cycle.
>
> > * v20.08 proposal dates, please comment:
> >   * Proposal/V1:              Tuesday, 16 June 2020
> >   * Integration/Merge/RC1:    Tuesday, 14 July 2020
> >   * Release:                  Friday, 7 August 2020
>
> I prefer a target at the very beginning of the month,
> it is an insurance against disaster,
> and it may allow a quiet August month for the maintainers.
>
> Another issue is the delay between -rc1 and final release.
> The above proposal has only 24 days -rc phase.
> Based on records, we need 30 days for a proper -rc phase.
>
> Taking above requirements into consideration,
> I propose having a proposal deadline earlier by 8 days:
>
> - Proposal deadline: Monday, 8 June 2020
> - Integration deadline: Tuesday, 30 June 2020
> - 20.08-rc1: Friday, 3 July 2020
> - 20.08-rc2: Friday, 17 July 2020
> - 20.08-rc3: Friday, 24 July 2020
> - 20.08-rc4: Friday, 31 July 2020
> - Release: Monday, 3 August 2020
>
Personally I think the original proposal deadline and release
plan was good. But this is a valid argument to give sufficient
days for the rc phase.
Also the release of 20.08 early in August can also give
a big enough window for the 20.11 release.
So +1 for the new schedule.

Re: [dpdk-dev] DPDK Release Status Meeting 14/05/2020

[Iremonger, Bernard]

Hi Thomas,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Friday, May 15, 2020 5:14 PM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; O'Hare, Cathal <cathal.ohare@intel.com>;
> asafp@mellanox.com; jerinj@marvell.com; hemant.agrawal@oss.nxp.com;
> honnappa.nagarahalli@arm.com; david.marchand@redhat.com;
> ajit.khaparde@broadcom.com; arybchenko@solarflare.com
> Subject: Re: [dpdk-dev] DPDK Release Status Meeting 14/05/2020
> 
> Hi,
> 
> Please let's discuss the dates for the next release cycle.
> 
> > * v20.08 proposal dates, please comment:
> >   * Proposal/V1:		Tuesday, 16 June 2020
> >   * Integration/Merge/RC1:	Tuesday, 14 July 2020
> >   * Release:			Friday, 7 August 2020
> 
> I prefer a target at the very beginning of the month, it is an insurance against
> disaster, and it may allow a quiet August month for the maintainers.
> 
> Another issue is the delay between -rc1 and final release.
> The above proposal has only 24 days -rc phase.
> Based on records, we need 30 days for a proper -rc phase.
> 
> Taking above requirements into consideration, I propose having a proposal
> deadline earlier by 8 days:
> 
> - Proposal deadline: Monday, 8 June 2020
> - Integration deadline: Tuesday, 30 June 2020
> - 20.08-rc1: Friday, 3 July 2020
> - 20.08-rc2: Friday, 17 July 2020
> - 20.08-rc3: Friday, 24 July 2020
> - 20.08-rc4: Friday, 31 July 2020
> - Release: Monday, 3 August 2020
> 
> 
I think the proposal deadline should be left at Tuesday 16 June, as developers have been working towards this date.
I am ok with the other dates.

Regards,

Bernard.