From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91A25A046B for ; Tue, 23 Jul 2019 20:45:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BFF461C0B9; Tue, 23 Jul 2019 20:45:40 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 276551C0B8; Tue, 23 Jul 2019 20:45:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 05946698; Tue, 23 Jul 2019 14:45:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 23 Jul 2019 14:45:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ROTmoNwKkofRMNQ1A4ZXuKlBTMKqbazwsHtHkAJADns=; b=UTw4TpRhHFYP OZ95gbNpgLSdeN2/tPeFkZo/yMRGrLK6+UyKOyzryfEo01YGEMs4mxvO13F0ONog h6Dm9yDw5bngmuK/Vl3i/B5bTXkNj6TVuX1g+cHWPVPlWQ4Qh7KNfDniOCjzt0Os N3SFRjgBM3a0fe1OwZcM/34sVJ1vVTg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ROTmoNwKkofRMNQ1A4ZXuKlBTMKqbazwsHtHkAJAD ns=; b=d434IN624FSJBulzBrR7suiM1vUY2G+XmtRl2LXnpFWSSDQjP/UCPczoe LImuDgv+HbVqV8CliaYKEhW+m5Yvzqzj6xCqXz4SzLj0kDmZs40QUcfEbAFuHhTw 0WPLPbW78qDiPTfWbjnJvMeZyn2+xbVoGl1cbmmTlo0674456HSXOQ6OrpcMpkE2 t2pAUvP0b6CujRAm6IqwfxA8khAZsC2xNDaunL1hrH467h1+kEKQM6kTLfyMjcDE VNVaqY/jAo977xUuFcOesawMzLyH7NjkZckzPfpisugE2Lxhgu1rOJJ8IR3B9YRk qcpkkYKdJxC39rB47eubssiNssFkw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrjeekgdduvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeelfedrvdefrdduleekrdekleenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (89.198.23.93.rev.sfr.net [93.23.198.89]) by mail.messagingengine.com (Postfix) with ESMTPA id E58738005C; Tue, 23 Jul 2019 14:45:34 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, Ferruh Yigit , stable@dpdk.org Date: Tue, 23 Jul 2019 20:45:32 +0200 Message-ID: <2216032.BmbYuEgRKz@xps> In-Reply-To: <1746857.eD02m7bUWG@xps> References: <1563873208-5096-1-git-send-email-arybchenko@solarflare.com> <1746857.eD02m7bUWG@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: avoid usage of uninit device info in bad port case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/07/2019 15:39, Thomas Monjalon: > 23/07/2019 15:34, Andrew Rybchenko: > > On 7/23/19 4:14 PM, Thomas Monjalon wrote: > > > 23/07/2019 14:11, Andrew Rybchenko: > > >> rte_eth_dev_info_get() returns void and caller does know if the function > > >> does its job or not. Changing of the return value to int would be > > >> API/ABI breakage which requires deprecation process and cannot be > > >> backported to stable branches. For now, make sure that device info is > > >> initialized even in the case of invalid port ID. > > >> > > >> Fixes: a30268e9a2d0 ("ethdev: reset whole dev info structure before filling") > > >> Cc: stable@dpdk.org > > >> > > >> Signed-off-by: Andrew Rybchenko > > Acked-by: Thomas Monjalon Applied, thanks