From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: "Ferruh Yigit" <ferruh.yigit@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Stephen Hemminger" <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert
Date: Mon, 24 Jun 2019 15:22:26 +0200 [thread overview]
Message-ID: <2216201.YhgUZRAZhV@xps> (raw)
In-Reply-To: <90efbdda-9a69-cb25-4558-9a2d3a701137@intel.com>
24/06/2019 13:31, Ferruh Yigit:
> On 6/24/2019 10:25 AM, Morten Brørup wrote:
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> >> Sent: Wednesday, June 19, 2019 8:22 PM
> >>
> >> This driver had a bogus assert which could never happen.
> >> This triggers "expression is always false warnings" with some
> >> compilers which causes build failure.
> >> Just remove it.
> >>
> >> Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status")
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> >
>
> Series applied to dpdk-next-net/master, thanks.
>
>
> @Thomas, Can we pull them to main repo quickly, to prevent the build error?
Pushed in master, thanks
prev parent reply other threads:[~2019-06-24 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 18:22 Stephen Hemminger
2019-06-19 18:22 ` [dpdk-dev] [PATCH 2/2] net/qede: " Stephen Hemminger
2019-06-24 9:23 ` Morten Brørup
2019-06-24 9:24 ` Morten Brørup
2019-06-19 22:56 ` [dpdk-dev] [PATCH 1/2] net/bnx2x: " Rasesh Mody
2019-06-24 9:25 ` Morten Brørup
2019-06-24 11:31 ` Ferruh Yigit
2019-06-24 13:22 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2216201.YhgUZRAZhV@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).