* [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert
@ 2019-06-19 18:22 Stephen Hemminger
2019-06-19 18:22 ` [dpdk-dev] [PATCH 2/2] net/qede: " Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Stephen Hemminger @ 2019-06-19 18:22 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
This driver had a bogus assert which could never happen.
This triggers "expression is always false warnings" with some
compilers which causes build failure.
Just remove it.
Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/bnx2x/bnx2x_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
index 45c6c363c077..0ee35e4e4d8e 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.c
+++ b/drivers/net/bnx2x/bnx2x_ethdev.c
@@ -150,7 +150,6 @@ static void bnx2x_periodic_start(void *param)
if (ret) {
PMD_DRV_LOG(ERR, sc, "Unable to start periodic"
" timer rc %d", ret);
- assert(false && "Unable to start periodic timer");
}
}
}
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH 2/2] net/qede: fix warnings from invalid assert
2019-06-19 18:22 [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert Stephen Hemminger
@ 2019-06-19 18:22 ` Stephen Hemminger
2019-06-24 9:23 ` Morten Brørup
2019-06-24 9:24 ` Morten Brørup
2019-06-19 22:56 ` [dpdk-dev] [PATCH 1/2] net/bnx2x: " Rasesh Mody
2019-06-24 9:25 ` Morten Brørup
2 siblings, 2 replies; 8+ messages in thread
From: Stephen Hemminger @ 2019-06-19 18:22 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
This driver had a bogus assert which could never happen.
This triggers "expression is always false warnings" with some
compilers which causes build failure.
Just remove it.
Fixes: 2af14ca79c0a ("net/qede: support 100G")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/qede/qede_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 84d898421bd4..82363e6eba93 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1426,7 +1426,6 @@ static void qede_poll_sp_sb_cb(void *param)
if (rc != 0) {
DP_ERR(edev, "Unable to start periodic"
" timer rc %d\n", rc);
- assert(false && "Unable to start periodic timer");
}
}
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] net/qede: fix warnings from invalid assert
2019-06-19 18:22 ` [dpdk-dev] [PATCH 2/2] net/qede: " Stephen Hemminger
@ 2019-06-24 9:23 ` Morten Brørup
2019-06-24 9:24 ` Morten Brørup
1 sibling, 0 replies; 8+ messages in thread
From: Morten Brørup @ 2019-06-24 9:23 UTC (permalink / raw)
To: Stephen Hemminger, dev
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, June 19, 2019 8:22 PM
>
> This driver had a bogus assert which could never happen.
> This triggers "expression is always false warnings" with some
> compilers which causes build failure.
> Just remove it.
>
> Fixes: 2af14ca79c0a ("net/qede: support 100G")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/qede/qede_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/qede/qede_ethdev.c
> b/drivers/net/qede/qede_ethdev.c
> index 84d898421bd4..82363e6eba93 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -1426,7 +1426,6 @@ static void qede_poll_sp_sb_cb(void *param)
> if (rc != 0) {
> DP_ERR(edev, "Unable to start periodic"
> " timer rc %d\n", rc);
> - assert(false && "Unable to start periodic timer");
> }
> }
>
> --
> 2.20.1
>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] net/qede: fix warnings from invalid assert
2019-06-19 18:22 ` [dpdk-dev] [PATCH 2/2] net/qede: " Stephen Hemminger
2019-06-24 9:23 ` Morten Brørup
@ 2019-06-24 9:24 ` Morten Brørup
1 sibling, 0 replies; 8+ messages in thread
From: Morten Brørup @ 2019-06-24 9:24 UTC (permalink / raw)
To: Stephen Hemminger, dev
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, June 19, 2019 8:22 PM
>
> This driver had a bogus assert which could never happen.
> This triggers "expression is always false warnings" with some
> compilers which causes build failure.
> Just remove it.
>
> Fixes: 2af14ca79c0a ("net/qede: support 100G")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/qede/qede_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/qede/qede_ethdev.c
> b/drivers/net/qede/qede_ethdev.c
> index 84d898421bd4..82363e6eba93 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -1426,7 +1426,6 @@ static void qede_poll_sp_sb_cb(void *param)
> if (rc != 0) {
> DP_ERR(edev, "Unable to start periodic"
> " timer rc %d\n", rc);
> - assert(false && "Unable to start periodic timer");
> }
> }
>
> --
> 2.20.1
>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert
2019-06-19 18:22 [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert Stephen Hemminger
2019-06-19 18:22 ` [dpdk-dev] [PATCH 2/2] net/qede: " Stephen Hemminger
@ 2019-06-19 22:56 ` Rasesh Mody
2019-06-24 9:25 ` Morten Brørup
2 siblings, 0 replies; 8+ messages in thread
From: Rasesh Mody @ 2019-06-19 22:56 UTC (permalink / raw)
To: Stephen Hemminger, dev
>From: dev <dev-bounces@dpdk.org> On Behalf Of Stephen Hemminger
>Sent: Wednesday, June 19, 2019 11:22 AM
>
>This driver had a bogus assert which could never happen.
>This triggers "expression is always false warnings" with some compilers which
>causes build failure.
>Just remove it.
>
>Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status")
>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>---
For both patches,
Acked-by: Rasesh Mody <rmody@marvell.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert
2019-06-19 18:22 [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert Stephen Hemminger
2019-06-19 18:22 ` [dpdk-dev] [PATCH 2/2] net/qede: " Stephen Hemminger
2019-06-19 22:56 ` [dpdk-dev] [PATCH 1/2] net/bnx2x: " Rasesh Mody
@ 2019-06-24 9:25 ` Morten Brørup
2019-06-24 11:31 ` Ferruh Yigit
2 siblings, 1 reply; 8+ messages in thread
From: Morten Brørup @ 2019-06-24 9:25 UTC (permalink / raw)
To: Stephen Hemminger, dev
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, June 19, 2019 8:22 PM
>
> This driver had a bogus assert which could never happen.
> This triggers "expression is always false warnings" with some
> compilers which causes build failure.
> Just remove it.
>
> Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/bnx2x/bnx2x_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c
> b/drivers/net/bnx2x/bnx2x_ethdev.c
> index 45c6c363c077..0ee35e4e4d8e 100644
> --- a/drivers/net/bnx2x/bnx2x_ethdev.c
> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
> @@ -150,7 +150,6 @@ static void bnx2x_periodic_start(void *param)
> if (ret) {
> PMD_DRV_LOG(ERR, sc, "Unable to start periodic"
> " timer rc %d", ret);
> - assert(false && "Unable to start periodic timer");
> }
> }
> }
> --
> 2.20.1
>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert
2019-06-24 9:25 ` Morten Brørup
@ 2019-06-24 11:31 ` Ferruh Yigit
2019-06-24 13:22 ` Thomas Monjalon
0 siblings, 1 reply; 8+ messages in thread
From: Ferruh Yigit @ 2019-06-24 11:31 UTC (permalink / raw)
To: Morten Brørup, Stephen Hemminger, dev, Thomas Monjalon
On 6/24/2019 10:25 AM, Morten Brørup wrote:
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
>> Sent: Wednesday, June 19, 2019 8:22 PM
>>
>> This driver had a bogus assert which could never happen.
>> This triggers "expression is always false warnings" with some
>> compilers which causes build failure.
>> Just remove it.
>>
>> Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status")
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
Series applied to dpdk-next-net/master, thanks.
@Thomas, Can we pull them to main repo quickly, to prevent the build error?
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert
2019-06-24 11:31 ` Ferruh Yigit
@ 2019-06-24 13:22 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-06-24 13:22 UTC (permalink / raw)
To: dev; +Cc: Ferruh Yigit, Morten Brørup, Stephen Hemminger
24/06/2019 13:31, Ferruh Yigit:
> On 6/24/2019 10:25 AM, Morten Brørup wrote:
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> >> Sent: Wednesday, June 19, 2019 8:22 PM
> >>
> >> This driver had a bogus assert which could never happen.
> >> This triggers "expression is always false warnings" with some
> >> compilers which causes build failure.
> >> Just remove it.
> >>
> >> Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status")
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> >
>
> Series applied to dpdk-next-net/master, thanks.
>
>
> @Thomas, Can we pull them to main repo quickly, to prevent the build error?
Pushed in master, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-24 13:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 18:22 [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert Stephen Hemminger
2019-06-19 18:22 ` [dpdk-dev] [PATCH 2/2] net/qede: " Stephen Hemminger
2019-06-24 9:23 ` Morten Brørup
2019-06-24 9:24 ` Morten Brørup
2019-06-19 22:56 ` [dpdk-dev] [PATCH 1/2] net/bnx2x: " Rasesh Mody
2019-06-24 9:25 ` Morten Brørup
2019-06-24 11:31 ` Ferruh Yigit
2019-06-24 13:22 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).