From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: disable ICC warning 188
Date: Wed, 04 Jan 2017 20:57:04 +0100 [thread overview]
Message-ID: <2218904.6u9s4lZvRY@xps13> (raw)
In-Reply-To: <20170103171907.GD12822@6wind.com>
2017-01-03 18:19, Adrien Mazarguil:
> On Tue, Jan 03, 2017 at 04:15:42PM +0000, Ferruh Yigit wrote:
> > error #188: enumerated type mixed with another type
> >
> > This is get when an integer assigned to an enum variable.
> >
> > Since this usage is common and causing many ICC compilation errors, and
> > other compilers accept this usage. Disabling the warning.
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> I also think this warning may be useful but is not worth the trouble in many
> cases, thus:
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied, thanks
I think we should mark ICC support as best effort to make clear
that no ICC check is required from contributors.
prev parent reply other threads:[~2017-01-04 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 16:15 Ferruh Yigit
2017-01-03 17:19 ` Adrien Mazarguil
2017-01-04 19:57 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2218904.6u9s4lZvRY@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).