[dpdk-dev] [PATCH] mk: disable ICC warning 188

[dpdk-dev] [PATCH] mk: disable ICC warning 188

[Ferruh Yigit]

error #188: enumerated type mixed with another type

This is get when an integer assigned to an enum variable.

Since this usage is common and causing many ICC compilation errors, and
other compilers accept this usage. Disabling the warning.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 mk/toolchain/icc/rte.vars.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
index ba69f1f..86d9ef7 100644
--- a/mk/toolchain/icc/rte.vars.mk
+++ b/mk/toolchain/icc/rte.vars.mk
@@ -71,6 +71,7 @@ TOOLCHAIN_ASFLAGS =
 #                   was declared "deprecated"
 WERROR_FLAGS := -Wall -w2 -diag-disable 271 -diag-warning 1478
 WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
+WERROR_FLAGS += -diag-disable 188
 
 ifeq ($(RTE_DEVEL_BUILD),y)
 WERROR_FLAGS += -Werror-all
-- 
2.9.3

Re: [dpdk-dev] [PATCH] mk: disable ICC warning 188

[Adrien Mazarguil]

On Tue, Jan 03, 2017 at 04:15:42PM +0000, Ferruh Yigit wrote:
> error #188: enumerated type mixed with another type
> 
> This is get when an integer assigned to an enum variable.
> 
> Since this usage is common and causing many ICC compilation errors, and
> other compilers accept this usage. Disabling the warning.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  mk/toolchain/icc/rte.vars.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
> index ba69f1f..86d9ef7 100644
> --- a/mk/toolchain/icc/rte.vars.mk
> +++ b/mk/toolchain/icc/rte.vars.mk
> @@ -71,6 +71,7 @@ TOOLCHAIN_ASFLAGS =
>  #                   was declared "deprecated"
>  WERROR_FLAGS := -Wall -w2 -diag-disable 271 -diag-warning 1478
>  WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
> +WERROR_FLAGS += -diag-disable 188
>  
>  ifeq ($(RTE_DEVEL_BUILD),y)
>  WERROR_FLAGS += -Werror-all
> -- 
> 2.9.3

I also think this warning may be useful but is not worth the trouble in many
cases, thus:

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND

Re: [dpdk-dev] [PATCH] mk: disable ICC warning 188

[Thomas Monjalon]

2017-01-03 18:19, Adrien Mazarguil:
> On Tue, Jan 03, 2017 at 04:15:42PM +0000, Ferruh Yigit wrote:
> > error #188: enumerated type mixed with another type
> > 
> > This is get when an integer assigned to an enum variable.
> > 
> > Since this usage is common and causing many ICC compilation errors, and
> > other compilers accept this usage. Disabling the warning.
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> I also think this warning may be useful but is not worth the trouble in many
> cases, thus:
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied, thanks

I think we should mark ICC support as best effort to make clear
that no ICC check is required from contributors.