* [dpdk-dev] [PATCH] mk: disable ICC warning 188
@ 2017-01-03 16:15 Ferruh Yigit
2017-01-03 17:19 ` Adrien Mazarguil
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-01-03 16:15 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon, Ferruh Yigit
error #188: enumerated type mixed with another type
This is get when an integer assigned to an enum variable.
Since this usage is common and causing many ICC compilation errors, and
other compilers accept this usage. Disabling the warning.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
mk/toolchain/icc/rte.vars.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
index ba69f1f..86d9ef7 100644
--- a/mk/toolchain/icc/rte.vars.mk
+++ b/mk/toolchain/icc/rte.vars.mk
@@ -71,6 +71,7 @@ TOOLCHAIN_ASFLAGS =
# was declared "deprecated"
WERROR_FLAGS := -Wall -w2 -diag-disable 271 -diag-warning 1478
WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
+WERROR_FLAGS += -diag-disable 188
ifeq ($(RTE_DEVEL_BUILD),y)
WERROR_FLAGS += -Werror-all
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: disable ICC warning 188
2017-01-03 16:15 [dpdk-dev] [PATCH] mk: disable ICC warning 188 Ferruh Yigit
@ 2017-01-03 17:19 ` Adrien Mazarguil
2017-01-04 19:57 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Adrien Mazarguil @ 2017-01-03 17:19 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Thomas Monjalon
On Tue, Jan 03, 2017 at 04:15:42PM +0000, Ferruh Yigit wrote:
> error #188: enumerated type mixed with another type
>
> This is get when an integer assigned to an enum variable.
>
> Since this usage is common and causing many ICC compilation errors, and
> other compilers accept this usage. Disabling the warning.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> mk/toolchain/icc/rte.vars.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
> index ba69f1f..86d9ef7 100644
> --- a/mk/toolchain/icc/rte.vars.mk
> +++ b/mk/toolchain/icc/rte.vars.mk
> @@ -71,6 +71,7 @@ TOOLCHAIN_ASFLAGS =
> # was declared "deprecated"
> WERROR_FLAGS := -Wall -w2 -diag-disable 271 -diag-warning 1478
> WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
> +WERROR_FLAGS += -diag-disable 188
>
> ifeq ($(RTE_DEVEL_BUILD),y)
> WERROR_FLAGS += -Werror-all
> --
> 2.9.3
I also think this warning may be useful but is not worth the trouble in many
cases, thus:
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: disable ICC warning 188
2017-01-03 17:19 ` Adrien Mazarguil
@ 2017-01-04 19:57 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-01-04 19:57 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Adrien Mazarguil, dev
2017-01-03 18:19, Adrien Mazarguil:
> On Tue, Jan 03, 2017 at 04:15:42PM +0000, Ferruh Yigit wrote:
> > error #188: enumerated type mixed with another type
> >
> > This is get when an integer assigned to an enum variable.
> >
> > Since this usage is common and causing many ICC compilation errors, and
> > other compilers accept this usage. Disabling the warning.
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> I also think this warning may be useful but is not worth the trouble in many
> cases, thus:
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied, thanks
I think we should mark ICC support as best effort to make clear
that no ICC check is required from contributors.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-04 19:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-03 16:15 [dpdk-dev] [PATCH] mk: disable ICC warning 188 Ferruh Yigit
2017-01-03 17:19 ` Adrien Mazarguil
2017-01-04 19:57 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).