From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C855A1E34 for ; Mon, 18 Sep 2017 22:18:06 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 13:18:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,414,1500966000"; d="scan'208";a="901454739" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 18 Sep 2017 13:18:03 -0700 To: Hemant Agrawal , dev@dpdk.org, Pablo de Lara , Jerin Jacob Cc: shreyansh.jain@nxp.com, Thomas Monjalon References: <1504860327-18451-1-git-send-email-hemant.agrawal@nxp.com> <1505559161-29222-1-git-send-email-hemant.agrawal@nxp.com> <1505559161-29222-4-git-send-email-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: <221ecc58-a4c1-fd19-4281-13e096159159@intel.com> Date: Mon, 18 Sep 2017 21:18:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1505559161-29222-4-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 03/27] bus/fslmc: add qbman API to do enqueue with multiple frames X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 20:18:07 -0000 On 9/16/2017 11:52 AM, Hemant Agrawal wrote: > From: Haiying Wang > > Clean it up and update the prototype. > > Signed-off-by: Haiying Wang > Signed-off-by: Hemant Agrawal > --- > drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h | 32 ++-- > drivers/bus/fslmc/qbman/qbman_portal.c | 200 +++++++-------------- > drivers/bus/fslmc/rte_bus_fslmc_version.map | 3 +- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- > drivers/event/dpaa2/dpaa2_eventdev.c | 2 +- I guess there is no escape from updating eventdev and cryptodev here. But since I am planning to get this patch into next-net, lets add other maintainers to cc to get their confirmation. > drivers/net/dpaa2/dpaa2_rxtx.c | 2 +- > 6 files changed, 83 insertions(+), 158 deletions(-) <...> > diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map > index 6ac256d..13fb46a 100644 > --- a/drivers/bus/fslmc/rte_bus_fslmc_version.map > +++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map > @@ -69,7 +69,8 @@ DPDK_17.08 { > qbman_result_SCN_state_in_mem; > qbman_swp_dqrr_consume; > qbman_swp_dqrr_next; > - qbman_swp_enqueue_multiple_eqdesc; > + qbman_swp_enqueue_multiple; > + qbman_swp_enqueue_multiple_desc; > qbman_swp_interrupt_clear_status; > qbman_swp_push_set; > rte_dpaa2_alloc_dpci_dev; > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 95c3951..094cf30 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -634,7 +634,7 @@ dpaa2_sec_enqueue_burst(void *qp, struct rte_crypto_op **ops, > } > loop = 0; > while (loop < frames_to_send) { > - loop += qbman_swp_send_multiple(swp, &eqdesc, > + loop += qbman_swp_enqueue_multiple(swp, &eqdesc, > &fd_arr[loop], > frames_to_send - loop); > } > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c > index cf2d274..81286a8 100644 > --- a/drivers/event/dpaa2/dpaa2_eventdev.c > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c > @@ -144,7 +144,7 @@ dpaa2_eventdev_enqueue_burst(void *port, const struct rte_event ev[], > } > loop = 0; > while (loop < frames_to_send) { > - loop += qbman_swp_enqueue_multiple_eqdesc(swp, > + loop += qbman_swp_enqueue_multiple_desc(swp, > &eqdesc[loop], &fd_arr[loop], > frames_to_send - loop); > } > diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c > index 3c057a3..4342c73 100644 > --- a/drivers/net/dpaa2/dpaa2_rxtx.c > +++ b/drivers/net/dpaa2/dpaa2_rxtx.c > @@ -622,7 +622,7 @@ dpaa2_dev_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > } > loop = 0; > while (loop < frames_to_send) { > - loop += qbman_swp_send_multiple(swp, &eqdesc, > + loop += qbman_swp_enqueue_multiple(swp, &eqdesc, > &fd_arr[loop], frames_to_send - loop); > } > >