From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0491529C8 for <dev@dpdk.org>; Fri, 21 Jul 2017 00:36:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9859F209A2; Thu, 20 Jul 2017 18:36:37 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 20 Jul 2017 18:36:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=GsreRMpNX+3pNY3 0gP6i7cC8oTArY236SvJejAD7c3I=; b=OYK1cfL0SA0VpCLYbTIQCuHW43Izcqf JEJut3Uy7ojNRFv82RfQddB1R76jjNdcgojzx4uHjJ2mTm4YAYR5Tuozacf3edhp qBiG/CoIDJRW46A7OZgv68bJ0fxuVS4b5OA73tafkNsJa6zOI0N2+fqKL5KsuRDl uR3n7rnCp40U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=GsreRMpNX+3pNY30gP6i7cC8oTArY236SvJejAD7c3I=; b=fzmyM6BB 3JSmq5PA2gkDrDxzhjTDXIprVu5wolKImoCPGBs5L2NHbc5whuX/iYRICyM+oZBR gvglQei/g0E7YrVFEsTgoaqfPxGyF4sup9CykH56c8ll0cmTpKqOG1xKHJtkAVtH b3anQe3QDbTqNFW6hxcQ/8og9k6VN2NME9t9Z+O/36J7TVsU2Q+h3NxhYNe2QGCN ypNiQgErnmBxhQwPZ+DbOiJkZ8hgR+6H6dOIMwAq5I2vrdt45B3HJae2tuRFr6qS Z6+vLHyGIgnqemkoaIkDLddgIlYlgFKOmTKQXLnYHVe0+zvH/AvLjYLZZUrRike/ EPYUSP+zZfgtXw== X-ME-Sender: <xms:dTBxWX4WTpHxaaK-nRSHPkjvPhyO_zfi32vc5JUdz0zI9XaCUIEUiA> X-Sasl-enc: FdrGBaQ9S5bHPCCXShaCeNCUE5A0tni8SSeviFV9Jkq1 1500590196 Received: from xps.localnet (unknown [37.167.112.176]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D8D37E7D3; Thu, 20 Jul 2017 18:36:36 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Shijith Thotton <shijith.thotton@caviumnetworks.com> Cc: dev@dpdk.org, Gregory Etelson <gregory@weka.io>, Ferruh Yigit <ferruh.yigit@intel.com>, "Tan, Jianfeng" <jianfeng.tan@intel.com>, Stephen Hemminger <stephen@networkplumber.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com> Date: Fri, 21 Jul 2017 01:36:34 +0300 Message-ID: <2220416.3B1vv7SqcQ@xps> In-Reply-To: <1723914.rl5aSUidYg@polaris> References: <1497260285-27536-1-git-send-email-shijith.thotton@caviumnetworks.com> <43fc4f53-404d-242b-4a6e-508966b236af@intel.com> <1723914.rl5aSUidYg@polaris> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 20 Jul 2017 22:36:38 -0000 > > >> Set UIO info device file operations open and release. Call pci reset > > >> function inside open and release to clear device state at start and end. > > >> Copied this behaviour from vfio_pci kernel module code. With this patch, > > >> it is not mandatory to issue FLR by PMD's during init and close. > > >> > > >> Bus master enable and disable are added in open and release respectively > > >> to take care of device DMA. > > >> > > >> Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com> > > > > > > Reviewed-by: Jianfeng Tan <jianfeng.tan@intel.com> > > > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Acked-by: Gregory Etelson <gregory@weka.io> Applied, thanks