* [dpdk-dev] [PATCH] mk: remove "u" modifier from "ar" command
@ 2015-06-05 11:05 Bruce Richardson
2015-06-08 8:13 ` Olivier MATZ
2015-06-09 12:51 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
0 siblings, 2 replies; 6+ messages in thread
From: Bruce Richardson @ 2015-06-05 11:05 UTC (permalink / raw)
To: dev
On Fedora 22, the "ar" binary operates by default in deterministic mode,
making the "u" parameter irrelevant, and leading to warning messages
getting printed in the build output like below.
INSTALL-LIB librte_kvargs.a
ar: `u' modifier ignored since `D' is the default (see `U')
There are two options to remove these warnings:
* add in the "U" flag to make "ar" non-deterministic again
* remove the "u" flag to have all objects always updated
This patch takes the second approach.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
mk/rte.lib.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
index 0d7482d..6bd67aa 100644
--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk
@@ -70,7 +70,7 @@ else
_CPU_LDFLAGS := $(CPU_LDFLAGS)
endif
-O_TO_A = $(AR) crus $(LIB) $(OBJS-y)
+O_TO_A = $(AR) crs $(LIB) $(OBJS-y)
O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight
O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)")
O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)"
--
2.4.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: remove "u" modifier from "ar" command
2015-06-05 11:05 [dpdk-dev] [PATCH] mk: remove "u" modifier from "ar" command Bruce Richardson
@ 2015-06-08 8:13 ` Olivier MATZ
2015-06-08 10:47 ` Bruce Richardson
2015-06-09 12:51 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
1 sibling, 1 reply; 6+ messages in thread
From: Olivier MATZ @ 2015-06-08 8:13 UTC (permalink / raw)
To: Bruce Richardson, dev
Hi Bruce,
On 06/05/2015 01:05 PM, Bruce Richardson wrote:
> On Fedora 22, the "ar" binary operates by default in deterministic mode,
> making the "u" parameter irrelevant, and leading to warning messages
> getting printed in the build output like below.
>
> INSTALL-LIB librte_kvargs.a
> ar: `u' modifier ignored since `D' is the default (see `U')
>
> There are two options to remove these warnings:
> * add in the "U" flag to make "ar" non-deterministic again
> * remove the "u" flag to have all objects always updated
Indeed, I think that removing 'u' won't have any impact in this case,
as we always regenerate the full archive without updating it.
However, why not explicitly use 'D' to have the same behavior across
distributions?
Regards,
Olivier
>
> This patch takes the second approach.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> mk/rte.lib.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
> index 0d7482d..6bd67aa 100644
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -70,7 +70,7 @@ else
> _CPU_LDFLAGS := $(CPU_LDFLAGS)
> endif
>
> -O_TO_A = $(AR) crus $(LIB) $(OBJS-y)
> +O_TO_A = $(AR) crs $(LIB) $(OBJS-y)
> O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight
> O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)")
> O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)"
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: remove "u" modifier from "ar" command
2015-06-08 8:13 ` Olivier MATZ
@ 2015-06-08 10:47 ` Bruce Richardson
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2015-06-08 10:47 UTC (permalink / raw)
To: Olivier MATZ; +Cc: dev
On Mon, Jun 08, 2015 at 10:13:30AM +0200, Olivier MATZ wrote:
> Hi Bruce,
>
> On 06/05/2015 01:05 PM, Bruce Richardson wrote:
> > On Fedora 22, the "ar" binary operates by default in deterministic mode,
> > making the "u" parameter irrelevant, and leading to warning messages
> > getting printed in the build output like below.
> >
> > INSTALL-LIB librte_kvargs.a
> > ar: `u' modifier ignored since `D' is the default (see `U')
> >
> > There are two options to remove these warnings:
> > * add in the "U" flag to make "ar" non-deterministic again
> > * remove the "u" flag to have all objects always updated
>
> Indeed, I think that removing 'u' won't have any impact in this case,
> as we always regenerate the full archive without updating it.
> However, why not explicitly use 'D' to have the same behavior across
> distributions?
>
> Regards,
> Olivier
>
Good question. I didn't bother adding in the "D" flag as I didn't see the need.
[Basically, I asked "why" instead of "why not" :-)]
However, if folks think it's worthwhile doing, I don't think doing a V2 of
this patch would tax me unduly :-)
/Bruce
>
> >
> > This patch takes the second approach.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > mk/rte.lib.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
> > index 0d7482d..6bd67aa 100644
> > --- a/mk/rte.lib.mk
> > +++ b/mk/rte.lib.mk
> > @@ -70,7 +70,7 @@ else
> > _CPU_LDFLAGS := $(CPU_LDFLAGS)
> > endif
> >
> > -O_TO_A = $(AR) crus $(LIB) $(OBJS-y)
> > +O_TO_A = $(AR) crs $(LIB) $(OBJS-y)
> > O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight
> > O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)")
> > O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)"
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] mk: remove "u" modifier from "ar" command
2015-06-05 11:05 [dpdk-dev] [PATCH] mk: remove "u" modifier from "ar" command Bruce Richardson
2015-06-08 8:13 ` Olivier MATZ
@ 2015-06-09 12:51 ` Bruce Richardson
2015-06-09 14:17 ` Olivier MATZ
1 sibling, 1 reply; 6+ messages in thread
From: Bruce Richardson @ 2015-06-09 12:51 UTC (permalink / raw)
To: dev
On Fedora 22, the "ar" binary operates by default in deterministic mode,
making the "u" parameter irrelevant, and leading to warning messages
getting printed in the build output like below.
INSTALL-LIB librte_kvargs.a
ar: `u' modifier ignored since `D' is the default (see `U')
There are two options to remove these warnings:
* add in the "U" flag to make "ar" non-deterministic again
* remove the "u" flag to have all objects always updated
This patch takes the second approach. It also explicitly adds in the "D"
flag to make behaviour consistent across different distributions which
may have different defaults.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
V2 Changes: Add in "D" flag for consistency across distros.
---
mk/rte.lib.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
index 0d7482d..25aa989 100644
--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk
@@ -70,7 +70,7 @@ else
_CPU_LDFLAGS := $(CPU_LDFLAGS)
endif
-O_TO_A = $(AR) crus $(LIB) $(OBJS-y)
+O_TO_A = $(AR) crDs $(LIB) $(OBJS-y)
O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight
O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)")
O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)"
--
2.4.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] mk: remove "u" modifier from "ar" command
2015-06-09 12:51 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
@ 2015-06-09 14:17 ` Olivier MATZ
2015-06-29 12:30 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Olivier MATZ @ 2015-06-09 14:17 UTC (permalink / raw)
To: Bruce Richardson, dev
Hi Bruce,
On 06/09/2015 02:51 PM, Bruce Richardson wrote:
> On Fedora 22, the "ar" binary operates by default in deterministic mode,
> making the "u" parameter irrelevant, and leading to warning messages
> getting printed in the build output like below.
>
> INSTALL-LIB librte_kvargs.a
> ar: `u' modifier ignored since `D' is the default (see `U')
>
> There are two options to remove these warnings:
> * add in the "U" flag to make "ar" non-deterministic again
> * remove the "u" flag to have all objects always updated
>
> This patch takes the second approach. It also explicitly adds in the "D"
> flag to make behaviour consistent across different distributions which
> may have different defaults.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
>
> ---
> V2 Changes: Add in "D" flag for consistency across distros.
> ---
> mk/rte.lib.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
> index 0d7482d..25aa989 100644
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -70,7 +70,7 @@ else
> _CPU_LDFLAGS := $(CPU_LDFLAGS)
> endif
>
> -O_TO_A = $(AR) crus $(LIB) $(OBJS-y)
> +O_TO_A = $(AR) crDs $(LIB) $(OBJS-y)
> O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight
> O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)")
> O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)"
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] mk: remove "u" modifier from "ar" command
2015-06-09 14:17 ` Olivier MATZ
@ 2015-06-29 12:30 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2015-06-29 12:30 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
2015-06-09 16:17, Olivier MATZ:
> On 06/09/2015 02:51 PM, Bruce Richardson wrote:
> > On Fedora 22, the "ar" binary operates by default in deterministic mode,
> > making the "u" parameter irrelevant, and leading to warning messages
> > getting printed in the build output like below.
> >
> > INSTALL-LIB librte_kvargs.a
> > ar: `u' modifier ignored since `D' is the default (see `U')
> >
> > There are two options to remove these warnings:
> > * add in the "U" flag to make "ar" non-deterministic again
> > * remove the "u" flag to have all objects always updated
> >
> > This patch takes the second approach. It also explicitly adds in the "D"
> > flag to make behaviour consistent across different distributions which
> > may have different defaults.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-29 12:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-05 11:05 [dpdk-dev] [PATCH] mk: remove "u" modifier from "ar" command Bruce Richardson
2015-06-08 8:13 ` Olivier MATZ
2015-06-08 10:47 ` Bruce Richardson
2015-06-09 12:51 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2015-06-09 14:17 ` Olivier MATZ
2015-06-29 12:30 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).