From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E21D4A0526; Wed, 8 Jul 2020 16:29:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4F711DF90; Wed, 8 Jul 2020 16:29:14 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id E9C3B1DEF3 for ; Wed, 8 Jul 2020 16:29:13 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 8C8235803BD; Wed, 8 Jul 2020 10:29:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 08 Jul 2020 10:29:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= VdzzXRAAhLghtpU4YHVnR0l5+tVbB8Wv5OVcQjNwRBI=; b=XdreNUkHvn/uwXuI EAhEcV/EUOsQ9jmfYSUuhKGxjhn9FO6pHKogzhTp2XxC5iKzHSTRXXGpunUG6OSK zhfKNBLwm1iKxhNgIIJDYg7DrcORrKjxsp6AMnvDj0zH9SzBNMmTI0F0H8sRbfgD MkUKtyZSzICf8twNnh+IWN5kzROfZE7fCtco2GsAOjU17OUeLZZ7Bwe/R9amwMzH oFVixriWEqjDILvT3NAuJzZiihVKysjVgbmRJoNzVXZVwIl0bB3/s+ry994gO/ez RulCGenA2D6ZCH1RhYMSlxL5BhvDuSPokXXCVKns1wm0mvxr3E7uqnXwIdBhAGPs 4PjgAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=VdzzXRAAhLghtpU4YHVnR0l5+tVbB8Wv5OVcQjNwR BI=; b=RlKkUi+2JjUwTsMXTkR3uD9k4yUBmS5sH3RqpKmo5ep1YZam6ekwOEr2H 6awgKFBfpGb3gpcSBtQHkCWKh+Mu2K8Ufsn7SvxamguEaC18KEm4CcA0uZVHGGUF 39XEInTK32yDt3Ej2D73bxE86a0Kx73QjPtpXjMsnyErjEm7YbIPI2CUV+8TFxcR 0b+SzfYiyeHMu6000nkeY3qUaHH2gqoRwNCfWctoEG0lbk4Rxy4xuPu4ItghFCtv ZNqwaTexSAmspSZNr4+RddTgI/+X18xU2khCMZ8xeLmNjqgASyULiyzEWoPSGxqf FTdBlCevF4ybdREilzw5svM0DIHkg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudejgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeefleehieetteetgfdukeetiefhieetgfdvfefhtddvieefgffgheet feefudeufeenucffohhmrghinhepihgvthhfrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F225230600A6; Wed, 8 Jul 2020 10:29:11 -0400 (EDT) From: Thomas Monjalon To: "Xing, Beilei" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , "Guo, Jia" , "Guo, Junfeng" , "Su, Simei" , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "viacheslavo@mellanox.com" , "jerinj@marvell.com" , "ajit.khaparde@broadcom.com" , "orika@mellanox.com" Date: Wed, 08 Jul 2020 16:29:10 +0200 Message-ID: <2222669.ed38JIK7Hh@thomas> In-Reply-To: <039ED4275CED7440929022BC67E7061154858537@SHSMSX103.ccr.corp.intel.com> References: <20200612080711.39774-1-junfeng.guo@intel.com> <1845327.VSnYL2Xkle@thomas> <039ED4275CED7440929022BC67E7061154858537@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add new RSS types for IPv6 prefix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/07/2020 14:37, Zhang, Qi Z: > From: Thomas Monjalon > > 08/07/2020 14:05, Zhang, Qi Z: > > > From: Thomas Monjalon > > > > 08/07/2020 13:10, Zhang, Qi Z: > > > > > From: Thomas Monjalon > > > > > > 08/07/2020 11:45, Zhang, Qi Z: > > > > > > > On 2020/7/7 19:06, Thomas Monjalon wrote: > > > > > > > > 16/06/2020 10:16, Junfeng Guo: > > > > > > > >> This patch defines new RSS offload types for IPv6 prefix > > > > > > > >> with 32, 48, > > > > > > > >> 64 bits of both SRC and DST IPv6 address. > > > > > > > >> > > > > > > > >> Signed-off-by: Junfeng Guo > > > > > > > >> --- > > > > > > > >> lib/librte_ethdev/rte_ethdev.h | 51 > > > > > > ++++++++++++++++++++++++++++++++++ > > > > > > > >> 1 file changed, 51 insertions(+) > > > > > > > >> > > > > > > > >> diff --git a/lib/librte_ethdev/rte_ethdev.h > > > > > > > >> b/lib/librte_ethdev/rte_ethdev.h index 631b146bd..5a7ba36d8 > > > > > > > >> 100644 > > > > > > > >> --- a/lib/librte_ethdev/rte_ethdev.h > > > > > > > >> +++ b/lib/librte_ethdev/rte_ethdev.h > > > > > > > >> @@ -538,6 +538,9 @@ struct rte_eth_rss_conf { > > > > > > > >> #define ETH_RSS_L4_DST_ONLY (1ULL << 60) > > > > > > > >> #define ETH_RSS_L2_SRC_ONLY (1ULL << 59) > > > > > > > >> #define ETH_RSS_L2_DST_ONLY (1ULL << 58) > > > > > > > >> +#define ETH_RSS_L3_PRE32 (1ULL << 57) > > > > > > > >> +#define ETH_RSS_L3_PRE48 (1ULL << 56) > > > > > > > >> +#define ETH_RSS_L3_PRE64 (1ULL << 55) > > > > > > > > > > > > > > > > PRE32, 48 and 64 are not obvious. > > > > > > > > Why is it needed? > > > > > > > > > > > > > > there is typical usage for NAT64, which use 32 bit prefix for > > > > > > > IPv6 addresses, in this case flows over IPv4 and IPv6 will > > > > > > > result in the same hash value, as well as 48, 64, which also > > > > > > > have some corresponding use cases, > > > > > > > > At least, please add comments for the values of this API. > > > > > > > > > > > > > > sure, we will add more comments. > > [...] > > > > > > > 32, 48, 64 are typical usage, and consider suffix pair we may > > > > > > > add later, it will cost 6 bits so far we still have 27 bit > > > > > > > left, so it looks like will not be a problem in following couple > > releases. > > > > > > > > > > > > Having some space left is not a reason to waste it :) If I > > > > > > understand well, there is no standard for this API. > > > > > > You are assigning some bits to some usage. > > > > > > I don't find it generic and flexible enough. > > > > > > > > > > Actually IPv6 address prefix is in spec, please check below RFC. > > > > > https://tools.ietf.org/html/rfc6052#page-5 > > > > > > > > Quoting the RFC: > > > > " > > > > the prefix shall be either the "Well-Known Prefix" > > > > or a "Network-Specific Prefix" unique to the organization > > > > deploying the address translators. > > > > The prefixes can only have one of the following lengths: > > > > 32, 40, 48, 56, 64, or 96. > > > > (The Well-Known Prefix is 96 bits long, and can only be used > > > > in the last form of the table.) > > > > " > > > > > > > > So 40 and 56 are missing. > > > > > > Yes, like to add and lets accelerate the progress to abandon the old > > > APIs :) > > > > Please could list which part of the existing API you would like to deprecate in > > future? > > I think it's a new version of rte_flow_action_rss, we need a more generic way to describe the RSS input set of a flow > But not just a 64 bits type, then all ETH_RSS_xxx will be decoupled from rte_flow. I was asking what would you deprecate?