From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "E. Scott Daniels" <daniels@research.att.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] lib/ether: prevent duplicate callback on list
Date: Tue, 25 Oct 2016 23:35:02 +0200 [thread overview]
Message-ID: <2223568.QpbvufUhIb@xps13> (raw)
In-Reply-To: <1476970481-21034-1-git-send-email-daniels@research.att.com>
2016-10-20 09:34, E. Scott Daniels:
> This change prevents the attempt to add a structure which is
> already on the callback list. If a struct with matching
> parameters is found on the list, then no action is taken. If
> a struct with matching parameters is found on the list, then
> no action is taken.
Callback is not duplicate anymore but the last sentence is duplicate :)
> Fixes: ac2f69c ("ethdev: fix crash if malloc of user callback fails")
>
> Signed-off-by: E. Scott Daniels <daniels@research.att.com>
> ---
>
> V2:
> * Correct the component name; changed from net/ixgbe.
> * Add Fixes tag.
> * Acked-by: Wenzhuo Lu <Wenzhuo.lu@intel.com>
The Acked-by tag must be added below your Signed-off-by.
Applied with above nits fixed, thanks
prev parent reply other threads:[~2016-10-25 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 13:34 E. Scott Daniels
2016-10-25 21:35 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2223568.QpbvufUhIb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=daniels@research.att.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).