From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id C5D696CBD for ; Tue, 25 Oct 2016 23:35:04 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id d128so51392714wmf.1 for ; Tue, 25 Oct 2016 14:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=5NyY/f/khT2+kYrMv4R8pcFnfrRWZWCDksgtyEX2e9A=; b=tCuXnm4Ix51zlJZX8e1ijj57S8Qlseh5mwa6pnQTtFQg/fDzQQNWE34tEhHimzZf3e hB4cliOF/6cFya7HTUOT/ABNJ7UC5rjVHUuAxYqsBev2JjkUsbscHJn6MYC85HmH4h+S 6dflqZCy0JDZDUz5ZX/YcK5R8Wp3mJIqZlYl3Z9WG6Dy53c8AOlRj6kRa13SxSoDqb3F +AHwqAhNTAZDUPkJS1tPDMvFUzFsHZJqNl9A5nnTbTYZzLEyYYe9HgqFob57t3MKmez7 QI4HH9kXrRKQSq3ciWrqC3FXg4cwoi+LF/Su50be3GL8iNzUBv0SWYARGq2XMTTPmz4k lecA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=5NyY/f/khT2+kYrMv4R8pcFnfrRWZWCDksgtyEX2e9A=; b=MgHnVkfXb2blGjESmqajJAMhcqjknpHEK+JQdD111VtbnfjlzBaxCuTQ/2XmD0EmVm KDpGmbTOtc0TyF2BxlRWv1o/tAxy8Vo2FuhV6zu3r0BqkdnUtK1D/DWlqdYDyJ9+8DUT ASAAW/H5X10aUZjStW2tvJUkt+Y3QWx70znGM3ktTcoxeICkLW737Xx5uOw35tigdMGJ W3dEobwKwQKpALG4pYiqb9Aj8G0k0FHYLLRMgNndrR0PukqMDxSWMl3lh9vFGGnuerDf /eM+4ZCXB2V9jcFlNjAoSQByvU4IjGWN0QvZKpt9bmHd27JfkUIHXwhTlNJBf+vzaX29 QClg== X-Gm-Message-State: ABUngvedVhl0/kOYQIaNoNglgSUheH67UB3BrsiKn7RNUWSL89tyYOL6QB4VkykiczIBqiDS X-Received: by 10.194.103.41 with SMTP id ft9mr17982838wjb.8.1477431304523; Tue, 25 Oct 2016 14:35:04 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id vf8sm27183597wjc.27.2016.10.25.14.35.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Oct 2016 14:35:03 -0700 (PDT) From: Thomas Monjalon To: "E. Scott Daniels" Date: Tue, 25 Oct 2016 23:35:02 +0200 Message-ID: <2223568.QpbvufUhIb@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1476970481-21034-1-git-send-email-daniels@research.att.com> References: <1476970481-21034-1-git-send-email-daniels@research.att.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] lib/ether: prevent duplicate callback on list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2016 21:35:05 -0000 2016-10-20 09:34, E. Scott Daniels: > This change prevents the attempt to add a structure which is > already on the callback list. If a struct with matching > parameters is found on the list, then no action is taken. If > a struct with matching parameters is found on the list, then > no action is taken. Callback is not duplicate anymore but the last sentence is duplicate :) > Fixes: ac2f69c ("ethdev: fix crash if malloc of user callback fails") > > Signed-off-by: E. Scott Daniels > --- > > V2: > * Correct the component name; changed from net/ixgbe. > * Add Fixes tag. > * Acked-by: Wenzhuo Lu The Acked-by tag must be added below your Signed-off-by. Applied with above nits fixed, thanks