DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] scripts: check commits with checkpatch
Date: Tue, 07 Jun 2016 09:43:58 +0200	[thread overview]
Message-ID: <2224175.I7JDXGyCVZ@xps13> (raw)
In-Reply-To: <20160602123337.GA14836@bricha3-MOBL3>

2016-06-02 13:33, Bruce Richardson:
> On Thu, Jun 02, 2016 at 11:13:15AM +0200, Thomas Monjalon wrote:
> > The new option -n allows to give a number of commits to check
> > from the git HEAD.
> > If neither -n nor patch files are given, the commits after
> > origin/master are checked.
> > 
> 
> Yep, I love it, exactly what I wanted to replace my own checkpatch script wrapper!
> 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Testing this out here, I find that git format-patch includes the diff stats
> in the output, which then can trigger long-line warnings for the commit message.
> 
> 	WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> 	#8:
> 	 examples/my-new-test-app/basicfwd.c | 342 +++++++++++++++++++++++++++++++++++++
> 
> To fix this, I suggest replacing "format-patch --stdout" with "show --format=email"
> since that should give the same output just without the change stats.
> 
> With this one adjustment:
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied with --no-stat adjustment.

      parent reply	other threads:[~2016-06-07  7:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02  9:13 Thomas Monjalon
2016-06-02 12:33 ` Bruce Richardson
2016-06-02 13:15   ` Thomas Monjalon
2016-06-02 13:23     ` Bruce Richardson
2016-06-07  7:43   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2224175.I7JDXGyCVZ@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).