From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53D91A0471 for ; Thu, 18 Jul 2019 17:01:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 645C5276C; Thu, 18 Jul 2019 17:01:29 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 5B7BB1B53 for ; Thu, 18 Jul 2019 17:01:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4A173205; Thu, 18 Jul 2019 11:01:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 18 Jul 2019 11:01:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=jlENZk2LwDZ3Yl/Qdr0k83SQnQh085Kxvgh/Snf8y3A=; b=XMXQ+ch0maEL YyxhS7UoCUwHr5fMeSHLrtbGfKEL5EhCR0hlDyUWEVoygQw0Qowq0taC68SgxZfz WFQ8D7T2gJ6zTLWBDApwLtmQicTbz0MCcQj6GIge7knHpXO0HXi77zU8tHH2BzWD YABGkFy76Cq6fnhfTEYe8hUhHSa/j64= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=jlENZk2LwDZ3Yl/Qdr0k83SQnQh085Kxvgh/Snf8y 3A=; b=F1MIB9aA7jNJS6pnHN/uavIU/82bclXQzaFMjA7svvst+onceF2iNCNDD LLNi6+BnCZBHh09q+k2kZplNtaiitsldXVwbLfQtJGtF6m+mzTkRYk13GCfiqu/f vqiLjxCDFLoBGNFcTT2QkfzeKt3JpSA4ygMDX3OK188y5UF0NmZCaU+y0iIcp3zo fJQcS8TtoWYCHDxC78SX7FaYCR1QWmUOZOsTHkNtAcP31M66JU9cxh//ZCAwg4MX p8MKehBBVAROHBXqY+NJF3Pd00It5eNS9+s4rBZBGQXgGoyDhgFGegXP2HZZnY90 3qD7XnJ0N0cmMwomDGdCIetuVcUSg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrieehgdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8E8558005A; Thu, 18 Jul 2019 11:01:25 -0400 (EDT) From: Thomas Monjalon To: "Chautru, Nicolas" Cc: "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" Date: Thu, 18 Jul 2019 17:01:24 +0200 Message-ID: <2224673.gYMo2qQLZG@xps> In-Reply-To: <1183128033837D43A851F70F33ED5C575C1FD4AB@FMSMSX109.amr.corp.intel.com> References: <1563431079-14170-1-git-send-email-nicolas.chautru@intel.com> <2765522.ij6KrxUR9P@xps> <1183128033837D43A851F70F33ED5C575C1FD4AB@FMSMSX109.amr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: fix PDF build of bbdev prog guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/07/2019 16:43, Chautru, Nicolas: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > >3 comments above the change of references: > > > >- there are a lot more, please search for the word "section" > > All the ones I could see are similar to "as per 3GPP TS 38.212 section 5.2.2" which is does not refer to a section within DPDK documentation but to external 3GPP specs documents. You're right! I completely overlooked it. > >- it deserves a separate commit > > OK. And you want such a commit now for 19.09 or later on? Given there are only 2 figure refs, it can stay with PDF fix. > >- the line length should be below 100 chars, better below 80. > >The ideal is to break lines logically after a punctuation sign, or between "subject" and "verb", etc. > >Example: > > Figure :numref:`figure_turbo_tb_encode` above > > showing the Turbo encoding of CBs using BBDEV interface in TB-mode > > is also valid for LDPC encode. > > All lines are less than 100 chars, but a few places are >80 chars. Let me know if you want this changed for 19.09 or later. The rule is to not do cosmetic change :) I was explaining the line breaking for the lines you were changing while fixing figure ref. I think I will apply this patch and adjust the line breaking if needed. Is it OK?