From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1783E1B217 for ; Sun, 12 Nov 2017 03:48:43 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 91CA620A11; Sat, 11 Nov 2017 21:48:43 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sat, 11 Nov 2017 21:48:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=zodhPlAzI/2Mvw8Qp0yu0bAnTS rT/d3ux13nM213OpA=; b=ZZNIFE4p1Ez4pRSY4L2E9wiHBo/C9NnFeNvjLcybI1 2lF1krxVv61upSM44wXIrJ9RAyNjjr+/gFJeeti/ae+2LD+gTidGuJmrbEhWCsae Iv7QBqmDS95Wmf7M4araoTr9uM0B+cGCyHUk0Cn8+Zd/M85C5XApicd1bOLdKoBC 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=zodhPl AzI/2Mvw8Qp0yu0bAnTSrT/d3ux13nM213OpA=; b=qeKqNFVOJruKb0STN4xG/6 iIxHyH6HrddaHu+wTho3pRLcNwLpUlrHkMTRLDOYRnvE8ksGg+S8pGebim4oYK1n qGN8fzolhW8cAMyXV/LW3sjBEowDC+EcdbvXoNIGL1A8f6vty239blxCNGLUiV/B BSwRfz/FpjNpBR9U3vcHnk5G3EX4gwC7Nr+ncbGanodV2BcPWWvIqiZzkL6E5wDm F2YI0fP7EJ940J/61WgV9Go2Yq1kRxf0OoExMQRDvrvqhHBjhhehlh9d4JZZlFAS oA09GZJvp/9jLqIBohyGjZszaoIFqOBnwbZ0fOksAXK5kfdPJ00a+5RfYcKIbEGg == X-ME-Sender: Received: from xps.localnet (unknown [70.158.100.224]) by mail.messagingengine.com (Postfix) with ESMTPA id 5CF41240F8; Sat, 11 Nov 2017 21:48:43 -0500 (EST) From: Thomas Monjalon To: Radoslaw Biernacki Cc: dev@dpdk.org, sergio.gonzalez.monroy@intel.com, santosh.shukla@caviumnetworks.com, anatoly.burakov@intel.com Date: Sun, 12 Nov 2017 03:48:41 +0100 Message-ID: <2225299.YYgmiRYW01@xps> In-Reply-To: <1510251272-32549-1-git-send-email-radoslaw.biernacki@linaro.org> References: <1510251272-32549-1-git-send-email-radoslaw.biernacki@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test/memory: fixing line parsing in memory autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Nov 2017 02:48:44 -0000 09/11/2017 19:14, Radoslaw Biernacki: > This patch fixes three problems in memory autotest: > - the regex for IOVA > - missing validation of second and following output lines > - propagation of error to consecutive tests > - conversion base for mem size (hex indtead of dec) > First fix is for changes introduced with IOVA, the regex was not > updated which lead to unit test failure. Patch now also uses loop for > line outputs processing to verify more than just one line. By this we > also satisfy the pexpect() and scan the "Test OK"/"Test Failed" so in > case of error all output lines are consumed and does not break the > consecutive test (error does not propagate). > > Fixes: 7ba49d39f14c ("mem: rename segment address from physical to IOVA") > Fixes: b4ce15aa2bc7 ("app/test: fix memory autotest") > > Signed-off-by: Radoslaw Biernacki Applied, thanks