From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 097CD1B6A1
 for <dev@dpdk.org>; Wed,  9 May 2018 16:47:15 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 875F7210CB;
 Wed,  9 May 2018 10:47:14 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 09 May 2018 10:47:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=yAgw2zj8UUpp+AFyQWNFr3OOUV
 qFp+LscHw6xk+o+aM=; b=cof9+99GAw04EZbnhk63e4uz/bhHyPMoGLO0uaB2un
 tYshBmBAiAuaF1/77aEd+C9L2nZPMjJtNi55gKaqmhoBWwMXvqULwpjWamN9azNz
 MkqPo5/+qe2At2cHQoMaf9MzS1OqOOq8kIMM1PaLcVb68/aUA29uV3ohlhpX8kVe
 c=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=yAgw2z
 j8UUpp+AFyQWNFr3OOUVqFp+LscHw6xk+o+aM=; b=PIqTVX5nJCVxQe2E5E+kRT
 NgNa2p/6ciPc8/GFC3cTaKgcKUMxyv/j1wBPJDjtQNsR3iMcDxWCwOEA26eENlru
 W0w4u93uP6bNHXkRmvgWX1iEIXWwSuXakCjXWRrrrE8gXVusJGtpEMQZjCUUNoC0
 J7gzdTCpItURlFh4FjEQU0f2leDU0wExRhiN7/n5Zk/YYMI+bxRG5EnBr224m6p6
 ba6nWw60dzkztJolTgBddGGr0OrH6FsZqJqOh6i5aG8eYcs2Zwdg0pBA4lfFi06P
 vmICeoJWPBkKcZnp4FOBukcwmI82uEBKH3K7vCC8S3TUbLPLAcIUiAwsH/43R1Sg
 ==
X-ME-Sender: <xms:8gnzWhVB1j_X22pO0TOAsFDkn4QQPBmrMruArIgE5It0aZ5iWyxVbg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id DF43AE4076;
 Wed,  9 May 2018 10:47:12 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Xu, Rosen" <rosen.xu@intel.com>
Cc: dev@dpdk.org, roy.fan.zhang@intel.com, declan.doherty@intel.com,
 bruce.richardson@intel.com, shreyansh.jain@nxp.com, ferruh.yigit@intel.com,
 konstantin.ananyev@intel.com, tianfei.zhang@intel.com, song.liu@intel.com,
 hao.wu@intel.com, gaetan.rivet@6wind.com, Yanglong Wu <yanglong.wu@intel.com>
Date: Wed, 09 May 2018 16:47:11 +0200
Message-ID: <2225742.ccNGmmKHOr@xps>
In-Reply-To: <1525851801-16101-4-git-send-email-rosen.xu@intel.com>
References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com>
 <1525851801-16101-1-git-send-email-rosen.xu@intel.com>
 <1525851801-16101-4-git-send-email-rosen.xu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v10 3/3] iFPGA: Add Intel FPGA BUS Rawdev
	Driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 09 May 2018 14:47:15 -0000

09/05/2018 09:43, Xu, Rosen:
> From: Rosen Xu <rosen.xu@intel.com>
> 
> Add Intel FPGA BUS Rawdev Driver which is based on
> librte_rawdev library.
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

I have a compilation error:
	drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c:10:15: error:
	instruction requires: AVX-512 ISA

because of vmovdqu64:

#if defined(RTE_ARCH_X86_64)
static inline void copy512(const void *src, void *dst)
{
    asm volatile("vmovdqu64 (%0), %%zmm0;"
             "vmovntdq %%zmm0, (%1);"
             :
             : "r"(src), "r"(dst));
}
#else
static inline void copy512(const void *src, void *dst)
{
    UNUSED(src);
    UNUSED(dst);
    WARN_ON(1);
}
#endif

I suggest to fix it quickly without waiting a v11 with this:

static inline void copy512(const void *src, void *dst)
{
#ifdef CC_SUPPORT_AVX512F
    asm volatile("vmovdqu64 (%0), %%zmm0;"
             "vmovntdq %%zmm0, (%1);"
             :
             : "r"(src), "r"(dst));
#else
    UNUSED(src);
    UNUSED(dst);
    WARN_ON(1);
#endif
}

It does not make any runtime detection, but it's better than previously.