From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E707CA04B6; Sun, 11 Oct 2020 22:45:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 950681D407; Sun, 11 Oct 2020 22:45:15 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 763CE1BACC for ; Sun, 11 Oct 2020 22:45:13 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id DDDEADEE; Sun, 11 Oct 2020 16:45:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 11 Oct 2020 16:45:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= E9jHcSJqePYypj3p3Me2cLK6LowNrVzdFiw8ic3T9Ck=; b=uDXKsxETPXL7T+ku 7M/Z7CvA05os76TV14BZF7FkbPpAZkvCqVJ7F18rAnxSnhJwxsbs8XWEzcUI9Zky UdBh+tdGT1q6AcGy8CUujmeA+wau1lWbnO34osXmvENpHWxXPrq3SpJFRz1ih1FF 4wsN5Gd83/51Drvb+yTltFw737rxdMY5EUJLGJq102Q+tAgUpq0pGBL6CDRmApwN ZBeXT1KEDrfBFmHlBwQdzMm19OFBjGLpcmC7feG3WaLRPdH1+OLvVtCdDaRm3y2Z tL9X+6JGl85dIIg/xzplCU7SAVMiRl1NbXN5atCJtPD3XqbIzIeFOL2BF9lJlJVC /zL55w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=E9jHcSJqePYypj3p3Me2cLK6LowNrVzdFiw8ic3T9 Ck=; b=I5FmFo0sd08eWFl92Yp7iDWpSEeYRuLNyYDrmK8jD1z2SDmztApZ8MFn7 TN1IRYpiAMfkY2rPm+UBF+QZN2rWgrJgSr00sTVZS7AsHsOJTegm4ygc/wzo8hKu D+xZDhmcSU2yB3ZdpPeoIfdA8+dj1FeChZSs6wFokMfIjoCBE8+s/F+xgo5yLLPx qtWiDy8wFbfa7T9fgxulA3f9w8NXQJ4EPOV+gpNKSgeCaOrGk6LJzXeB9rG4sOQL J1RScF6/ZK+ylKtAu97ZsLjwdZhQH3vsLJA+d25MFV8hGGERFdfKAXW8LeeOVxJi 1gMbB7j4afqpF7t2S30W5Tvpo9JOQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrheehgdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 577C53064680; Sun, 11 Oct 2020 16:45:09 -0400 (EDT) From: Thomas Monjalon To: Ciara Power Cc: dev@dpdk.org, Kevin Laatz , Nicolas Chautru , Declan Doherty , Reshma Pattan , Maryam Tahhan , Jerin Jacob Date: Sun, 11 Oct 2020 22:45:08 +0200 Message-ID: <22257423.cBENzMQE98@thomas> In-Reply-To: <20201009102140.20730-12-ciara.power@intel.com> References: <20200807123009.21266-1-ciara.power@intel.com> <20201009102140.20730-1-ciara.power@intel.com> <20201009102140.20730-12-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 11/14] doc: remove reference to make from tools guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/10/2020 12:21, Ciara Power: > Make is no longer supported for compiling DPDK, references are now > removed in the documentation. > > Signed-off-by: Ciara Power > Reviewed-by: Kevin Laatz > Acked-by: Nicolas Chautru > > --- > v6: > - Fixed indentation for testbbdev list entry. > v5: > - Reworded sentence in pdump doc. > - Replaced references to testbbdev binary with dpdk-test-bbdev. > - Fixed links to linux_gsg doc. > --- > doc/guides/tools/comp_perf.rst | 10 ++------ > doc/guides/tools/cryptoperf.rst | 20 +++------------- > doc/guides/tools/pdump.rst | 15 +++++------- > doc/guides/tools/proc_info.rst | 2 +- > doc/guides/tools/testbbdev.rst | 38 +++++++++---------------------- > doc/guides/tools/testeventdev.rst | 21 ++++++++--------- > 6 files changed, 32 insertions(+), 74 deletions(-) > > diff --git a/doc/guides/tools/comp_perf.rst b/doc/guides/tools/comp_perf.rst > index ee585d1024..269d7bdc9d 100644 > --- a/doc/guides/tools/comp_perf.rst > +++ b/doc/guides/tools/comp_perf.rst > @@ -100,13 +100,7 @@ Application Options > Compiling the Tool > ------------------ > > -**Step 1: PMD setting** > - > -The ``dpdk-test-compress-perf`` tool depends on compression device drivers PMD which > -can be disabled by default in the build configuration file ``common_base``. > -The compression device drivers PMD which should be tested can be enabled by setting e.g.:: > - > - CONFIG_RTE_LIBRTE_PMD_ISAL=y > +See :doc:`../linux_gsg/build_dpdk` for compilation steps. Funnily there was only one step in this section. I don't see any benefit of referencing how to compile on Linux everywhere. I think it would be better to just drop the whole section about compilation. > Running the Tool [...] > --- a/doc/guides/tools/cryptoperf.rst > +++ b/doc/guides/tools/cryptoperf.rst > @@ -33,19 +33,8 @@ the hardware accelerator fully loaded and so measure maximum throughput. > Compiling the Application > ------------------------- > > -**Step 1: PMD setting** > > -The ``dpdk-test-crypto-perf`` tool depends on crypto device drivers PMD which > -are disabled by default in the build configuration file ``common_base``. > -The crypto device drivers PMD which should be tested can be enabled by setting:: > - > - CONFIG_RTE_LIBRTE_PMD_=y > - > -Setting example for open ssl PMD:: > - > - CONFIG_RTE_LIBRTE_PMD_OPENSSL=y > - > -**Step 2: Linearization setting** > +**Step 1: Linearization setting** > > It is possible linearized input segmented packets just before crypto operation > for devices which doesn't support scatter-gather, and allows to measure > @@ -56,13 +45,10 @@ To set on the linearization options add below definition to the > > #define CPERF_LINEARIZATION_ENABLE > > -**Step 3: Build the application** > +**Step 2: Build the application** > > -Execute the ``dpdk-setup.sh`` script to build the DPDK library together with the > -``dpdk-test-crypto-perf`` application. > +See :doc:`../linux_gsg/build_dpdk` for compilation steps. > > -Initially, the user must select a DPDK target to choose the correct target type > -and compiler options to use when building the libraries. > The user must have all libraries, modules, updates and compilers installed > in the system prior to this, > as described in the earlier chapters in this Getting Started Guide. Same here, I would keep only the "Linearization setting". > --- a/doc/guides/tools/testbbdev.rst > +++ b/doc/guides/tools/testbbdev.rst > @@ -13,25 +13,10 @@ parameters passed to a python running script. > Compiling the Application > ------------------------- > > -**Step 1: PMD setting** > +**Build the application** > > -The ``dpdk-test-bbdev`` tool depends on crypto device drivers PMD which > -are disabled by default in the build configuration file ``common_base``. > -The bbdevice drivers PMD which should be tested can be enabled by setting > +See :doc:`../linux_gsg/build_dpdk` for compilation steps. > > - ``CONFIG_RTE_LIBRTE_PMD_=y`` > - > -Setting example for (*baseband_turbo_sw*) PMD > - > - ``CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW=y`` > - > -**Step 2: Build the application** > - > -Execute the ``dpdk-setup.sh`` script to build the DPDK library together with the > -``dpdk-test-bbdev`` application. > - > -Initially, the user must select a DPDK target to choose the correct target type > -and compiler options to use when building the libraries. > The user must have all libraries, modules, updates and compilers installed > in the system prior to this, as described in the earlier chapters in this > Getting Started Guide. Same here, there is no value in repeating these obvious considerations about compilation. [...] > --- a/doc/guides/tools/testeventdev.rst > +++ b/doc/guides/tools/testeventdev.rst > @@ -15,11 +15,8 @@ Compiling the Application > > **Build the application** > > -Execute the ``dpdk-setup.sh`` script to build the DPDK library together with the > -``dpdk-test-eventdev`` application. > +See :doc:`../linux_gsg/build_dpdk` for compilation steps. > > -Initially, the user must select a DPDK target to choose the correct target type > -and compiler options to use when building the libraries. > The user must have all libraries, modules, updates and compilers installed > in the system prior to this, > as described in the earlier chapters in this Getting Started Guide. Same here