From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 72BF75B30 for ; Wed, 3 Oct 2018 21:16:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 181F121B62; Wed, 3 Oct 2018 15:16:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 03 Oct 2018 15:16:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=tPmqBRn/iHuar8zWzkF8oCwwmJa3xK+dU+GBZmsbt3Q=; b=oZeljfHs7t2U XKBFsa7ZdeH+3RW/7KkTRylEwB9W3TorpNoEBbMPd8aiErtT26d3allK5DL5ECwK uRxtuSbicyCeUPx8bTNzxRXJbS6KmsI/mnpXvR857feM02dfBgd+h09QNz5GRXUZ SamqtlajNJ+j3kks3qGLszj6HOg2KXM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=tPmqBRn/iHuar8zWzkF8oCwwmJa3xK+dU+GBZmsbt 3Q=; b=Ps9FjHFvH773axmgoedTaJ28Y6EFiOg4DDwLnSOhuaOe9ec2k3uVQj7XW 5Q3okyzyGjoMKnmiJApvGSH+qvzF905bi9SwOZn2WWfdmmw+FNyPv38xMbHb22qn RhVRKJsLrwt/5N2M6Xdxp6sqRkVJmi9/2p/7zpeIlpBKUW2aW913A3WoWCvdi82A zE0YwwWUYW7amPFmHS7iDF3pDsrGiMd1hR4pMcEOrszAh4k4M3odFMaE7McQ42ro ioQ492tIGTHwrt1ZqkpHtnb2sSxeBv1OV1Ps/HzYIHzMAghWWqN1Ro1/FFbThFl0 SK04qOwZunlS2xHhWxMf2Q2AbHryQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4BBA9E4179; Wed, 3 Oct 2018 15:16:15 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Rahul Lakkireddy , Wenzhuo Lu , Qi Zhang , Xiao Wang , Konstantin Ananyev , Rasesh Mody , Harish Patil , Shahed Shaikh , Yong Wang , dev@dpdk.org Date: Wed, 03 Oct 2018 21:16:13 +0200 Message-ID: <2226451.sCb16aOFOU@xps> In-Reply-To: <1d72af01-ec77-0d5f-12a7-9a612f06982a@intel.com> References: <20180920001853.23454-1-thomas@monjalon.net> <2353010.843Iz9OGFG@xps> <1d72af01-ec77-0d5f-12a7-9a612f06982a@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 19:16:17 -0000 03/10/2018 16:11, Ferruh Yigit: > On 9/25/2018 10:04 AM, Thomas Monjalon wrote: > > 25/09/2018 10:03, Ferruh Yigit: > >> On 9/24/2018 5:59 PM, Thomas Monjalon wrote: > >>>>> --- a/drivers/net/ixgbe/ixgbe_rxtx.c > >>>>> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > >>>>> @@ -2025,7 +2025,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rt= e_mbuf **rx_pkts, uint16_t nb_pkts, > >>>>> struct ixgbe_rx_entry *next_rxe =3D NULL; > >>>>> struct rte_mbuf *first_seg; > >>>>> struct rte_mbuf *rxm; > >>>>> - struct rte_mbuf *nmb; > >>>>> + struct rte_mbuf *nmb =3D NULL; > >>>> > >>>> This change is unrelated. Can we separate this one? > >>> > >>> Yes it looks unrelated but it becomes necessary when including stdboo= l.h. > >>> I don't know the root cause, but yes, it may deserve a separate commi= t. > >>> Maybe an ixgbe maintainer can take care of it? > >> > >> Why becomes necessary? Does it give a build warning etc? > >> My concern is this is in data path, one extra assignment, it would be = better to > >> confirm it is really needed. > >=20 > > Yes I had a compilation error. > > If you cannot reproduce it, I will try to re-run my compilation tests. >=20 > I got the error with gcc [1] but it seems false positive and only generat= ed when > included in ixgbe_rxtx.c, so this is an odd one, I am not abl= e to > find root cause. >=20 > But since it is false positive, what do you think adding compiler option = to > disable this warning for this file? I don't like disabling warnings on files. We can take time to work on this patch. It is not required for 18.11. > [1] > .../drivers/net/ixgbe/ixgbe_rxtx.c:2139:14: error: =E2=80=98nmb=E2=80=99 = may be used > uninitialized in this function [-Werror=3Dmaybe-uninitialized] > rxe->mbuf =3D nmb; > ~~~~~~~~~~^~~~~ >=20 > $ gcc --version > gcc (GCC) 8.1.1 20180712 (Red Hat 8.1.1-5)