From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 134EA456E5; Mon, 29 Jul 2024 18:56:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C13E840DF8; Mon, 29 Jul 2024 18:56:07 +0200 (CEST) Received: from fout4-smtp.messagingengine.com (fout4-smtp.messagingengine.com [103.168.172.147]) by mails.dpdk.org (Postfix) with ESMTP id 54EB140A81 for ; Mon, 29 Jul 2024 18:56:06 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfout.nyi.internal (Postfix) with ESMTP id 136851380512; Mon, 29 Jul 2024 12:56:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 29 Jul 2024 12:56:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1722272165; x=1722358565; bh=QHjkxZZdqk0++xsapAUnpT/itSYiwIMScq7gYSSV1eQ=; b= waPefckqIceXBoEdMIzeMSUH2qi1ixUJNwqp03b7AdVHOL1RB5Aoqsud74k2F+kD iFnlh2MiLYOr/Pg5Y18p6dO5oh4iqEmr7cjVvr5dRiqDWjAsKkmVbo5kN62Uhtrv adJTYGSt2ydYMTbkXTPE/eKI0jVAv8DfCFc+RRKkgPKBCebGN6EA41xAcHSCclE1 7MOjmfa0JDjUqlqLgMkBzqhCz7nHrzAl8h1iltI7UOzAM4Vt3ZrGp3PxMGtNmcvc gqfNDPTQWV3WtRorGZvoleHEq6VDe1EKDQDtEEERVGkFX0qd91FyxNYDYfvZwQNm C+aw9zwivfmUbmePnq0I3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1722272165; x= 1722358565; bh=QHjkxZZdqk0++xsapAUnpT/itSYiwIMScq7gYSSV1eQ=; b=v m/NCG9Y3RZfeWn6GlaE1cR1W0/LKVk8d4QE9BhJImlpVpr12tNRvybATtJDMhaEe SAgREW5S59w8AojfQ5ymz0nV1SLwl4ZDMuj1fe8iM+tqJ8QHsjYkq997Em8PtUJP nuClWBgmB1yKOY9GlEc3UGFf5MfWuJ7Pf+q9KxP6cur6Wuu5+lFtBgTz8q04bwvB 4m++RA7+syK6qf18M2AGhUQxbdxsH6C0Lbwy7j0m6hbmv39Yv6kavggYM0wjDY6n PSIH6sb5HEkXNC9JKUiMgYj0XDNU46GOg7ktEsDNYtUL1IQ+KM7xIIN1cSbUWgvO xC55JIVmE/LNS0HhZT32g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrjedvgddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefffegheetieeuhfdtleehgfetheehteegueegieeuiedvtdei tdetleeijedugfenucffohhmrghinheppghlohhgghgvrhdrihhnfhhonecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhn jhgrlhhonhdrnhgvthdpnhgspghrtghpthhtoheptd X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Jul 2024 12:56:02 -0400 (EDT) From: Thomas Monjalon To: jspewock@iol.unh.edu Cc: probb@iol.unh.edu, yoan.picchi@foss.arm.com, wathsala.vithanage@arm.com, Honnappa.Nagarahalli@arm.com, npratte@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, dev@dpdk.org, Juraj =?utf-8?B?TGlua2XFoQ==?= Subject: Re: [PATCH v6 0/3] Improve interactive shell output gathering and logging Date: Mon, 29 Jul 2024 18:56:00 +0200 Message-ID: <2227653.1BCLMh4Saa@thomas> In-Reply-To: <6ac8b8eb-efb4-4a3f-a78f-1f66dfa70fd1@pantheon.tech> References: <20240501161623.26672-1-jspewock@iol.unh.edu> <20240724183914.436188-1-jspewock@iol.unh.edu> <6ac8b8eb-efb4-4a3f-a78f-1f66dfa70fd1@pantheon.tech> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/07/2024 13:01, Juraj Linke=C5=A1: > For series: > Reviewed-by: Juraj Linke=C5=A1 >=20 > On 24. 7. 2024 20:39, jspewock@iol.unh.edu wrote: > > From: Jeremy Spewock > >=20 > > v6: > > * Fix error catch for retries. This series changed the error that > > is thrown in the case of a timeout, but it was originally overlooked > > that the context manager patch added a catch that is looking for the > > old timeout error. This version fixes the patch by adjusting the > > error that is expected in the context manager patch to match what > > this series changes it to. > >=20 >=20 > Here's the diff for anyone interested: > diff --git=20 > a/dts/framework/remote_session/single_active_interactive_shell.py=20 > b/dts/framework/remote_session/single_active_interactive_shell.py > index 7014444d0c..77a4dcefdf 100644 > --- a/dts/framework/remote_session/single_active_interactive_shell.py > +++ b/dts/framework/remote_session/single_active_interactive_shell.py > @@ -150,7 +150,7 @@ def _start_application(self) -> None: > try: > self.send_command(start_command) > break > - except TimeoutError: > + except InteractiveSSHTimeoutError: > self._logger.info( > f"Interactive shell failed to start (attempt=20 > {attempt+1} out of " > f"{self._init_attempts})" >=20 > self.send_command raises InteractiveSSHTimeoutError (and not=20 > TimeoutError) which is why we needed this change. >=20 > > Jeremy Spewock (3): > > dts: Improve output gathering in interactive shells > > dts: Add missing docstring from XML-RPC server > > dts: Improve logging for interactive shells Applied, thanks.