From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74C55A00B8; Sun, 27 Oct 2019 22:22:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7576C1BEFF; Sun, 27 Oct 2019 22:22:26 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 6319A1BEF9 for ; Sun, 27 Oct 2019 22:22:24 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DF6142229F; Sun, 27 Oct 2019 17:22:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 27 Oct 2019 17:22:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=AOjMY/xgAxlo7XvkoTW30du/yDMtJSbv/+wd3I3txOU=; b=Lu69coCcQINy 5GXUe27sedHjFJri78xdqzDvV4fmMfrvetOIY5laQR7TQU4jD/xlOW+saWYLyZDg wKqWR1wqqiKt0JpxtmNtYUCFFYC3TzndBWPNHumAcsjm0gsgu4yclKqtCTxFG/4+ /bHStwAntCu32FuxKckj7+xrngFNwu0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=AOjMY/xgAxlo7XvkoTW30du/yDMtJSbv/+wd3I3tx OU=; b=K6kazA3nhYyCmFyXkZ7NGJJncTSn3qM51P4MVa8V61hAXVFDQh7Dd7uns jfwhAlVafxwpftRRtNR0aPw+IVAKytlp4KYNvS0Q7i7fHIF941FYycYSQRRAKlQn sWacECw9jNsrNPJ2pbAC7VtkhXgnx5zthcU8OPYnqk0/BWJh5AQmgurj9OLA8ODD /1BA7zRzdwWibNGT8IWLF1hp13XgeQn5JKxS0L6uplA+ZswZPxk+GgvWhD0NTfV9 ey1tTsXYYP/YjG1DCZ53w+uJ7a/Clabc6qkNB4YjmYEeEEkMOHwB0Bbp4O8pg5zs OBnpdY0i1rh+ZLF1fPIOav4RKYmgw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleejgdduheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpegrrhhmrdgtohhmpdhvrghrshdrmhhkpdhhuhgrrhhmrdgtohhmnecukfhp peejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhoh hmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8EE4AD60062; Sun, 27 Oct 2019 17:22:19 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob , Honnappa Nagarahalli , Ola Liljedahl , "Gavin Hu (Arm Technology China)" Cc: dev@dpdk.org, "pbhagavatula@marvell.com" , nd , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , bruce.richardson@intel.com Date: Sun, 27 Oct 2019 22:22:18 +0100 Message-ID: <2227745.9fKeDGhzLh@xps> In-Reply-To: References: <1564615940-13183-1-git-send-email-gavin.hu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/3] config: add arm neoverse N1 SDP configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/10/2019 07:03, Jerin Jacob: > On Wed, Oct 23, 2019 at 2:37 AM Honnappa Nagarahalli > wrote: > > > > > On Thu, 2019-08-01 at 07:48 +0800, Gavin Hu wrote: > > > > > > Arm N1 SDP is an infrastructure segment development platform based > > > > > > on armv8.2-a Neoverse N1 CPU. For more information, refer to: > > > > > > https://community.arm.com/developer/tools-software/oss-platforms/w > > > > > > / > > > > > > docs/440/neoverse-n1-sdp > > > > > > > > > > > > Signed-off-by: Gavin Hu > > > > > > Reviewed-by: Honnappa Nagarahalli > > > > > > Reviewed-by: Steve Capper > > > > > > --- > > > > > > +CONFIG_RTE_MACHINE="neoversen1" > > > > > This should probably be "n1sdp" as this is the name of the platform > > > > > that matches the below configuration. > > > > A clear definition of RTE_MACHINE is required. Jerin? > > > > > > I think, In the existing scheme of things, RTE_MACHINE defines, where to take > > > the MACHINE_CFLAGS mk/machine/xxxx/rte.vars.mk > > Ok, thank you > > > > > > > > Considering the fact that there will be a lot of reusable IPs(for CPU) from ARM > > > for armv8, I think, it would make sense to introduce RTE_MICRO_ARCH to > > > avoid a lot of code duplications and confusion. > > > > > > RTE_ARCH example: "x86" or "arm64" > > > RTE_MICRO_ARCH example: "a72" or "thunderx3" - defines > > > mcpu and armv8 verion arch etc > > > RTE_MACHINE example: "bluefield" or "thunderx3" > > > - defines, number of cores, NUMA or not? etc > > Looking at mk/machine/ directory, looks like RTE_MACHINE seems to be defining micro-architecture for Intel. For ex: hsw, nhm, wsm. I see the same for Arm as well. > > Are you suggesting that we use RTE_MICRO_ARCH to pick mk/micro-arch/xxxx/rte.vars.mk? and RTE_MACHINE would pick mk/machine/xxxx/rte.vars.mk, but contain NUMA, #of cores etc? > > Yes for Make build. I think, it is deprecated soon, so we need a > similar solution for meson. Yes I would prefer we clean the mess in Meson, instead of talking about the makefile system. And honestly, N1 is not needed in the legacy makefile system. So focusing on config/arm/meson.build, I think RTE_MACHINE is defined only for API compatibility with makefile. However, I doubt this value is used by any application. I think we can try to remove RTE_MACHINE from meson builds in DPDK 19.11, or use RTE_MACHINE as micro-arch (my preference).