From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BBE9A0521; Tue, 3 Nov 2020 14:08:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4AE5CA36; Tue, 3 Nov 2020 14:08:44 +0100 (CET) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by dpdk.org (Postfix) with ESMTP id 5A8CBCA2A for ; Tue, 3 Nov 2020 14:08:42 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id A9E86AA1; Tue, 3 Nov 2020 08:08:39 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 03 Nov 2020 08:08:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= MaicAlfILbQZP5Ayd2dvvB/+4F1502O30LnmQe6SK60=; b=pV7nf+LN0wn6XqU5 y488RfVWx4uDlxdbCtQWqYQqpsgilepvbYefU4UAeD8ha8vv3jC80+oR5pJZSh9v nZPhV/RIGqGwJD0KJmV1Ifu9domIJxIBpwO196qTGbDG4+YQBCs9Gp92CdtdHvE0 13kaJBFH7t8KWb0S4AmjdM9dm/yqcm0+BxxqhNeeMBAnxMYiK/CsKLegVpETKn2r JQWqrmpeT3I2qlJTo+u/J/1mA5tBDdQOgud+Ttud+6PfrsfplAo2msrdv+mXb7EN zQz0pFfdRu1Z6wsXPrV1QZBmuAhiZbgqrxymeecYlVltBWYAkfuP6E2NJNirT47B RtwXiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MaicAlfILbQZP5Ayd2dvvB/+4F1502O30LnmQe6SK 60=; b=OLU2/KPATOrNrdaF7MnUAzNE9tZRpWk0wzPB7ys9zwK7qatqSmUI/VxaD C0MzHoAKkgty901/bkftpaJDzwG1eHDDC4y3DrBW+kK+YLZaFVTTSsm8e3bK/Pwq g9b+RO0VjmYB+h12ievU9Tf/J7RWkwgSjzKS+j8NYNny6sSpcgDl6IwUECvGvacf TLpR4yUuIcZL8BrqugPTPqrwrp+Zj5xwQw5ywoFag4hdQT6vZos7cmbY960LLqVC ZdYg0qE7EA+d8AUWirVwrscQAgP66XV8Voxj5nbPVh1kHl7WnHTRZkxW+yTqiIty Vw+za74rPhUWSo8ResbHrn0a709eA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtfedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4B92C328005A; Tue, 3 Nov 2020 08:08:36 -0500 (EST) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, jerinj@marvell.com, viacheslavo@nvidia.com, Shepard Siegel , Ed Czeck , John Miller Date: Tue, 03 Nov 2020 14:08:35 +0100 Message-ID: <22284591.mpUPTujNPs@thomas> In-Reply-To: <2cb42b0a-972b-2af7-7aef-f28a9b4eb665@oktetlabs.ru> References: <20201029092751.3837177-1-thomas@monjalon.net> <20201103122205.183472-5-thomas@monjalon.net> <2cb42b0a-972b-2af7-7aef-f28a9b4eb665@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 04/16] net/ark: switch Rx timestamp to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2020 13:37, Andrew Rybchenko: > On 11/3/20 3:21 PM, Thomas Monjalon wrote: > > --- a/drivers/net/ark/ark_ethdev.c > > +++ b/drivers/net/ark/ark_ethdev.c > > +uint64_t ark_timestamp_rx_dynflag; > > +int ark_timestamp_dynfield_offset = -1; > > int rte_pmd_ark_rx_userdata_dynfield_offset = -1; > > int rte_pmd_ark_tx_userdata_dynfield_offset = -1; > > It is a bit confusing that naming above differs so much and > put in the same block without empty lines in between. > I guess the reason is export/no-export. May be it would > be useful to highlight it in a comment. I can add a blank line. Not sure it is worth an out of scope comment to explain that "rte_pmd_" prefixed variables are for the PMD-specific API.