DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH] lib/librte_mbuf: remove void * pointer cast
Date: Fri, 19 Jan 2018 10:37:57 +0100	[thread overview]
Message-ID: <22300087.hk3FSSTWuc@xps> (raw)
In-Reply-To: <20180119091240.25085-1-zhiyong.yang@intel.com>

Hi Zhiyong,

3 comments about patch formatting:

1/ the title must follow the convention seen in the git history.
If you use git log --oneline lib/librte_mbuf
you will see that it must start with "mbuf:"

2/ The * character does not play well when patch saved in a file,
and it is useless: "void pointer" is correct for understanding.

3/ You must Cc the maintainer as described in MAINTAINERS.
You can use devtools/get-maintainer.sh.
Here, I Cc Olivier.

Thanks


19/01/2018 10:12, Zhiyong Yang:
> It is unnecessary to cast from void * to struct rte_mbuf *,
> the change can make code more simple.
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>

  reply	other threads:[~2018-01-19  9:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19  9:12 Zhiyong Yang
2018-01-19  9:37 ` Thomas Monjalon [this message]
2018-01-19 10:01   ` Yang, Zhiyong
2018-01-19 10:05 ` Yang, Zhiyong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22300087.hk3FSSTWuc@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=zhiyong.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).