From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D6C111B040 for ; Fri, 19 Jan 2018 10:38:34 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 52C2020A8B; Fri, 19 Jan 2018 04:38:34 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 19 Jan 2018 04:38:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=O/PxRgjDj+/4z3FNnr/OlZxW9B mSPz1tZio9TBor77c=; b=dKOEJ3zcg+UZuE6/oTi1hTyJbw1nWdHIcHbweN1UBw i/z5sw9XbVZInr249uI44VXRcIQNU8dJ6Spmd7jAzMHc3ECLd8aEjlDtNohsJlkC f9KOkgCJploLmFVe+F7fl5F3M/l18f7TuBNkCn8rinqEOU1lV5U3bx1ZNbsmNyS4 E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=O/PxRg jDj+/4z3FNnr/OlZxW9BmSPz1tZio9TBor77c=; b=IW2e5pUlKx5Xeq1PNEvvOO T8uyQ+y3Zj+hj3+KGTkFc1rVIEf2Ugcs+jj4TJpZp7bhPR51uNor1DlCoIWqQ+sI KrFl4sZElToMLGU/mRp/kypy93keOBEQKp12Cd3cT0QDEfyop2jmLX4dEN6Tqzsr OuiqbxxuGyf4BkhgRtM0H074WQn0XAdSXgeqNvqSDUSrH1/pm/mMBBNbd/YBAWJ0 QXz+zcVBEbQp+k+kJ4B4IVHSnvY23vUW5h3k4M5aacCSWjMcEeW/O5E8n67ey47P 0uS7KCeHx8FPB9h6MH3KnktEkO927aNchSYPTAW+BlEWT9nk2Z1c12y6XasDeEbw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 067C8240F8; Fri, 19 Jan 2018 04:38:34 -0500 (EST) From: Thomas Monjalon To: Zhiyong Yang Cc: dev@dpdk.org, ferruh.yigit@intel.com, olivier.matz@6wind.com Date: Fri, 19 Jan 2018 10:37:57 +0100 Message-ID: <22300087.hk3FSSTWuc@xps> In-Reply-To: <20180119091240.25085-1-zhiyong.yang@intel.com> References: <20180119091240.25085-1-zhiyong.yang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] lib/librte_mbuf: remove void * pointer cast X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 09:38:35 -0000 Hi Zhiyong, 3 comments about patch formatting: 1/ the title must follow the convention seen in the git history. If you use git log --oneline lib/librte_mbuf you will see that it must start with "mbuf:" 2/ The * character does not play well when patch saved in a file, and it is useless: "void pointer" is correct for understanding. 3/ You must Cc the maintainer as described in MAINTAINERS. You can use devtools/get-maintainer.sh. Here, I Cc Olivier. Thanks 19/01/2018 10:12, Zhiyong Yang: > It is unnecessary to cast from void * to struct rte_mbuf *, > the change can make code more simple. > > Signed-off-by: Zhiyong Yang