From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F3A042CB7; Wed, 14 Jun 2023 17:53:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDEDD40FAE; Wed, 14 Jun 2023 17:53:06 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 9CE1E40E0F for ; Wed, 14 Jun 2023 17:53:05 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 2F3BC320077A; Wed, 14 Jun 2023 11:53:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 14 Jun 2023 11:53:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1686757983; x=1686844383; bh=T5gBnYogj6T/Hl9gWCsjfZTM6yRyTBxD77h WDF3H1rM=; b=NTQ4pRkNf3U8vM0/WOf2wwpYsViQYgaIL6qBj5vfC/w9y+mst7+ Hp4r0g8krqxMJNG094G/cjAYXuWXfCbrO3x5TY1ZPN1/DvEgfCdKAC1eXDMvgzCg yb53P0TuGROZTCHgV9XTUCf9IkcrDBReamB5Rj2HyRk1me0VHV/FHJ1fjuqbweD0 hyt5YwP6zxUDzDlnl0dhv6k/BX2UE2qSPpPbfuzLCEYL+ZTAyPmn9Haky68Yb35g XPyWMwLZzUotAkCizVlrGwKIWShS4dxZa+7Gtv1b6BPcUfFAeY2MLVJHB1z4lRPE f9U7QjNCikw7VTvuBK1VS9rzOaEB3I7iEPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1686757983; x=1686844383; bh=T5gBnYogj6T/Hl9gWCsjfZTM6yRyTBxD77h WDF3H1rM=; b=qSlKKP+M0EBD38TDRMQpQr7jOjSOuhMDAqDoCrGJO7R1+xrClNg tDTHQTcZB3g22vTwT196cBezhcloWPrseDUe4/N+4w0q0BEYZKTxxapBoHaCUScP Fs1FYFpq8dfzGg1twloYhrxm2tyciJ3eU8dmO7sY4Vl++lmbCnOCE/DKQBJslvoO fvhAOf249rM15jiMpDOUeyxkfriv00m6nwgjUzWGon0OFuu+mEdW129pCwQme8XE LQnuPYGvHOf4Fzd4H4qIamLNm/pnHMIkGvn4ChS8ZrH4PdFkOX05sYi9yb0pKecK N7nyxv0Q6v3d4gwUl4yLPcnQ2yXRR8ntQ4w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvtddgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jun 2023 11:53:02 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob , David Marchand Cc: dev@dpdk.org Subject: Re: [PATCH 0/5] cleanup in library header files Date: Wed, 14 Jun 2023 17:53:01 +0200 Message-ID: <2230042.HovnAMPojK@thomas> In-Reply-To: References: <20230614142651.1456116-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/06/2023 17:08, David Marchand: > On Wed, Jun 14, 2023 at 4:42=E2=80=AFPM Jerin Jacob wrote: > > > > On Wed, Jun 14, 2023 at 8:01=E2=80=AFPM Thomas Monjalon wrote: > > > > > > While pulling some trees for DPDK 23.07-rc1, > > > I've seen that some wrong coding style for comments > > > were copied over and over. > > > > > > In order to avoid copying wrong comment style, > > > the three first patches are fixing a lot of comments. > > > As it is not critical, they are not marked for backport. > > > > > > While looking the header files, I've fixed some misuses of "extern". > > > > Thanks for the cleanup. IMO, it is better to update > > ./devtools/checkpatches.sh or so to flag these issue before getting to > > repo for new changes, >=20 > Those are not easy to spot. > +1 to add a check if that won't raise false positives. It will raise false positives. And these are minor issues. I think we can do a cleanup every 5 years, it is OK :)